From: Mimi Zohar <zohar@linux.ibm.com>
To: Richard Guy Briggs <rgb@redhat.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Paul Moore <paul@paul-moore.com>,
sgrubb@redhat.com, omosnace@redhat.com, eparis@parisplace.org,
serge@hallyn.com, mjg59@google.com
Subject: Re: [PATCH ghak109 V2] audit: link integrity evm_write_xattrs record to syscall event
Date: Tue, 26 Mar 2019 16:40:30 -0400 [thread overview]
Message-ID: <1553632830.4233.3.camel@linux.ibm.com> (raw)
In-Reply-To: <087489b21e50bcda65c6af3e038394d5bfe09e00.1553626080.git.rgb@redhat.com>
Hi Richard, Paul,
On Tue, 2019-03-26 at 14:49 -0400, Richard Guy Briggs wrote:
> In commit fa516b66a1bf ("EVM: Allow runtime modification of the set of
> verified xattrs"), the call to audit_log_start() is missing a context to
> link it to an audit event. Since this event is in user context, add
> the process' syscall context to the record.
>
> In addition, the orphaned keyword "locked" appears in the record.
> Normalize this by changing it to logging the locking string "." as any
> other user input in the "xattr=" field.
>
> Please see the github issue
> https://github.com/linux-audit/audit-kernel/issues/109
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Acked-by: Mimi Zohar <zohar@linux.ibm.com>
Paul, were you planning on upstreaming this patch?
Mimi
next prev parent reply other threads:[~2019-03-26 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 18:49 [PATCH ghak109 V2] audit: link integrity evm_write_xattrs record to syscall event Richard Guy Briggs
2019-03-26 20:40 ` Mimi Zohar [this message]
2019-03-26 23:58 ` Paul Moore
2019-03-27 15:04 ` Mimi Zohar
2019-03-27 22:14 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553632830.4233.3.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=eparis@parisplace.org \
--cc=linux-audit@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mjg59@google.com \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=serge@hallyn.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.