From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E76C43381 for ; Sat, 30 Mar 2019 20:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5EB92146F for ; Sat, 30 Mar 2019 20:55:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="Lrax9P8w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730563AbfC3Uz3 (ORCPT ); Sat, 30 Mar 2019 16:55:29 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:53808 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730395AbfC3Uz2 (ORCPT ); Sat, 30 Mar 2019 16:55:28 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 7B83A8EE051; Sat, 30 Mar 2019 13:55:28 -0700 (PDT) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m8aaSN0NX5Kw; Sat, 30 Mar 2019 13:55:28 -0700 (PDT) Received: from [153.66.254.194] (unknown [50.35.68.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id E1D768EE03B; Sat, 30 Mar 2019 13:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1553979328; bh=M1rkqHQ0qySXvprNY+IuEVst6PM3t1CVisDqMbW2/jw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Lrax9P8wHO/yWa1e/Pa7DQZkrYruohkHLRw557h9oDSlNQRYMvcYKxKqbVPUcDGBF WIH2F6jiq6RqI+EI0ja37Yd3s2/79lAcSrIloO2aL6XuzF8+48UKbEuF8o9rgejfpe JCilvNjGFDXN5UxVgmpCck7V+QsdIQBlpkNwK8JI= Message-ID: <1553979326.2893.19.camel@HansenPartnership.com> Subject: Re: FAILED: patch "[PATCH] USB: gadget: f_hid: fix deadlock in f_hidg_write()" failed to apply to 4.9-stable tree From: James Bottomley To: Greg KH Cc: rgerganov@vmware.com, felipe.balbi@linux.intel.com, stable@vger.kernel.org Date: Sat, 30 Mar 2019 13:55:26 -0700 In-Reply-To: <20190330202307.GA27435@kroah.com> References: <1553975841150122@kroah.com> <1553976383.2893.15.camel@HansenPartnership.com> <20190330202307.GA27435@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, 2019-03-30 at 21:23 +0100, Greg KH wrote: > On Sat, Mar 30, 2019 at 01:06:23PM -0700, James Bottomley wrote: > > On Sat, 2019-03-30 at 20:57 +0100, gregkh@linuxfoundation.org > > wrote: > > > The patch below does not apply to the 4.9-stable tree. > > > If someone wants it applied there, or to any other stable or > > > longterm > > > tree, then please email the backport, including the original git > > > commit id to . > > > > [...] > > > > > Cc: stable@vger.kernel.org # 4.11+ > > > Fixes: 749494b6bdbb ("usb: gadget: f_hid: fix: Move IN request > > > allocation to set_alt()") > > > > The cc: stable specifies 4.11+ because the commit it fixes went in > > in > > the 4.11 merge window. Is there something incorrect with the > > tagging > > that makes you think it should apply to 4.9? > > Commit 749494b6bdbb originally showed up in 4.11, but it was then > backported to 4.10.2 and 4.9.90. That is why I tried to apply it to > 4.9.y and when it did not work, sent out the rejection notice. Turns out there's a missing patch: commit 25cd9721c2b16ee0d775e36ec3af31f392003f80 Author: Krzysztof Opasiak Date: Tue Jan 31 18:12:31 2017 +0100 usb: gadget: f_hid: fix: Don't access hidg->req without spinlock held It changes one of the match lines from status = usb_ep_queue(hidg->in_ep, hidg->req, GFP_ATOMIC); to status = usb_ep_queue(hidg->in_ep, req, GFP_ATOMIC); which is why you get the rejection. James