From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chunfeng Yun Subject: Re: [PATCH v2 1/6] dt-bindings: connector: add optional properties for Type-B Date: Sun, 31 Mar 2019 20:45:36 +0800 Message-ID: <1554036336.10179.175.camel@mhfsdcap03> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-2-git-send-email-chunfeng.yun@mediatek.com> <5ca060de.1c69fb81.12138.c73c@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5ca060de.1c69fb81.12138.c73c@mx.google.com> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org Hi Rob, On Sun, 2019-03-31 at 01:40 -0500, Rob Herring wrote: > On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote: > > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > > usb-b-connector > > > > Signed-off-by: Chunfeng Yun > > --- > > v2 changes: > > 1. describe more clear for vbus-gpios and vbus-supply suggested by Hans > > --- > > .../devicetree/bindings/connector/usb-connector.txt | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > > index a9a2f2fc44f2..1c4ed6c9afa8 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > > @@ -17,6 +17,15 @@ Optional properties: > > - self-powered: Set this property if the usb device that has its own power > > source. > > > > +Optional properties for usb-b-connector: > > +- id-gpios: gpio for USB ID pin. > > +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V. > > + see gpio/gpio.txt. > > Please make it explicit that this is an input gpio. An output GPIO > controlling a Vbus regulator should be modelled as a regulator. Ok, thanks > > > +- vbus-supply: a phandle to the regulator for USB VBUS if needed. > > +- pinctrl-names : a pinctrl state named "default" is optional > > +- pinctrl-0 : pin control group > > + see pinctrl/pinctrl-bindings.txt > > + > > Optional properties for usb-c-connector: > > - power-role: should be one of "source", "sink" or "dual"(DRP) if typec > > connector has power support. > > -- > > 2.20.1 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/6] dt-bindings: connector: add optional properties for Type-B From: Chunfeng Yun Message-Id: <1554036336.10179.175.camel@mhfsdcap03> Date: Sun, 31 Mar 2019 20:45:36 +0800 To: Rob Herring Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: SGkgUm9iLApPbiBTdW4sIDIwMTktMDMtMzEgYXQgMDE6NDAgLTA1MDAsIFJvYiBIZXJyaW5nIHdy b3RlOgo+IE9uIEZyaSwgTWFyIDE1LCAyMDE5IGF0IDAzOjM4OjI4UE0gKzA4MDAsIENodW5mZW5n IFl1biB3cm90ZToKPiA+IEFkZCBpZC1ncGlvcywgdmJ1cy1ncGlvcywgdmJ1cy1zdXBwbHkgYW5k IHBpbmN0cmwgcHJvcGVydGllcyBmb3IKPiA+IHVzYi1iLWNvbm5lY3Rvcgo+ID4gCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBDaHVuZmVuZyBZdW4gPGNodW5mZW5nLnl1bkBtZWRpYXRlay5jb20+Cj4gPiAt LS0KPiA+IHYyIGNoYW5nZXM6Cj4gPiAgIDEuIGRlc2NyaWJlIG1vcmUgY2xlYXIgZm9yIHZidXMt Z3Bpb3MgYW5kIHZidXMtc3VwcGx5IHN1Z2dlc3RlZCBieSBIYW5zCj4gPiAtLS0KPiA+ICAuLi4v ZGV2aWNldHJlZS9iaW5kaW5ncy9jb25uZWN0b3IvdXNiLWNvbm5lY3Rvci50eHQgICAgICB8IDkg KysrKysrKysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nvbm5lY3Rvci91 c2ItY29ubmVjdG9yLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9jb25u ZWN0b3IvdXNiLWNvbm5lY3Rvci50eHQKPiA+IGluZGV4IGE5YTJmMmZjNDRmMi4uMWM0ZWQ2Yzlh ZmE4IDEwMDY0NAo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Nv bm5lY3Rvci91c2ItY29ubmVjdG9yLnR4dAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL2Nvbm5lY3Rvci91c2ItY29ubmVjdG9yLnR4dAo+ID4gQEAgLTE3LDYgKzE3 LDE1IEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPiAgLSBzZWxmLXBvd2VyZWQ6IFNldCB0aGlz IHByb3BlcnR5IGlmIHRoZSB1c2IgZGV2aWNlIHRoYXQgaGFzIGl0cyBvd24gcG93ZXIKPiA+ICAg IHNvdXJjZS4KPiA+ICAKPiA+ICtPcHRpb25hbCBwcm9wZXJ0aWVzIGZvciB1c2ItYi1jb25uZWN0 b3I6Cj4gPiArLSBpZC1ncGlvczogZ3BpbyBmb3IgVVNCIElEIHBpbi4KPiA+ICstIHZidXMtZ3Bp b3M6IGdwaW8gZm9yIFVTQiBWQlVTIHBpbiwgdXNlZCB0byBkZXRlY3QgcHJlc2VuY2Ugb2YgVkJV UyA1Vi4KPiA+ICsgIHNlZSBncGlvL2dwaW8udHh0Lgo+IAo+IFBsZWFzZSBtYWtlIGl0IGV4cGxp Y2l0IHRoYXQgdGhpcyBpcyBhbiBpbnB1dCBncGlvLiBBbiBvdXRwdXQgR1BJTyAKPiBjb250cm9s bGluZyBhIFZidXMgcmVndWxhdG9yIHNob3VsZCBiZSBtb2RlbGxlZCBhcyBhIHJlZ3VsYXRvci4K T2ssIHRoYW5rcwoKPiAKPiA+ICstIHZidXMtc3VwcGx5OiBhIHBoYW5kbGUgdG8gdGhlIHJlZ3Vs YXRvciBmb3IgVVNCIFZCVVMgaWYgbmVlZGVkLgo+ID4gKy0gcGluY3RybC1uYW1lcyA6IGEgcGlu Y3RybCBzdGF0ZSBuYW1lZCAiZGVmYXVsdCIgaXMgb3B0aW9uYWwKPiA+ICstIHBpbmN0cmwtMCA6 IHBpbiBjb250cm9sIGdyb3VwCj4gPiArICBzZWUgcGluY3RybC9waW5jdHJsLWJpbmRpbmdzLnR4 dAo+ID4gKwo+ID4gIE9wdGlvbmFsIHByb3BlcnRpZXMgZm9yIHVzYi1jLWNvbm5lY3RvcjoKPiA+ ICAtIHBvd2VyLXJvbGU6IHNob3VsZCBiZSBvbmUgb2YgInNvdXJjZSIsICJzaW5rIiBvciAiZHVh bCIoRFJQKSBpZiB0eXBlYwo+ID4gICAgY29ubmVjdG9yIGhhcyBwb3dlciBzdXBwb3J0Lgo+ID4g LS0gCj4gPiAyLjIwLjEKPiA+IAo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840F4C43381 for ; Sun, 31 Mar 2019 12:45:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 548872086C for ; Sun, 31 Mar 2019 12:45:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cpjBh6+c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 548872086C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=du64sH6/qjt2j3l3X2OsswliZA7KaXUO3B2dBrYkv+M=; b=cpjBh6+cunspTm 7YBm18+CjGXJmAUJZesFH4w3GH7YNkawGZvrPJ8jwTVUiqsd86wpmGErrr2sh6RgLiCbAH8ddke9R cmUk/Qgs46LnMOlHjskq9nXBupIWClNAQ/ik55jdjQFTt5LsjyAARPOQqv1X4O4ccroPvoyYjDG1+ HcuyEKhhlXUXSZ6aCsk0geKp1y3AaRUIdq/Yja0ktyxJL6+G4Pyr7sDDJTAaSbxl3WlD0EaYo/DvE AH1ma8zMlJdi5/1YkP+rnCuCpb8jbFjgMCsNSR6AOO7g1OhwmDQ9tDcTusG4Iz6VN50fr4RFA27L1 ZdqWH2T+wgqjSwXhfqdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAZqM-0003tu-NT; Sun, 31 Mar 2019 12:45:46 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAZqI-0003ss-BW; Sun, 31 Mar 2019 12:45:43 +0000 X-UUID: 50823ae85d9245dead0ac61790b42d41-20190331 X-UUID: 50823ae85d9245dead0ac61790b42d41-20190331 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1364919493; Sun, 31 Mar 2019 04:45:41 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 31 Mar 2019 05:45:39 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 31 Mar 2019 20:45:37 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 31 Mar 2019 20:45:36 +0800 Message-ID: <1554036336.10179.175.camel@mhfsdcap03> Subject: Re: [PATCH v2 1/6] dt-bindings: connector: add optional properties for Type-B From: Chunfeng Yun To: Rob Herring Date: Sun, 31 Mar 2019 20:45:36 +0800 In-Reply-To: <5ca060de.1c69fb81.12138.c73c@mx.google.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-2-git-send-email-chunfeng.yun@mediatek.com> <5ca060de.1c69fb81.12138.c73c@mx.google.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_054542_400042_4A7F6A78 X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Sun, 2019-03-31 at 01:40 -0500, Rob Herring wrote: > On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote: > > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > > usb-b-connector > > > > Signed-off-by: Chunfeng Yun > > --- > > v2 changes: > > 1. describe more clear for vbus-gpios and vbus-supply suggested by Hans > > --- > > .../devicetree/bindings/connector/usb-connector.txt | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > > index a9a2f2fc44f2..1c4ed6c9afa8 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > > @@ -17,6 +17,15 @@ Optional properties: > > - self-powered: Set this property if the usb device that has its own power > > source. > > > > +Optional properties for usb-b-connector: > > +- id-gpios: gpio for USB ID pin. > > +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V. > > + see gpio/gpio.txt. > > Please make it explicit that this is an input gpio. An output GPIO > controlling a Vbus regulator should be modelled as a regulator. Ok, thanks > > > +- vbus-supply: a phandle to the regulator for USB VBUS if needed. > > +- pinctrl-names : a pinctrl state named "default" is optional > > +- pinctrl-0 : pin control group > > + see pinctrl/pinctrl-bindings.txt > > + > > Optional properties for usb-c-connector: > > - power-role: should be one of "source", "sink" or "dual"(DRP) if typec > > connector has power support. > > -- > > 2.20.1 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0F7C43381 for ; Sun, 31 Mar 2019 12:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 612F82086C for ; Sun, 31 Mar 2019 12:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731189AbfCaMps (ORCPT ); Sun, 31 Mar 2019 08:45:48 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:1126 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726863AbfCaMpr (ORCPT ); Sun, 31 Mar 2019 08:45:47 -0400 X-UUID: 80e83be773de4c9292d0639c4707d64d-20190331 X-UUID: 80e83be773de4c9292d0639c4707d64d-20190331 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 2134828865; Sun, 31 Mar 2019 20:45:38 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 31 Mar 2019 20:45:37 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 31 Mar 2019 20:45:36 +0800 Message-ID: <1554036336.10179.175.camel@mhfsdcap03> Subject: Re: [PATCH v2 1/6] dt-bindings: connector: add optional properties for Type-B From: Chunfeng Yun To: Rob Herring CC: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Hans de Goede , Andy Shevchenko , Min Guo , , , , , Date: Sun, 31 Mar 2019 20:45:36 +0800 In-Reply-To: <5ca060de.1c69fb81.12138.c73c@mx.google.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-2-git-send-email-chunfeng.yun@mediatek.com> <5ca060de.1c69fb81.12138.c73c@mx.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On Sun, 2019-03-31 at 01:40 -0500, Rob Herring wrote: > On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote: > > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > > usb-b-connector > > > > Signed-off-by: Chunfeng Yun > > --- > > v2 changes: > > 1. describe more clear for vbus-gpios and vbus-supply suggested by Hans > > --- > > .../devicetree/bindings/connector/usb-connector.txt | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > > index a9a2f2fc44f2..1c4ed6c9afa8 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > > @@ -17,6 +17,15 @@ Optional properties: > > - self-powered: Set this property if the usb device that has its own power > > source. > > > > +Optional properties for usb-b-connector: > > +- id-gpios: gpio for USB ID pin. > > +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V. > > + see gpio/gpio.txt. > > Please make it explicit that this is an input gpio. An output GPIO > controlling a Vbus regulator should be modelled as a regulator. Ok, thanks > > > +- vbus-supply: a phandle to the regulator for USB VBUS if needed. > > +- pinctrl-names : a pinctrl state named "default" is optional > > +- pinctrl-0 : pin control group > > + see pinctrl/pinctrl-bindings.txt > > + > > Optional properties for usb-c-connector: > > - power-role: should be one of "source", "sink" or "dual"(DRP) if typec > > connector has power support. > > -- > > 2.20.1 > > >