From: eugeniy.paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: PAE40: don't panic and instead turn off hw ioc
Date: Mon, 1 Apr 2019 18:12:20 +0000 [thread overview]
Message-ID: <1554142339.2797.5.camel@synopsys.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA23075014643FA2D@US01WEMBX2.internal.synopsys.com>
On Mon, 2019-04-01@11:08 -0700, Vineet Gupta wrote:
> On 4/1/19 11:04 AM, Eugeniy Paltsev wrote:
> > > + if (IS_ENABLED(CONFIG_HIGHMEM) || is_pae40_enabled())
> >
> > As for today PAE40 couldn't be enabled without HIGHMEM for ARC, so probably we can
> > simplify this to
> >
> > ----------------------------->8----------------------------------
> > if (IS_ENABLED(CONFIG_HIGHMEM))
> > ioc_enable = 0;
>
> That is true, but mentioning both sort of documents the requirements.
> Also these checks are compile time only so don't add any extra code whatsoever.
OK, I'm fine with it. Let's check both conditions explicitly.
> -Vineet
>
--
Eugeniy Paltsev
prev parent reply other threads:[~2019-04-01 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 20:45 [PATCH] ARC: PAE40: don't panic and instead turn off hw ioc Vineet Gupta
2019-04-01 18:04 ` Eugeniy Paltsev
2019-04-01 18:08 ` Vineet Gupta
2019-04-01 18:12 ` Eugeniy Paltsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554142339.2797.5.camel@synopsys.com \
--to=eugeniy.paltsev@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.