From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com
Subject: Re: [PATCH] ethdev: fix a typo in eth device API doc
Date: Wed, 24 Aug 2016 18:06:26 +0200 [thread overview]
Message-ID: <1554992.ZnaOu0qKpl@xps13> (raw)
In-Reply-To: <1470030588-7825-1-git-send-email-nikhil.rao@intel.com>
2016-08-01 11:19, Nikhil Rao:
> This patch fixes a typo in the eth device API doc, device
> config. not stored between calls to rte_eth_dev_start/stop()
> should be restored before a call to rte_eth_dev_start()
> instead of after a call to rte_eth_dev_start().
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
[...]
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -118,7 +118,7 @@
> * - NIC queue statistics mappings
> *
> * Any other configuration will not be stored and will need to be re-entered
> - * after a call to rte_eth_dev_start().
> + * before a call to rte_eth_dev_start().
I have some doubts about this and above comment.
I think we should give move details in the comments of the functions,
instead of this (not often read) global comment.
next prev parent reply other threads:[~2016-08-24 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 5:49 [PATCH] ethdev: fix a typo in eth device API doc Nikhil Rao
2016-08-24 16:06 ` Thomas Monjalon [this message]
2017-06-30 14:47 ` Mcnamara, John
2017-07-02 17:49 ` Thomas Monjalon
2017-07-02 19:19 ` Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554992.ZnaOu0qKpl@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.