Re: [PATCH] arm64: dts: rockchip: set TX PBL for rk3328-roc-cc gmac

["Leonidas P. Papadakos" <papadakospan@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]



Στις Κυρ, 21 Απρ, 2019 at 7:00 ΜΜ, ο/η Peter Geis 
<pgwipeout@gmail.com> έγραψε:
> Thanks for sharing that thread, it's nice to finally have an answer 
> to why we have these issues.
> I've tested this on *my* Firefly rk3328-roc-cc, and while this patch 
> succeeds in preventing the tx lockup, iperf3 drops to a delightful 
> 15mbps.
> 
> It would seem we have significant differences between manufacturing 
> runs of the various boards.
> The auto adjustment feature that was discussed in that thread is 
> probably the only thing that will solve this for all boards.
> Until then I don't think we are going to get a solution that works 
> for all.

Indeed that feature would be optimal. Just to confirm, you have 
replaced force_thresh_dma_mode with this txpbl thing, right?
That is the only ethernet modification I have in the dts, done though 
u-boot. That is on linux 5.1

> fdt rm /ethernet@ff540000 snps,force_thresh_dma_mode
> fdt set /ethernet@ff540000 snps,txpbl <0x4>


[-- Attachment #2: Type: text/html, Size: 1559 bytes --]