All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Mario.Limonciello@dell.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] platform/x86: alienware-wmi: printing the wrong error code
Date: Wed, 24 Apr 2019 12:43:05 +0000	[thread overview]
Message-ID: <1556109784971.72307@Dell.com> (raw)
In-Reply-To: <20190424094417.GA15818@mwanda>

>Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>---
> drivers/platform/x86/alienware-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c
>index c0d1555735cd..83fd7677af24 100644
>--- a/drivers/platform/x86/alienware-wmi.c
>+++ b/drivers/platform/x86/alienware-wmi.c
>@@ -587,7 +587,7 @@ static ssize_t show_hdmi_source(struct device *dev,
>                        return scnprintf(buf, PAGE_SIZE,
>                                         "input [gpu] unknown\n");
>        }
>-       pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
>+       pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
>        return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
> }
>
>--
>2.18.0

Yes, thanks.
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>

  reply	other threads:[~2019-04-24 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  9:44 [PATCH] platform/x86: alienware-wmi: printing the wrong error code Dan Carpenter
2019-04-24 12:43 ` Mario.Limonciello [this message]
2019-05-06 12:23 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556109784971.72307@Dell.com \
    --to=mario.limonciello@dell.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.