All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maya Erez <merez@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Maya Erez <merez@codeaurora.org>,
	linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: [PATCH 9/9] wil6210: remove HALP for Talyn devices
Date: Fri, 26 Apr 2019 18:43:37 +0300	[thread overview]
Message-ID: <1556293417-27097-10-git-send-email-merez@codeaurora.org> (raw)
In-Reply-To: <1556293417-27097-1-git-send-email-merez@codeaurora.org>

In Talyn the HW is responsible for power management enter / exit
flow, hence the deep sleep exit latency is significantly shorter than
in Sparrow.
In such a case HALP feature, that is meant to prevent long PCIe blocking
accesses, is no longer needed and can be removed for Talyn.

Signed-off-by: Maya Erez <merez@codeaurora.org>
---
 drivers/net/wireless/ath/wil6210/main.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/wireless/ath/wil6210/main.c b/drivers/net/wireless/ath/wil6210/main.c
index efdb6e1..3c30076 100644
--- a/drivers/net/wireless/ath/wil6210/main.c
+++ b/drivers/net/wireless/ath/wil6210/main.c
@@ -1940,6 +1940,9 @@ void wil_halp_vote(struct wil6210_priv *wil)
 	unsigned long rc;
 	unsigned long to_jiffies = msecs_to_jiffies(WAIT_FOR_HALP_VOTE_MS);
 
+	if (wil->hw_version >= HW_VER_TALYN_MB)
+		return;
+
 	mutex_lock(&wil->halp.lock);
 
 	wil_dbg_irq(wil, "halp_vote: start, HALP ref_cnt (%d)\n",
@@ -1971,6 +1974,9 @@ void wil_halp_vote(struct wil6210_priv *wil)
 
 void wil_halp_unvote(struct wil6210_priv *wil)
 {
+	if (wil->hw_version >= HW_VER_TALYN_MB)
+		return;
+
 	WARN_ON(wil->halp.ref_cnt == 0);
 
 	mutex_lock(&wil->halp.lock);
-- 
1.9.1


      parent reply	other threads:[~2019-04-26 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 15:43 [PATCH 0/9] wil6210 patches Maya Erez
2019-04-26 15:43 ` [PATCH 1/9] wil6210: fix spurious interrupts in 3-msi Maya Erez
2019-05-03  5:05   ` Kalle Valo
2019-04-26 15:43 ` [PATCH 2/9] wil6210: fix _desc access in __wil_tx_vring_tso Maya Erez
2019-04-26 15:43 ` [PATCH 3/9] wil6210: add printout of platform capabilities Maya Erez
2019-04-26 15:43 ` [PATCH 4/9] wil6210: add support for multiple sections in brd file Maya Erez
2019-04-26 15:43 ` [PATCH 5/9] wil6210: enhancements for descriptor and status ring debugfs Maya Erez
2019-04-26 15:43 ` [PATCH 6/9] wil6210: fix overwriting max_assoc_sta module param Maya Erez
2019-04-26 15:43 ` [PATCH 7/9] wil6210: fix missed MISC mbox interrupt Maya Erez
2019-04-26 15:43 ` [PATCH 8/9] wil6210: check rx_buff_mgmt before accessing it Maya Erez
2019-04-26 15:43 ` Maya Erez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556293417-27097-10-git-send-email-merez@codeaurora.org \
    --to=merez@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wil6210@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.