From: Jean Delvare <jdelvare@suse.de>
To: Pu Wen <puwen@hygon.cn>
Cc: bp@alien8.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [RFC PATCH RESEND] i2c-piix4: Add Hygon Dhyana SMBus support
Date: Fri, 26 Apr 2019 18:48:05 +0200 [thread overview]
Message-ID: <1556297285.22365.4.camel@suse.de> (raw)
In-Reply-To: <0c895129-23af-2fc6-0c99-61348a69f961@hygon.cn>
On Fri, 2019-04-26 at 22:23 +0800, Pu Wen wrote:
> On 2019/4/26 17:38, Jean Delvare wrote:
> > I would like you to also document the new supported chipset in
> > drivers/i2c/busses/Kconfig and Documentation/i2c/busses/i2c-piix4 as
> > well as in the header comment of i2c-piix4.c itself. I know it seems
> > redundant but it helps the user know which driver they need.
>
> Because Hygon uses the same PCI device ID of AMD's, so is it appropriate
> to document with the name "Hygon CZ" or just "Hygon"?
"Hygon CZ" please, as Hygon is the vendor not the device, and I can
imagine you may create more devices in the future.
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-04-26 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 13:10 [RFC PATCH RESEND] i2c-piix4: Add Hygon Dhyana SMBus support Pu Wen
2019-04-22 13:10 ` Pu Wen
2019-04-26 9:37 ` Jean Delvare
2019-04-26 9:37 ` Jean Delvare
2019-04-26 14:23 ` Pu Wen
2019-04-26 16:48 ` Jean Delvare [this message]
2019-04-27 2:37 ` Pu Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556297285.22365.4.camel@suse.de \
--to=jdelvare@suse.de \
--cc=bp@alien8.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puwen@hygon.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.