From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] mk: fix kernel modules build dependency
Date: Thu, 29 Mar 2018 18:32:32 +0200
Message-ID: <1556410.U3gqVypkhP@xps>
References: <20180329153931.26351-1-thomas@monjalon.net>
 <0b1a7c34-1dd0-b47b-5ee7-7ea3f1ec4308@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: hemant.agrawal@nxp.com, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 7ABD32A66
 for <dev@dpdk.org>; Thu, 29 Mar 2018 18:32:55 +0200 (CEST)
In-Reply-To: <0b1a7c34-1dd0-b47b-5ee7-7ea3f1ec4308@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/03/2018 17:48, Ferruh Yigit:
> On 3/29/2018 4:39 PM, Thomas Monjalon wrote:
> > Some kernel modules may need some header files to be "installed"
> > in the build directory.
> > 
> > When running multiple threads of make, kernel modules can try to
> > be compiled before the lib headers are ready:
> > 	make -j3
> > 	kernel/linux/kni/kni_misc.c:19:37: fatal error:
> > 		exec-env/rte_kni_common.h: No such file or directory
> 
> Is there a reason to keep header in eal when module itself moved into kernel?

It seems you missed my comment below:

On a related note, this header file
        lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
could be moved to lib/librte_kni/
Opinion?