diff for duplicates of <155646478.xj0lyDQ1cd@avalon> diff --git a/a/1.txt b/N1/1.txt index 8469717..bde28bd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -44,8 +44,8 @@ This looks good to me. > }; > > /* Special CPG clocks */ -> - cpg_clocks: cpg_clocks@0xe6150000 { -> + cpg_clocks: cpg_clocks@0xffc80000 { +> - cpg_clocks: cpg_clocks at 0xe6150000 { +> + cpg_clocks: cpg_clocks at 0xffc80000 { No need for a 0x prefix. @@ -63,12 +63,12 @@ This looks good. > > /* Gate clocks */ > - mstp0_clks: mstp0_clks { -> + mstp0_clks: mstp0_clks@ffc80030 { +> + mstp0_clks: mstp0_clks at ffc80030 { The @address is only mandatory to differentiate between nodes with identical names. As the node name is supposed to describe the device function, maybe we -could rename it to clocks@ffc80030 ? As you modify the CPG node address above -it might make sense to rename it to clocks@ffc80000 too. +could rename it to clocks at ffc80030 ? As you modify the CPG node address above +it might make sense to rename it to clocks at ffc80000 too. I'm not advocating for a rename now, but as your patch touches the names, I think they should be fixed properly (or not at all). @@ -85,7 +85,7 @@ think they should be fixed properly (or not at all). > "i2c0"; > }; > - mstp1_clks: mstp1_clks { -> + mstp1_clks: mstp1_clks@ffc80034 { +> + mstp1_clks: mstp1_clks at ffc80034 { > compatible = "renesas,r8a7779-mstp-clocks", > "renesas,cpg-mstp-clocks"; > - reg = <0 0xffc80034 0 4>, <0 0xffc80044 0 4>; @@ -98,7 +98,7 @@ think they should be fixed properly (or not at all). > "pcie", "vin3"; > }; > - mstp3_clks: mstp3_clks { -> + mstp3_clks: mstp3_clks@ffc8003c { +> + mstp3_clks: mstp3_clks at ffc8003c { > compatible = "renesas,r8a7779-mstp-clocks", > "renesas,cpg-mstp-clocks"; > - reg = <0 0xffc8003c 0 4>; diff --git a/a/content_digest b/N1/content_digest index 2ea4e71..310d6f4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01400761997-13512-1-git-send-email-geert+renesas@glider.be\0" "ref\01400761997-13512-2-git-send-email-geert+renesas@glider.be\0" - "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" - "Subject\0Re: [PATCH 1/2] ARM: shmobile: r8a7779 dtsi: Correct #address-cells/#size-cells for clocks\0" - "Date\0Thu, 22 May 2014 23:08:04 +0000\0" + "From\0laurent.pinchart@ideasonboard.com (Laurent Pinchart)\0" + "Subject\0[PATCH 1/2] ARM: shmobile: r8a7779 dtsi: Correct #address-cells/#size-cells for clocks\0" + "Date\0Fri, 23 May 2014 01:08:04 +0200\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -52,8 +52,8 @@ "> \t\t};\n" "> \n" "> \t\t/* Special CPG clocks */\n" - "> -\t\tcpg_clocks: cpg_clocks@0xe6150000 {\n" - "> +\t\tcpg_clocks: cpg_clocks@0xffc80000 {\n" + "> -\t\tcpg_clocks: cpg_clocks at 0xe6150000 {\n" + "> +\t\tcpg_clocks: cpg_clocks at 0xffc80000 {\n" "\n" "No need for a 0x prefix.\n" "\n" @@ -71,12 +71,12 @@ "> \n" "> \t\t/* Gate clocks */\n" "> -\t\tmstp0_clks: mstp0_clks {\n" - "> +\t\tmstp0_clks: mstp0_clks@ffc80030 {\n" + "> +\t\tmstp0_clks: mstp0_clks at ffc80030 {\n" "\n" "The @address is only mandatory to differentiate between nodes with identical \n" "names. As the node name is supposed to describe the device function, maybe we \n" - "could rename it to clocks@ffc80030 ? As you modify the CPG node address above \n" - "it might make sense to rename it to clocks@ffc80000 too.\n" + "could rename it to clocks at ffc80030 ? As you modify the CPG node address above \n" + "it might make sense to rename it to clocks at ffc80000 too.\n" "\n" "I'm not advocating for a rename now, but as your patch touches the names, I \n" "think they should be fixed properly (or not at all).\n" @@ -93,7 +93,7 @@ "> \t\t\t\t\"i2c0\";\n" "> \t\t};\n" "> -\t\tmstp1_clks: mstp1_clks {\n" - "> +\t\tmstp1_clks: mstp1_clks@ffc80034 {\n" + "> +\t\tmstp1_clks: mstp1_clks at ffc80034 {\n" "> \t\t\tcompatible = \"renesas,r8a7779-mstp-clocks\",\n" "> \t\t\t \"renesas,cpg-mstp-clocks\";\n" "> -\t\t\treg = <0 0xffc80034 0 4>, <0 0xffc80044 0 4>;\n" @@ -106,7 +106,7 @@ "> \t\t\t\t\"pcie\", \"vin3\";\n" "> \t\t};\n" "> -\t\tmstp3_clks: mstp3_clks {\n" - "> +\t\tmstp3_clks: mstp3_clks@ffc8003c {\n" + "> +\t\tmstp3_clks: mstp3_clks at ffc8003c {\n" "> \t\t\tcompatible = \"renesas,r8a7779-mstp-clocks\",\n" "> \t\t\t \"renesas,cpg-mstp-clocks\";\n" "> -\t\t\treg = <0 0xffc8003c 0 4>;\n" @@ -120,4 +120,4 @@ "\n" Laurent Pinchart -90001cb386edc6ee82b6b087b4c7b9230e72d3ba160c7c885f72c476bf9aaf71 +134ae1e8d592fbbe994a00aadbe26159aeb3ceb7f92d6078450f5b746ced0e3e
diff --git a/a/content_digest b/N2/content_digest index 2ea4e71..3ab51aa 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,8 +2,13 @@ "ref\01400761997-13512-2-git-send-email-geert+renesas@glider.be\0" "From\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Subject\0Re: [PATCH 1/2] ARM: shmobile: r8a7779 dtsi: Correct #address-cells/#size-cells for clocks\0" - "Date\0Thu, 22 May 2014 23:08:04 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Fri, 23 May 2014 01:08:04 +0200\0" + "To\0Geert Uytterhoeven <geert+renesas@glider.be>\0" + "Cc\0devicetree@vger.kernel.org" + Simon Horman <horms@verge.net.au> + Magnus Damm <magnus.damm@gmail.com> + linux-arm-kernel@lists.infradead.org + " linux-sh@vger.kernel.org\0" "\00:1\0" "b\0" "Hi Geert,\n" @@ -120,4 +125,4 @@ "\n" Laurent Pinchart -90001cb386edc6ee82b6b087b4c7b9230e72d3ba160c7c885f72c476bf9aaf71 +02d5f193de8baebce26aaf44930428a443457674b6d00d6fb83f6b489192ed48
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.