Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses

From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
Cc: alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	airlied-cv59FeDIM0c@public.gmane.org,
	nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	stefan-XLVq0VzYD2Y@public.gmane.org,
	virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	marex-ynQEQJNshbs@public.gmane.org,
	David1.Zhou-5C7GfCeVMHo@public.gmane.org,
	maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	z.liuxinliang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	tomi.valkeinen-l0cyMroinI0@public.gmane.org,
	bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
	etnaviv-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	brodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
	zourongrong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [Intel-gfx] [PATCH] drm/core: Remove drm_dev_unref() and it's uses
Date: Thu, 26 Apr 2018 15:45:44 +0300	[thread overview]
Message-ID: <1556510.Xu6NnhyFGZ@avalon> (raw)
In-Reply-To: <20180426123615.GA12521-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>

Hi Daniel,

On Thursday, 26 April 2018 15:36:15 EEST Daniel Vetter wrote:
> On Thu, Apr 26, 2018 at 03:58:19PM +0530, Vaishali Thakkar wrote:
> > It's been a while since we introduced drm_dev{get/put} functions
> > to replace reference/unreference in drm subsystem for the
> > consistency purpose. So, with this patch, let's just replace
> > all current use cases of drm_dev_unref() with drm_dev_put and remove
> > the function itself.
> > 
> > Coccinelle was used for mass-patching.
> > 
> > Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> 
> Thanks for doing this. Unfortunately drm moves pretty fast, so already a
> conflict when I tried to apply this. Some drivers are also in their own
> trees, so this might lead to more fun :-/
> 
> Can you pls split it up per-driver (just the directories under
> drivers/gpu/drm/ is enough)? Final patch to remove the function might then
> get stalled a bit ofc.

I requested a single patch instead of splitting it per driver, you might want 
to blame me for that.

> Also can you pls update ./scripts/coccinelle/api/drm-get-put.cocci and
> remove that spatch hunk in the final patch, since we no longer need it?

How about just rerunning the coccinelle patch when it's time to apply this ? 
There's precedent for performing such automated changes, and it would ensure 
that no driver is left out.

> > ---
> > 
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c            |  4 ++--
> >  drivers/gpu/drm/arc/arcpgu_drv.c                   |  4 ++--
> >  drivers/gpu/drm/armada/armada_drv.c                |  6 +++---
> >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c       |  4 ++--
> >  drivers/gpu/drm/drm_drv.c                          | 13 -------------
> >  drivers/gpu/drm/etnaviv/etnaviv_drv.c              |  4 ++--
> >  drivers/gpu/drm/exynos/exynos_drm_drv.c            |  4 ++--
> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c          |  4 ++--
> >  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c    |  4 ++--
> >  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c    |  8 ++++----
> >  drivers/gpu/drm/i915/selftests/huge_pages.c        |  2 +-
> >  drivers/gpu/drm/i915/selftests/i915_gem_dmabuf.c   |  2 +-
> >  drivers/gpu/drm/i915/selftests/i915_gem_evict.c    |  2 +-
> >  drivers/gpu/drm/i915/selftests/i915_gem_gtt.c      |  2 +-
> >  drivers/gpu/drm/i915/selftests/i915_gem_object.c   |  2 +-
> >  drivers/gpu/drm/i915/selftests/i915_request.c      |  2 +-
> >  drivers/gpu/drm/i915/selftests/i915_vma.c          |  2 +-
> >  drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c |  2 +-
> >  drivers/gpu/drm/imx/imx-drm-core.c                 |  4 ++--
> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c             |  6 +++---
> >  drivers/gpu/drm/msm/msm_drv.c                      |  8 ++++----
> >  drivers/gpu/drm/mxsfb/mxsfb_drv.c                  |  4 ++--
> >  drivers/gpu/drm/nouveau/nouveau_platform.c         |  2 +-
> >  drivers/gpu/drm/omapdrm/omap_drv.c                 |  4 ++--
> >  drivers/gpu/drm/pl111/pl111_drv.c                  |  4 ++--
> >  drivers/gpu/drm/qxl/qxl_drv.c                      |  2 +-
> >  drivers/gpu/drm/rcar-du/rcar_du_drv.c              |  2 +-
> >  drivers/gpu/drm/rockchip/rockchip_drm_drv.c        |  4 ++--
> >  drivers/gpu/drm/shmobile/shmob_drm_drv.c           |  4 ++--
> >  drivers/gpu/drm/sti/sti_drv.c                      |  8 ++++----
> >  drivers/gpu/drm/stm/drv.c                          |  4 ++--
> >  drivers/gpu/drm/sun4i/sun4i_drv.c                  |  4 ++--
> >  drivers/gpu/drm/tegra/drm.c                        |  4 ++--
> >  drivers/gpu/drm/tinydrm/core/tinydrm-core.c        |  6 +++---
> >  drivers/gpu/drm/tve200/tve200_drv.c                |  4 ++--
> >  drivers/gpu/drm/udl/udl_drv.c                      |  2 +-
> >  drivers/gpu/drm/vc4/vc4_drv.c                      |  4 ++--
> >  drivers/gpu/drm/vgem/vgem_drv.c                    |  2 +-
> >  drivers/gpu/drm/virtio/virtgpu_drm_bus.c           |  2 +-
> >  drivers/gpu/drm/zte/zx_drm_drv.c                   |  4 ++--
> >  include/drm/drm_drv.h                              |  1 -
> >  41 files changed, 73 insertions(+), 87 deletions(-)

-- 
Regards,

Laurent Pinchart

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx