From: Bart Van Assche <bvanassche@acm.org>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [RFC PATCH 01/18] blktrace: increase the size of action mask
Date: Thu, 02 May 2019 08:12:20 -0700 [thread overview]
Message-ID: <1556809940.12970.8.camel@acm.org> (raw)
In-Reply-To: <SN6PR04MB4527BDC294F24B4954AD201786340@SN6PR04MB4527.namprd04.prod.outlook.com>
On Thu, 2019-05-02 at 03:43 +0000, Chaitanya Kulkarni wrote:
> On 5/1/19 8:48 AM, Bart Van Assche wrote:
> > On Tue, 2019-04-30 at 21:28 -0700, Chaitanya Kulkarni wrote:
> > > -#define BLKTRACESETUP32 _IOWR(0x12, 115, struct compat_blk_user_trace_setup)
> > > +
> > > +/* XXX: temp work around for RFC */
> > > +#define BLKTRACESETUP32 _IOWR(0x13, 115, struct compat_blk_user_trace_setup)
> >
> > This change breaks user space so this change is not acceptable. I think you
> > want to introduce a new ioctl instead of modifying an existing ioctl.
> > Additionally, have you considered to split the blktrace_api.h header file
> > into two header files: one with kernel-internal definitions and a second one
> > with definitions that are shared with user space (include/uapi/...)?
>
> I want to avoid modifying an existing IOCTL, I'll add a new ioctl and
> update the tools to use the extension IOCTL and split the header file
> also. Also I found that user space tools have replicated BLK_XX_XXX
> definitions, will be okay to keep all those in one place and include
> those from the appropriate header file ?
Hi Chaitanya,
I think all definitions that are relevant for the user space blktrace tool
should be moved into a header file under include/uapi/linux. I'm not sure
what the best strategy is to include that header file in the blktrace tool.
Another project that interfaces with the kernel (rdma-core; see also
https://github.com/linux-rdma/rdma-core/) periodically copies kernel header
files into its own source code repository.
Bart.
next prev parent reply other threads:[~2019-05-02 15:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 4:28 [RFC PATCH 00/18] blktrace: add blktrace extension support Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 01/18] blktrace: increase the size of action mask Chaitanya Kulkarni
2019-05-01 15:48 ` Bart Van Assche
2019-05-02 3:43 ` Chaitanya Kulkarni
2019-05-02 15:12 ` Bart Van Assche [this message]
2019-05-01 4:28 ` [RFC PATCH 02/18] blktrace: add more definitions for BLK_TC_ACT Chaitanya Kulkarni
2019-05-01 12:31 ` Christoph Hellwig
2019-05-01 12:56 ` Jeff Moyer
2019-05-02 3:48 ` Chaitanya Kulkarni
2019-05-02 3:49 ` Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 03/18] blktrace: update trace to track more actions Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 04/18] kernel/trace: add KConfig to enable blktrace_ext Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 05/18] blktrace: add iopriority mask Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 06/18] " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 07/18] blktrace: allow user to track iopriority Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 08/18] blktrace: add sysfs ioprio mask Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 09/18] blktrace: add debug support for extension Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 10/18] block: set ioprio for write-zeroes, discard etc Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 11/18] block: set ioprio for zone-reset Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 12/18] block: set ioprio for flush bio Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 13/18] drivers: set bio iopriority field Chaitanya Kulkarni
2019-05-01 6:23 ` Javier González
2019-05-01 4:28 ` [RFC PATCH 14/18] fs: " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 15/18] power/swap: " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 16/18] mm: " Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 17/18] null_blk: add write-zeroes flag to nullb_device Chaitanya Kulkarni
2019-05-01 4:28 ` [RFC PATCH 18/18] null_blk: add module param discard/write-zeroes Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556809940.12970.8.camel@acm.org \
--to=bvanassche@acm.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.