From: Mimi Zohar <zohar@linux.ibm.com>
To: Prakhar Srivastava <prsriva02@gmail.com>,
linux-integrity@vger.kernel.org,
linux-secuirty-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ebiederm@xmission.com, vgoyal@redhat.com, nayna@linux.ibm.com
Subject: Re: [PATCH v3 2/4] add the buffer to the xattr
Date: Thu, 02 May 2019 12:52:13 -0400 [thread overview]
Message-ID: <1556815933.4134.77.camel@linux.ibm.com> (raw)
In-Reply-To: <20190429214743.4625-3-prsriva02@gmail.com>
On Mon, 2019-04-29 at 14:47 -0700, Prakhar Srivastava wrote:
> From: Prakhar Srivastava <prsriva02@gmail.com>
>
> add the buffer to the xattr for a buffer case
Please write full patch descriptions, here and in the other patches,
explaining the current status with the motivation for the change.
>
> Signed-off-by: Prakhar Srivastava <prsriva02@gmail.com>
> ---
< snip >
>
> @@ -630,17 +651,23 @@ static int process_buffer_measurement(const void *buff, int size,
> if (ret < 0)
> goto err_out;
>
> - ret = ima_store_template(entry, violation, NULL,
> + if (action & IMA_MEASURE)
> + ret = ima_store_template(entry, violation, NULL,
> buff, pcr);
Although scripts/Lindent has its problems, it does a good job with
code formatting. There's no reason here for the line breakage.
Mimi
next prev parent reply other threads:[~2019-05-02 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 21:47 [PATCH v3 0/4] Add a new ima_hook buffer_check to measure buffers critical for attestation Prakhar Srivastava
2019-04-29 21:47 ` [PATCH v3 1/4] added a new ima policy func buffer_check, and ima hook to measure the buffer hash into ima Prakhar Srivastava
2019-05-02 16:52 ` Mimi Zohar
2019-04-29 21:47 ` [PATCH v3 2/4] add the buffer to the xattr Prakhar Srivastava
2019-05-02 16:52 ` Mimi Zohar [this message]
2019-04-29 21:47 ` [PATCH v3 3/4] add kexec_cmdline used to ima Prakhar Srivastava
2019-05-02 16:52 ` Mimi Zohar
2019-05-02 16:58 ` Al Viro
2019-04-29 21:47 ` [PATCH v3 4/4] added LSM hook to call ima_buffer_check Prakhar Srivastava
2019-05-02 16:52 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556815933.4134.77.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=ebiederm@xmission.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-secuirty-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=prsriva02@gmail.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.