From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Chen Subject: Re: [RFC PATCH V1 3/6] dt-bindings: mt8183: Added DIP dt-bindings Date: Tue, 7 May 2019 22:16:19 +0800 Message-ID: <1557238579.11663.15.camel@mtksdccf07> References: <20190417104511.21514-1-frederic.chen@mediatek.com> <20190417104511.21514-4-frederic.chen@mediatek.com> <20190430011619.GA22170@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190430011619.GA22170@bogus> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: shik@chromium.org, devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, suleiman@chromium.org, Jerry-ch.Chen@mediatek.com, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org RGVhciBSb2IsCgpJIGFwcHJlY2lhdGUgeW91ciBjb21tZW50cy4KCk9uIE1vbiwgMjAxOS0wNC0y OSBhdCAyMDoxNiAtMDUwMCwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gT24gV2VkLCBBcHIgMTcsIDIw MTkgYXQgMDY6NDU6MDhQTSArMDgwMCwgRnJlZGVyaWMgQ2hlbiB3cm90ZToKPiA+IFRoaXMgcGF0 Y2ggYWRkcyBEVCBiaW5kaW5nIGRvY3VtZW50YXRpb24gZm9yIHRoZSBEaWdpdGFsIEltYWdlCj4g PiBQcm9jZXNzaW5nIChESVApIHVuaXQgb2YgY2FtZXJhIElTUCBzeXN0ZW0gb24gTWVkaWF0ZWsn cyBTb0NzLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBGcmVkZXJpYyBDaGVuIDxmcmVkZXJpYy5j aGVuQG1lZGlhdGVrLmNvbT4KPiA+IC0tLQo+ID4gIC4uLi9iaW5kaW5ncy9tZWRpYS9tZWRpYXRl ayxtdDgxODMtZGlwLnR4dCAgICB8IDM1ICsrKysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVkaWEvbWVkaWF0ZWssbXQ4MTgzLWRpcC50eHQK PiA+IAo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9t ZWRpYS9tZWRpYXRlayxtdDgxODMtZGlwLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9tZWRpYS9tZWRpYXRlayxtdDgxODMtZGlwLnR4dAo+ID4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPiA+IGluZGV4IDAwMDAwMDAwMDAwMC4uMGUxOTk0YmY4MmYwCj4gPiAtLS0gL2Rldi9u dWxsCj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVkaWEvbWVk aWF0ZWssbXQ4MTgzLWRpcC50eHQKPiA+IEBAIC0wLDAgKzEsMzUgQEAKPiA+ICsqIE1lZGlhdGVr IERpZ2l0YWwgSW1hZ2UgUHJvY2Vzc29yIChESVApCj4gPiArCj4gPiArRGlnaXRhbCBJbWFnZSBQ cm9jZXNzb3IgKERJUCkgdW5pdCBpbiBNZWRpYXRlayBJU1Agc3lzdGVtIGlzIHJlc3BvbnNpYmxl IGZvcgo+ID4gK2ltYWdlIGNvbnRlbnQgYWRqdXN0bWVudCBhY2NvcmRpbmcgdG8gdGhlIHR1bmlu ZyBwYXJhbWV0ZXJzLiBESVAgY2FuIHByb2Nlc3MKPiA+ICt0aGUgaW1hZ2UgZm9ybSBtZW1vcnkg YnVmZmVyIGFuZCBvdXRwdXQgdGhlIHByb2Nlc3NlZCBpbWFnZSB0byBtdWx0aXBsZSBvdXRwdXQK PiA+ICtidWZmZXJzLiBGdXJ0aGVybW9yZSwgaXQgY2FuIHN1cHBvcnQgZGVtb3NhaWNpbmcgYW5k IG5vaXNlIHJlZHVjdGlvbiBvbiB0aGUKPiA+ICtpbWFnZXMuCj4gPiArCj4gPiArUmVxdWlyZWQg cHJvcGVydGllczoKPiA+ICstIGNvbXBhdGlibGU6ICJtZWRpYXRlayxtdDgxODMtZGlwIgo+ID4g Ky0gcmVnOiBQaHlzaWNhbCBiYXNlIGFkZHJlc3MgYW5kIGxlbmd0aCBvZiB0aGUgZnVuY3Rpb24g YmxvY2sgcmVnaXN0ZXIgc3BhY2UKPiA+ICstIGludGVycnVwdHM6IGludGVycnVwdCBudW1iZXIg dG8gdGhlIGNwdQo+ID4gKy0gaW9tbXVzOiBzaG91bGQgcG9pbnQgdG8gdGhlIHJlc3BlY3RpdmUg SU9NTVUgYmxvY2sgd2l0aCBtYXN0ZXIgcG9ydCBhcwo+ID4gKyAgYXJndW1lbnQsIHNlZSBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaW9tbXUvbWVkaWF0ZWssaW9tbXUudHh0Cj4g PiArICBmb3IgZGV0YWlscy4KPiA+ICstIG1lZGlhdGVrLGxhcmI6IG11c3QgY29udGFpbiB0aGUg bG9jYWwgYXJiaXRlcnMgaW4gdGhlIGN1cnJlbnQgU29jcywgc2VlCj4gPiArICBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVtb3J5LWNvbnRyb2xsZXJzL21lZGlhdGVrLHNtaS1s YXJiLnR4dAo+ID4gKyAgZm9yIGRldGFpbHMuCj4gPiArLSBjbG9ja3M6IG11c3QgY29udGFpbiB0 aGUgbG9jYWwgYXJiaXRlcnMgNSAoTEFSQjUpIGFuZCBESVAgY2xvY2sKPiA+ICstIGNsb2NrLW5h bWVzOiBtdXN0IGNvbnRhaW4gRElQX0NHX0lNR19MQVJCNSBhbmQgRElQX0NHX0lNR19ESVAKPiA+ ICsKPiA+ICtFeGFtcGxlOgo+ID4gKwlkaXA6IGRpcEAxNTAyMjAwMCB7Cj4gPiArCQljb21wYXRp YmxlID0gIm1lZGlhdGVrLG10ODE4My1kaXAiOwo+ID4gKwkJbWVkaWF0ZWssbGFyYiA9IDwmbGFy YjU+Owo+IAo+ID4gKwkJbWVkaWF0ZWssbWRwMyA9IDwmbWRwX3JkbWEwPjsKPiA+ICsJCW1lZGlh dGVrLHZwdSA9IDwmdnB1PjsKPiAKPiBOb3QgZG9jdW1lbnRlZC4KPiAKCuKAnG1lZGlhdGVrLHZw deKAnSB3aWxsIGJlIHJlcGxhY2VkIGJ5IOKAnG1lZGlhdGVrLHNjcC7igJ0gSSB3b3VsZCBsaWtl IHRvIAphZGQgdGhlIGZvbGxvd2luZyBkZXNjcmlwdGlvbiBpbiBuZXh0IHZlcnNpb24gb2YgdGhl IHBhdGNoOgoKLSBtZWRpYXRlayxzY3A6IG11c3QgcG9pbnQgdG8gdGhlIHNjcCBibG9jayBvZiB0 aGUgY28tcHJvY2Vzc29yIHVzZWQKICB3aXRoIERJUC4gUGxlYXNlIHNlZQogIERvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9yZW1vdGVwcm9jL210ayxzY3AudHh0IGZvciB0aGUKICBk ZXRhaWwuCgotIG1lZGlhdGVrLG1kcDM6IG11c3QgcG9pbnQgdG8gdGhlIE1lZGlhIERhdGEgUGF0 aCAzIChNRFAzKSBibG9jay4KICBQbGVhc2Ugc2VlCiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL21lZGlhL21lZGlhdGVrLG10ODE4My1tZHAzLnR4dAogIGZvciB0aGUgZGV0YWls LgoKRXhhbXBsZToKCgltZHBfcmRtYTA6IG1kcF9yZG1hMEAxNDAwMTAwMCB7CgkJY29tcGF0aWJs ZSA9ICJtZWRpYXRlayxtdDgxODMtbWRwLXJkbWEiLAoJCQkgICAgICJtZWRpYXRlayxtdDgxODMt bWRwMyI7CgkJbWVkaWF0ZWssdnB1ID0gPCZ2cHU+OwoJCW1lZGlhdGVrLHNjcCA9IDwmc2NwPjsK CQltZWRpYXRlayxtZHAtaWQgPSA8MD47CgkJLyogLi4uLi4uICovCgkJfTsKCglzY3A6IHNjcEAx MDUwMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDgxODMtc2NwIjsKCQlyZWcgPSA8 MCAweDEwNTAwMDAwIDAgMHg4MDAwMD4sCgkJICAgICAgPDAgMHgxMDVjMDAwMCAwIDB4NTAwMD47 CgkJcmVnLW5hbWVzID0gInNyYW0iLCAiY2ZnIjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTc0 IElSUV9UWVBFX0xFVkVMX0hJR0g+OwoJCWNsb2NrcyA9IDwmaW5mcmFjZmcgQ0xLX0lORlJBX1ND UFNZUz47CgkJY2xvY2stbmFtZXMgPSAibWFpbiI7CgkJbWVtb3J5LXJlZ2lvbiA9IDwmc2NwX21l bV9yZXNlcnZlZD47CgkJc3RhdHVzID0gIm9rYXkiOwoJfTsKCglkaXA6IGRpcEAxNTAyMjAwMCB7 CgkJY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDgxODMtZGlwIjsKCQltZWRpYXRlayxsYXJiID0g PCZsYXJiNT47CgkJbWVkaWF0ZWssbWRwMyA9IDwmbWRwX3JkbWEwPjsKCQltZWRpYXRlayxzY3Ag PSA8JnNjcD47CgkJLyogLi4uLi4uICovCgl9OwoKClRoZSBkZXBlbmRlbnQgTWVkaWF0ZWsgU0NQ IGFuZCBNRFAzIHBhdGNoIGhhdmUgYmVlbiBzZW50OgpbMV0gTWVkaWF0ZWsgU0NQLCBodHRwczov L3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzEwODk3MzE5LwpbMl0gTWVpZGF0ZWsgTURQMywg aHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDg0NDIyOS8KCj4gPiArCQlpb21t dXMgPSA8JmlvbW11IE00VV9QT1JUX0NBTV9JTUdJPjsKPiA+ICsJCXJlZyA9IDwwIDB4MTUwMjIw MDAgMCAweDYwMDA+Owo+ID4gKwkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDI2OCBJUlFfVFlQRV9M RVZFTF9MT1c+Owo+ID4gKwkJY2xvY2tzID0gPCZpbWdzeXMgQ0xLX0lNR19MQVJCNT4sCj4gPiAr CQkJIDwmaW1nc3lzIENMS19JTUdfRElQPjsKPiA+ICsJCWNsb2NrLW5hbWVzID0gIkRJUF9DR19J TUdfTEFSQjUiLAo+ID4gKwkJCSAgICAgICJESVBfQ0dfSU1HX0RJUCI7Cj4gPiArCX07Cj4gPiAt LSAKPiA+IDIuMTguMAo+ID4gCgpTaW5jZXJlbHksCgpGcmVkZXJpYyBDaGVuCgoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE66C004C9 for ; Tue, 7 May 2019 14:16:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82E102087F for ; Tue, 7 May 2019 14:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726634AbfEGOQZ (ORCPT ); Tue, 7 May 2019 10:16:25 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:35832 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726063AbfEGOQZ (ORCPT ); Tue, 7 May 2019 10:16:25 -0400 X-UUID: 92cac1ec1011402e98fa0e667af04154-20190507 X-UUID: 92cac1ec1011402e98fa0e667af04154-20190507 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1660573465; Tue, 07 May 2019 22:16:20 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 7 May 2019 22:16:19 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 7 May 2019 22:16:19 +0800 Message-ID: <1557238579.11663.15.camel@mtksdccf07> Subject: Re: [RFC PATCH V1 3/6] dt-bindings: mt8183: Added DIP dt-bindings From: Frederic Chen To: Rob Herring CC: , , , , , , , , , , , , , , , , , , , , Date: Tue, 7 May 2019 22:16:19 +0800 In-Reply-To: <20190430011619.GA22170@bogus> References: <20190417104511.21514-1-frederic.chen@mediatek.com> <20190417104511.21514-4-frederic.chen@mediatek.com> <20190430011619.GA22170@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 X-MTK: N Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Dear Rob, I appreciate your comments. On Mon, 2019-04-29 at 20:16 -0500, Rob Herring wrote: > On Wed, Apr 17, 2019 at 06:45:08PM +0800, Frederic Chen wrote: > > This patch adds DT binding documentation for the Digital Image > > Processing (DIP) unit of camera ISP system on Mediatek's SoCs. > > > > Signed-off-by: Frederic Chen > > --- > > .../bindings/media/mediatek,mt8183-dip.txt | 35 +++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt b/Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt > > new file mode 100644 > > index 000000000000..0e1994bf82f0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8183-dip.txt > > @@ -0,0 +1,35 @@ > > +* Mediatek Digital Image Processor (DIP) > > + > > +Digital Image Processor (DIP) unit in Mediatek ISP system is responsible for > > +image content adjustment according to the tuning parameters. DIP can process > > +the image form memory buffer and output the processed image to multiple output > > +buffers. Furthermore, it can support demosaicing and noise reduction on the > > +images. > > + > > +Required properties: > > +- compatible: "mediatek,mt8183-dip" > > +- reg: Physical base address and length of the function block register space > > +- interrupts: interrupt number to the cpu > > +- iommus: should point to the respective IOMMU block with master port as > > + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > + for details. > > +- mediatek,larb: must contain the local arbiters in the current Socs, see > > + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > > + for details. > > +- clocks: must contain the local arbiters 5 (LARB5) and DIP clock > > +- clock-names: must contain DIP_CG_IMG_LARB5 and DIP_CG_IMG_DIP > > + > > +Example: > > + dip: dip@15022000 { > > + compatible = "mediatek,mt8183-dip"; > > + mediatek,larb = <&larb5>; > > > + mediatek,mdp3 = <&mdp_rdma0>; > > + mediatek,vpu = <&vpu>; > > Not documented. > “mediatek,vpu” will be replaced by “mediatek,scp.” I would like to add the following description in next version of the patch: - mediatek,scp: must point to the scp block of the co-processor used with DIP. Please see Documentation/devicetree/bindings/remoteproc/mtk,scp.txt for the detail. - mediatek,mdp3: must point to the Media Data Path 3 (MDP3) block. Please see Documentation/devicetree/bindings/media/mediatek,mt8183-mdp3.txt for the detail. Example: mdp_rdma0: mdp_rdma0@14001000 { compatible = "mediatek,mt8183-mdp-rdma", "mediatek,mt8183-mdp3"; mediatek,vpu = <&vpu>; mediatek,scp = <&scp>; mediatek,mdp-id = <0>; /* ...... */ }; scp: scp@10500000 { compatible = "mediatek,mt8183-scp"; reg = <0 0x10500000 0 0x80000>, <0 0x105c0000 0 0x5000>; reg-names = "sram", "cfg"; interrupts = ; clocks = <&infracfg CLK_INFRA_SCPSYS>; clock-names = "main"; memory-region = <&scp_mem_reserved>; status = "okay"; }; dip: dip@15022000 { compatible = "mediatek,mt8183-dip"; mediatek,larb = <&larb5>; mediatek,mdp3 = <&mdp_rdma0>; mediatek,scp = <&scp>; /* ...... */ }; The dependent Mediatek SCP and MDP3 patch have been sent: [1] Mediatek SCP, https://patchwork.kernel.org/patch/10897319/ [2] Meidatek MDP3, https://patchwork.kernel.org/patch/10844229/ > > + iommus = <&iommu M4U_PORT_CAM_IMGI>; > > + reg = <0 0x15022000 0 0x6000>; > > + interrupts = ; > > + clocks = <&imgsys CLK_IMG_LARB5>, > > + <&imgsys CLK_IMG_DIP>; > > + clock-names = "DIP_CG_IMG_LARB5", > > + "DIP_CG_IMG_DIP"; > > + }; > > -- > > 2.18.0 > > Sincerely, Frederic Chen