From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 836B5C04AB1 for ; Mon, 13 May 2019 07:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CA8021019 for ; Mon, 13 May 2019 07:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557733273; bh=BcNqnhgndmOJ66gUPvwGemAhhqqIf71VUdoaNWi+//c=; h=Subject:To:Cc:From:Date:List-ID:From; b=ulzLG1LGLkum6hAOKxsU95HifZV7nioom57fe2ajDPCid0BdbGn8FyhY5Ah/uzoxT oQ6VinrrJ5kuoh5RRjiePTE/K5a2HTzbr3iTqHWWw/BevCZnNlaQHMOSwOJIbQMPKS ffDQsAHFTI0ojF7IF5Q2hbrXEDj8hTmcT4QWxWbg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727371AbfEMHlM (ORCPT ); Mon, 13 May 2019 03:41:12 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49753 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727272AbfEMHlM (ORCPT ); Mon, 13 May 2019 03:41:12 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 46E5E20D84; Mon, 13 May 2019 03:41:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 13 May 2019 03:41:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=0Js0TM nXBWVx/g+EfTeBrqLroO8IcdRH2q7QpRBz1QE=; b=XKxuBBJxjLI16XAGB3P2Ho u+yCHEVSl/nRG+HjviKl1Xeln3NEjUMfXLcxWPxsCYG2wfA0X7t+dGWr89WtB5Od r2OJFsPm0BaaWWHP2MiIr8UOqhSN8dyraT/DYz7rW5gHONZKZuyZYPr6Uz9hzWf/ gilHsZoNzQN3H6A6PHBMBmUMyqfaOClwQgoIRO5wKSk28WXmt+SZ1ryfAgDGaVHz /auuK4tGdm4kYuD7+ZsUcwIBA9pwd16sZLnNRXDVY6ZJ1VGFh7jIj0oRAo2+/q6m dXcynJo/0B+WwW2cRK0I7oVTfhkx9dn1LWEHNF0KI0E10m3Bp/guzVZZJpNDH/JA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleefgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtjeenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepkeefrdekiedrkeelrd dutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id E354710378; Mon, 13 May 2019 03:41:09 -0400 (EDT) Subject: FAILED: patch "[PATCH] platform/x86: dell-laptop: fix rfkill functionality" failed to apply to 4.14-stable tree To: mario.limonciello@dell.com, dvhart@infradead.org, pali.rohar@gmail.com, pepijndevos@gmail.com, stable@vger.kernel.org Cc: From: Date: Mon, 13 May 2019 09:41:08 +0200 Message-ID: <155773326874172@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 6cc13c28da5beee0f706db6450e190709700b34a Mon Sep 17 00:00:00 2001 From: Mario Limonciello Date: Wed, 27 Mar 2019 09:25:34 -0500 Subject: [PATCH] platform/x86: dell-laptop: fix rfkill functionality MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When converting the driver two arguments were transposed leading to rfkill not working. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 Reported-by: Pepijn de Vos Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") Signed-off-by: Mario Limonciello Acked-by: Pali Rohár Cc: # 4.14.x Signed-off-by: Darren Hart (VMware) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 95e6ca116e00..a561f653cf13 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -531,7 +531,7 @@ static void dell_rfkill_query(struct rfkill *rfkill, void *data) return; } - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); hwswitch = buffer.output[1]; @@ -562,7 +562,7 @@ static int dell_debugfs_show(struct seq_file *s, void *data) return ret; status = buffer.output[1]; - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); hwswitch_ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); if (hwswitch_ret) return hwswitch_ret; @@ -647,7 +647,7 @@ static void dell_update_rfkill(struct work_struct *ignored) if (ret != 0) return; - dell_fill_request(&buffer, 0, 0x2, 0, 0); + dell_fill_request(&buffer, 0x2, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL); if (ret == 0 && (status & BIT(0)))