All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2] librte_pmd_ixgbe: Add queue start failure check
Date: Tue, 27 Jan 2015 15:12:18 +0100	[thread overview]
Message-ID: <1558492.KSTKnLp9iV@xps13> (raw)
In-Reply-To: <1422360978-16954-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

2015-01-27 20:16, Michael Qiu:
> For ixgbe, when queue start failure, for example, mbuf allocate
> failure, the device will still start success, which could be
> an issue.
> 
> Add return status check of queue start to avoid this issue.
> 
> Signed-off-by: Michael Qiu <michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> v2 --> v1
> 	. remove duplicated error message in ixgbe_dev_rxtx_start()
> 	. remove '\n' in PMD_INIT_LOG()

So the braces are not needed anymore (reported by checkpatch):
> +			if (ret < 0) {
> +				return ret;
> +			}

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Applied with removed braces

Thanks
-- 
Thomas

      parent reply	other threads:[~2015-01-27 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 14:45 [PATCH] librte_pmd_ixgbe: Add queue start failure check Michael Qiu
2015-01-19 15:50 ` Qiu, Michael
     [not found] ` <1421333111-22136-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-27 10:00   ` Thomas Monjalon
2015-01-27 12:00     ` Qiu, Michael
     [not found]       ` <533710CFB86FA344BFBF2D6802E60286CBAD55-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-27 14:14         ` Thomas Monjalon
2015-01-27 12:16   ` [PATCH v2] " Michael Qiu
     [not found]     ` <1422360978-16954-1-git-send-email-michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-27 14:12       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558492.KSTKnLp9iV@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=michael.qiu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.