From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com,
cristian.dumitrescu@intel.com, olivier.matz@6wind.com
Subject: Re: [PATCH] mbuf: fix compile by making sched struct visible
Date: Thu, 10 Jan 2019 18:34:58 +0100 [thread overview]
Message-ID: <1558979.Xtpf54c0cE@xps> (raw)
In-Reply-To: <20190110165051.4859-1-harry.van.haaren@intel.com>
10/01/2019 17:50, Harry van Haaren:
> Although C compilation works with the struct rte_mbuf_sched
> declared inside the struct rte_mbuf namespace, C++ fails to
> compile. This fix moves the rte_mbuf_sched struct up to the
> global namespace, instead of declaring it inside the struct
> mbuf namespace.
>
> The struct rte_mbuf_sched is being used on the stack in
> rte_mbuf_sched_get() and as a cast in _set(). For this
> reason, it must be exposed as an available type.
>
> Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field")
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> ---
>
> Cc: reshma.pattan@intel.com
> Cc: cristian.dumitrescu@intel.com
> Cc: thomas@monjalon.net
>
> Hey folks,
>
> Currently the mbuf header will fail to compile with a C++ compiler,
> this patch is one possible solution. I'm not particularly happy with
> this as a fix as it reduces mbuf struct readability, however it does
> resolve the issue.
What are the other possible solutions?
next prev parent reply other threads:[~2019-01-10 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 16:50 [PATCH] mbuf: fix compile by making sched struct visible Harry van Haaren
2019-01-10 17:34 ` Thomas Monjalon [this message]
2019-01-10 17:57 ` Van Haaren, Harry
2019-01-10 18:06 ` [PATCH v2] mbuf: fix compile by removing struct from function Harry van Haaren
2019-01-10 18:40 ` Dumitrescu, Cristian
2019-01-11 3:01 ` Gavin Hu (Arm Technology China)
2019-01-11 6:03 ` Stephen Hemminger
2019-01-11 8:44 ` Olivier Matz
2019-01-11 11:20 ` Van Haaren, Harry
2019-01-11 11:32 ` [PATCH v3] mbuf: fix compile by making sched struct visible Harry van Haaren
2019-01-11 14:33 ` Dumitrescu, Cristian
2019-01-14 14:58 ` Olivier Matz
2019-01-14 15:28 ` Thomas Monjalon
2019-01-10 22:05 ` [PATCH] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558979.Xtpf54c0cE@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=olivier.matz@6wind.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.