All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <Alexander.Levin@microsoft.com>
Cc: stable <stable@vger.kernel.org>
Subject: [stable] binder: fix race between munmap() and direct reclaim
Date: Mon, 27 May 2019 22:09:32 +0100	[thread overview]
Message-ID: <1558991372.2631.10.camel@codethink.co.uk> (raw)

There are commits in the 4.14, 4.19 and 5.0 stable branches that claim
to be backports of:

commit 26528be6720bb40bc8844e97ee73a37e530e9c5e
Author: Todd Kjos <tkjos@android.com>
Date:   Thu Feb 14 15:22:57 2019 -0800

    binder: fix handling of misaligned binder object

However the source changes actually match:

commit 5cec2d2e5839f9c0fec319c523a911e0a7fd299f
Author: Todd Kjos <tkjos@android.com>
Date:   Fri Mar 1 15:06:06 2019 -0800

    binder: fix race between munmap() and direct reclaim

So far as I can see, the former fixes a bug only introduced in 5.1 and
the latter fixes an older bug, so the changes are correct and only the
metadata is not.

Similar mix-ups have happened before and I'm a little disturbed that
this keeps happening.  In any case, you may want to revert and re-apply 
with correct metadata.

Ben.

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom

             reply	other threads:[~2019-05-27 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 21:09 Ben Hutchings [this message]
2019-05-28  6:51 ` [stable] binder: fix race between munmap() and direct reclaim Greg Kroah-Hartman
     [not found]   ` <CAHRSSEzopAbeAv4ap9xTrC1nCbpw1ZPrEYEMZOc5W_EcLZaktQ@mail.gmail.com>
2019-05-31 20:09     ` Todd Kjos
2019-06-04 14:50       ` Greg Kroah-Hartman
2019-06-05 16:43         ` Todd Kjos
2019-06-05 17:49           ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558991372.2631.10.camel@codethink.co.uk \
    --to=ben.hutchings@codethink.co.uk \
    --cc=Alexander.Levin@microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.