From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Wed, 25 Apr 2018 16:17:25 +0300 Message-ID: <1559016.ZjzeSVB84W@avalon> References: <20180425075314.19137-1-philippe.cornu@st.com> <16954794.QiYqgNKfkn@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philippe CORNU Cc: Mark Rutland , "devicetree@vger.kernel.org" , Alexandre TORGUE , David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Yannick FERTRE , Rob Herring List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcGUsCgpPbiBXZWRuZXNkYXksIDI1IEFwcmlsIDIwMTggMTU6MjA6MDQgRUVTVCBQ aGlsaXBwZSBDT1JOVSB3cm90ZToKPiBPbiAwNC8yNS8yMDE4IDExOjAxIEFNLCBMYXVyZW50IFBp bmNoYXJ0IHdyb3RlOgo+ID4gT24gV2VkbmVzZGF5LCAyNSBBcHJpbCAyMDE4IDEwOjUzOjEzIEVF U1QgUGhpbGlwcGUgQ29ybnUgd3JvdGU6Cj4gPj4gQWRkIG9wdGlvbmFsIHBvd2VyIHN1cHBsaWVz IHVzaW5nIHRoZSBkZXNjcmlwdGlvbiBmb3VuZCBpbgo+ID4+ICJTaUk5MDIyQS9TaUk5MDI0QSBI RE1JIFRyYW5zbWl0dGVyIERhdGEgU2hlZXQgKEF1Z3VzdCAyMDE2KSIuCj4gPj4KPiA+PiBUaGVy ZSBpcyBhIHNpbmdsZSAxdjIgc3VwcGx5IHZvbHRhZ2UgbmFtZWQgdmNjMTIgZnJvbSB3aGljaCBj dmNjMTIKPiA+PiAoZGlnaXRhbCBjb3JlKSBhbmQgYXZjYzEyIChUTURTIGFuYWxvZykgYXJlIGRl cml2ZWQgYmVjYXVzZSBhY2NvcmRpbmcKPiA+PiB0byB0aGlzIGRhdGEgc2hlZXQ6Cj4gPj4gImN2 Y2MxMiBhbmQgYXZjYzEyIGNhbiBiZSBkZXJpdmVkIGZyb20gdGhlIHNhbWUgcG93ZXIgc291cmNl Igo+ID4gCj4gPiBTaG91bGRuJ3QgdGhlIHBvd2VyIHN1cHBsaWVzIGJlIG1hbmRhdG9yeSwgYXMg ZXhwbGFpbmVkIGJ5IE1hcmsgaW4KPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2Fy Y2hpdmVzL2RyaS1kZXZlbC8yMDE4LUFwcmlsLzE3MjQwMC5odG1sCj4gPiA/IAo+IAo+IExhdXJl bnQsCj4gTWFueSB0aGFua3MgTGF1cmVudCBmb3IgeW91ciBjb21tZW50LCBJIHVuZGVyc3Rvb2Qg dGhlIG1lcmdlIG9mIHRoZSB0d28gCj4gMXYyIHBvd2VyIHN1cHBsaWVzIGJ1dCBtaXNzZWQgdGhl ICJtYW5kYXRvcnkiIHBhcnQuLi4gbWF5YmUgYmVjYXVzZSB0aGlzIAo+IHBhdGNoICh3aXRoIG9w dGlvbmFsIHBvd2VyIHN1cHBsaWVzKSBhbHJlYWR5IGdvdCB0aGUgcmV2aWV3ZWQtYnkgZnJvbSAK PiBSb2IsIEkgdGhvdWdodCB0aGUgZGlzY3Vzc2lvbiB0aHJlYWQgeW91IHBvaW50ZWQgb3V0IHdh cyBhcHBsaWNhYmxlIAo+ICJvbmx5IiB0byB0b3RhbGx5IG5ldyBkcml2ZXIgZG9jdW1lbnRhdGlv bi4KPiAKPiBTbywgb24gbXkgc2lkZSwgYXMgYSAibmV3IHVzZXIiIG9mIHNpaTkwMnggSUMsIG5v IHByb2JsZW0gdG8gcHV0IHRoZXNlIAo+IHBvd2VyIHN1cHBsaWVzIGFzIG1hbmRhdG9yeSBpbnN0 ZWFkIG9mIG9wdGlvbmFsIHByb3BlcnRpZXMgYnV0IEkgd291bGQgCj4gbGlrZSB0byBiZSBzdXJl IHRoaXMgaXMgYXBwbGljYWJsZSB0byBib3RoIG9sZCBhbmQgbmV3IGJpbmRpbmdzIGRvYyA6ICkK CldlIG9idmlvdXNseSBuZWVkIHRvIHJldGFpbiBiYWNrd2FyZCBjb21wYXRpYmlsaXR5LCBzbyBv biB0aGUgZHJpdmVyIHNpZGUgeW91IApuZWVkIHRvIHRyZWF0IHRob3NlIHBvd2VyIHN1cHBsaWVz IGFzIG9wdGlvbmFsLiBGcm9tIGEgRFQgYmluZGluZ3MgcG9pbnQgb2YgCnZpZXcsIGhvd2V2ZXIs IEkgdGhpbmsgdGhleSBzaG91bGQgYmUgbWFuZGF0b3J5IGZvciBuZXcgRFQuCgo+IFJvYiwKPiBj b3VsZCB5b3UgcGxlYXNlIGNvbmZpcm0gdGhlc2UgcG93ZXIgc3VwcGx5IHByb3BlcnRpZXMgc2hv dWxkIGJlIAo+ICJtYW5kYXRvcnkiPwo+IGlmIHllcywgc2hvdWxkIHdlIHRoZW4gbW9kaWZ5IG90 aGVyIG9wdGlvbmFsIHByb3BlcnRpZXMgbGlrZSB0aGUgCj4gcmVzZXQtZ3Bpb3MgdG9vIGluIHRo ZSBmdXR1cmU/CgpUaGUgR1BJT3MgcHJvcGVydGllcyBhcmUgZGlmZmVyZW50IGluIG15IG9waW5p b24sIGFzIHRoZXJlJ3Mgbm8gcmVxdWlyZW1lbnQgdG8gCmNvbm5lY3QgZm9yIGluc3RhbmNlIHRo ZSByZXNldCBwaW4gdG8gYSBHUElPIGNvbnRyb2xsYWJsZSBieSB0aGUgU29DLiBUaGUgcGluIApj b3VsZCBiZSBoYXJkd2lyZWQgdG8gVkNDLCBvciBjb25uZWN0ZWQgdG8gYSBzeXN0ZW0gcmVzZXQg dGhhdCBpcyAKYXV0b21hdGljYWxseSBtYW5hZ2VkIHdpdGhvdXQgU29DIGludGVydmVudGlvbi4g VGhlIHBvd2VyIHN1cHBsaWVzLCBob3dldmVyLCAKYXJlIG1hbmRhdG9yeSwgaW4gdGhlIHNlbnNl IHRoYXQgdGhlIGNoaXAgd2lsbCBub3Qgd29yayBpZiB5b3UgbGVhdmUgdGhlIHBvd2VyIApzdXBw bGllcyB1bmNvbm5lY3RlZC4KCj4gQmlnIHRoYW5rcyB0byBib3RoIG9mIHlvdSwKCllvdSdyZSB3 ZWxjb21lICEKCj4gPj4gU2lnbmVkLW9mZi1ieTogUGhpbGlwcGUgQ29ybnUgPHBoaWxpcHBlLmNv cm51QHN0LmNvbT4KPiA+PiAtLS0KPiA+PiAKPiA+PiAgIERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9zaWk5MDJ4LnR4dCB8IDIgKysKPiA+PiAgIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQKPiA+PiBhL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9zaWk5MDJ4LnR4 dAo+ID4+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdl L3NpaTkwMngudHh0IGluZGV4Cj4gPj4gNTZhM2U2OGNjYjgwLi45ZmI0MWZjOWFmNTEgMTAwNjQ0 Cj4gPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJp ZGdlL3NpaTkwMngudHh0Cj4gPj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2Rpc3BsYXkvYnJpZGdlL3NpaTkwMngudHh0Cj4gPj4gQEAgLTgsNiArOCw4IEBAIE9wdGlv bmFsIHByb3BlcnRpZXM6Cj4gPj4gICAJLSBpbnRlcnJ1cHRzLWV4dGVuZGVkIG9yIGludGVycnVw dC1wYXJlbnQgKyBpbnRlcnJ1cHRzOiBkZXNjcmliZQo+ID4+ICAgCSAgdGhlIGludGVycnVwdCBs aW5lIHVzZWQgdG8gaW5mb3JtIHRoZSBob3N0IGFib3V0IGhvdHBsdWcgZXZlbnRzLgo+ID4+ICAg CS0gcmVzZXQtZ3Bpb3M6IE9GIGRldmljZS10cmVlIGdwaW8gc3BlY2lmaWNhdGlvbiBmb3IgUlNU X04gcGluLgo+ID4+ICsJLSBpb3ZjYy1zdXBwbHk6IEkvTyBzdXBwbHkgdm9sdGFnZSAoMS44ViBv ciAzLjNWLCBob3N0LWRlcGVuZGVudCkuCj4gPj4gKwktIHZjYzEyLXN1cHBseTogVE1EUyBhbmFs b2cgJiBkaWdpdGFsIGNvcmUgc3VwcGx5IHZvbHRhZ2UgKDEuMlYpLgo+ID4+Cj4gPj4gICBPcHRp b25hbCBzdWJub2RlczoKPiA+PiAgIAktIHZpZGVvIGlucHV0OiB0aGlzIHN1Ym5vZGUgY2FuIGNv bnRhaW4gYSB2aWRlbyBpbnB1dCBwb3J0IG5vZGUKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5j aGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753587AbeDYNRO (ORCPT ); Wed, 25 Apr 2018 09:17:14 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:39568 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbeDYNRM (ORCPT ); Wed, 25 Apr 2018 09:17:12 -0400 From: Laurent Pinchart To: Philippe CORNU Cc: Archit Taneja , Andrzej Hajda , David Airlie , Rob Herring , Mark Rutland , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yannick FERTRE , Benjamin Gaignard , Alexandre TORGUE Subject: Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Wed, 25 Apr 2018 16:17:25 +0300 Message-ID: <1559016.ZjzeSVB84W@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20180425075314.19137-1-philippe.cornu@st.com> <16954794.QiYqgNKfkn@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philippe, On Wednesday, 25 April 2018 15:20:04 EEST Philippe CORNU wrote: > On 04/25/2018 11:01 AM, Laurent Pinchart wrote: > > On Wednesday, 25 April 2018 10:53:13 EEST Philippe Cornu wrote: > >> Add optional power supplies using the description found in > >> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". > >> > >> There is a single 1v2 supply voltage named vcc12 from which cvcc12 > >> (digital core) and avcc12 (TMDS analog) are derived because according > >> to this data sheet: > >> "cvcc12 and avcc12 can be derived from the same power source" > > > > Shouldn't the power supplies be mandatory, as explained by Mark in > > https://lists.freedesktop.org/archives/dri-devel/2018-April/172400.html > > ? > > Laurent, > Many thanks Laurent for your comment, I understood the merge of the two > 1v2 power supplies but missed the "mandatory" part... maybe because this > patch (with optional power supplies) already got the reviewed-by from > Rob, I thought the discussion thread you pointed out was applicable > "only" to totally new driver documentation. > > So, on my side, as a "new user" of sii902x IC, no problem to put these > power supplies as mandatory instead of optional properties but I would > like to be sure this is applicable to both old and new bindings doc : ) We obviously need to retain backward compatibility, so on the driver side you need to treat those power supplies as optional. From a DT bindings point of view, however, I think they should be mandatory for new DT. > Rob, > could you please confirm these power supply properties should be > "mandatory"? > if yes, should we then modify other optional properties like the > reset-gpios too in the future? The GPIOs properties are different in my opinion, as there's no requirement to connect for instance the reset pin to a GPIO controllable by the SoC. The pin could be hardwired to VCC, or connected to a system reset that is automatically managed without SoC intervention. The power supplies, however, are mandatory, in the sense that the chip will not work if you leave the power supplies unconnected. > Big thanks to both of you, You're welcome ! > >> Signed-off-by: Philippe Cornu > >> --- > >> > >> Documentation/devicetree/bindings/display/bridge/sii902x.txt | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index > >> 56a3e68ccb80..9fb41fc9af51 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > >> @@ -8,6 +8,8 @@ Optional properties: > >> - interrupts-extended or interrupt-parent + interrupts: describe > >> the interrupt line used to inform the host about hotplug events. > >> - reset-gpios: OF device-tree gpio specification for RST_N pin. > >> + - iovcc-supply: I/O supply voltage (1.8V or 3.3V, host-dependent). > >> + - vcc12-supply: TMDS analog & digital core supply voltage (1.2V). > >> > >> Optional subnodes: > >> - video input: this subnode can contain a video input port node -- Regards, Laurent Pinchart