From: Jean Delvare <jdelvare@suse.de>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Wolfram Sang" <wsa@the-dreams.de>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Michał Kępień" <kernel@kempniu.pl>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
"Valdis Kletnieks" <Valdis.Kletnieks@vt.edu>,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Mario Limonciello" <Mario_Limonciello@dell.com>,
"Alex Hung" <alex.hung@canonical.com>,
"Takashi Iwai" <tiwai@suse.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines
Date: Tue, 28 May 2019 11:50:15 +0200 [thread overview]
Message-ID: <1559037015.6521.3.camel@suse.de> (raw)
In-Reply-To: <20190528094132.ytsittb5hcgthoy2@pali>
On Tue, 2019-05-28 at 11:41 +0200, Pali Rohár wrote:
> This is not a problem. lis3lv02d provides two things:
>
> 1) 3 axes accelerometer
> 2) optional interrupt and signal it to userspace via misc device
>
> dell-smo8800 does not call any parts of lis2lv02d module. It just
> provides for userspace same misc device API as lis3lv02d.
>
> As lis3lv02d has misc device optional, registered i2c device from
> i2c-i801 does not enable it.
>
> So technically it is one device, but their functionality divided into
> two modules. One which reports accelerometer axes and one which signals
> disk fall interrupt. These two modules and functionalities does not have
> to interact, so it is safe to have them separated.
OK, thanks for the explanation. But assuming that we now instantiate
the lis2lv02d device from i2c-i801 for exactly all the same machines,
can't we just *enable* the freefall misc device feature of lis2lv02d
and kill the dell-smo8800 driver completely? Seems more simple to
maintain going forward.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-05-28 9:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 13:32 [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines Pali Rohár
2018-01-28 14:39 ` Andy Shevchenko
2018-01-28 14:45 ` Pali Rohár
2018-01-28 15:00 ` Andy Shevchenko
2018-01-31 12:03 ` Pali Rohár
2018-01-31 12:27 ` Andy Shevchenko
2018-02-12 15:30 ` Pali Rohár
2018-02-13 14:55 ` Andy Shevchenko
2018-02-13 15:00 ` Pali Rohár
2018-02-13 15:06 ` Andy Shevchenko
2018-02-13 16:50 ` Pali Rohár
2018-02-13 17:01 ` Andy Shevchenko
2018-02-13 17:05 ` Andy Shevchenko
2018-02-26 20:32 ` Wolfram Sang
2018-03-08 22:53 ` Pali Rohár
2018-04-18 11:46 ` Pali Rohár
2019-04-27 6:48 ` Pali Rohár
2019-05-28 9:19 ` Jean Delvare
2019-05-28 9:41 ` Pali Rohár
2019-05-28 9:50 ` Jean Delvare [this message]
2019-05-28 9:54 ` Pali Rohár
2019-05-28 9:54 ` Pali Rohár
2019-05-28 10:00 ` Jean Delvare
2018-02-11 22:03 ` Michał Kępień
2018-02-12 15:25 ` Andy Shevchenko
2019-06-02 13:20 ` [PATCH v3] " Pali Rohár
2019-06-04 14:57 ` Jean Delvare
2019-06-04 22:30 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559037015.6521.3.camel@suse.de \
--to=jdelvare@suse.de \
--cc=Mario_Limonciello@dell.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alex.hung@canonical.com \
--cc=andy.shevchenko@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=jochen@penguin-breeder.org \
--cc=kernel@kempniu.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stevenhoneyman@gmail.com \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.