From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1CE7C28CC0 for ; Wed, 29 May 2019 20:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB284241B2 for ; Wed, 29 May 2019 20:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Vp0ytwik"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cSnhvA7B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726464AbfE2UzI (ORCPT ); Wed, 29 May 2019 16:55:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55244 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbfE2UzI (ORCPT ); Wed, 29 May 2019 16:55:08 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 556C260E3E; Wed, 29 May 2019 20:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559163306; bh=a10cqXD3K1rvMJw3L43nt+iaIhgdpjlzVZD15xJBhaA=; h=From:To:Cc:Subject:Date:From; b=Vp0ytwik6JEWAQFO/yG5VFu3Z6MkCfPENawBVa/y59bquj5SpgduvRjs2xXk0Pdrg xAShGzTeW+ZhTTQJhO/ke4tluOhH90QajK5uXiU5Odl6uJsGHhWHgplxm1hmnN+M9s WYMKWEjF49mjefdBuETfWF9op/mMPhoYsCjvOGFs= Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 00F036030E; Wed, 29 May 2019 20:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559163304; bh=a10cqXD3K1rvMJw3L43nt+iaIhgdpjlzVZD15xJBhaA=; h=From:To:Cc:Subject:Date:From; b=cSnhvA7BCJGATHq0sbtLanP6Lv34+whQEyH5M/1UWMBpLxrtk5CUaKV7c2SE1lSQd 3/RMJ4i5inUbtIPaeQtlZgTz/sjprVqxt79t2tdd0hrHLlltv1Ng8V263HFJzEQIKv 05ODYE8MeXimWoQrEpyB//MZ6ROo8rVnPKiBQOC0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 00F036030E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org From: Jordan Crouse To: freedreno@lists.freedesktop.org Cc: jean-philippe.brucker@arm.com, linux-arm-msm@vger.kernel.org, hoegsberg@google.com, dianders@chromium.org, Sean Paul , Thomas Zimmermann , Sharat Masetty , dri-devel@lists.freedesktop.org, Robin Murphy , David Airlie , Joerg Roedel , Zhen Lei , Rob Clark , linux-arm-kernel@lists.infradead.org, Will Deacon , Rob Herring , Wen Yang , Kees Cook , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jonathan Marek , Mamta Shukla , Daniel Vetter Subject: [PATCH v3 00/16] drm/msm: Per-instance pagetable support Date: Wed, 29 May 2019 14:54:36 -0600 Message-Id: <1559163292-4792-1-git-send-email-jcrouse@codeaurora.org> X-Mailer: git-send-email 2.7.4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This is v3 of the per-instance pagetable support. Biggest change in this revision is moving nearly all of the split pagetable support into io-pgtable-arm and setting up specific ops to handle the unique behavior of the split pagetables. Now that I've spent some time with it, I like how it turned out. For background: Per-instance pagetables allow the target GPU driver to create and manage an individual pagetable for each file descriptor instance and switch between them asynchronously using the GPU to reprogram the pagetable registers on the fly. Most of the heavy lifting for this is done in the arm-smmu-v2 driver by taking advantage of the newly added multiple domain API. The first patch in the series allows opted-in clients to direct map a device with iommu_request_dm_for_dev(). This bypasses the DMA domain creation in the IOMMU core which serves several purposes for the GPU by skipping the otherwise unused DMA domain and also keeping context bank 0 unused on the hardware (for better or worse, the GPU is hardcoded to only use context bank 0 for switching). The next several patches enable split pagetable support. This is used to map global buffers for the GPU so we can safely switch the TTBR0 pagetable for the instance. The last two arm-smmu-v2 patches enable auxillary domain support. Again the SMMU client can opt-in to allow auxiliary domains, and if enabled will create a pagetable but not otherwise touch the hardware. The client can get the address of the pagetable through an attribute to perform its own switching. After the arm-smmu-v2 patches are more than several msm/gpu patches to allow for target specific address spaces, enable 64 bit virtual addressing and implement the mechanics of pagetable switching. For the purposes of merging all the patches between drm/msm/adreno: Enable 64 bit mode by default on a5xx and a6xx targets and drm/msm: Add support to create target specific address spaces can be merged to the msm-next tree without dependencies on the IOMMU changes. Only the last three patches will require coordination between the two areas. Jordan Crouse (16): iommu/arm-smmu: Allow client devices to select direct mapping iommu: Add DOMAIN_ATTR_SPLIT_TABLES iommu/io-pgtable-arm: Add support for AARCH64 split pagetables iommu/arm-smmu: Add support for DOMAIN_ATTR_SPLIT_TABLES iommu: Add DOMAIN_ATTR_PTBASE iommu/arm-smmu: Add auxiliary domain support for arm-smmuv2 drm/msm/adreno: Enable 64 bit mode by default on a5xx and a6xx targets drm/msm: Print all 64 bits of the faulting IOMMU address drm/msm: Pass the MMU domain index in struct msm_file_private drm/msm/gpu: Move address space setup to the GPU targets drm/msm: Add support for IOMMU auxiliary domains drm/msm: Add a helper function for a per-instance address space drm/msm: Add support to create target specific address spaces drm/msm/gpu: Add ttbr0 to the memptrs drm/msm/a6xx: Support per-instance pagetables drm/msm/a5xx: Support per-instance pagetables drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 37 +++-- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 50 ++++-- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 51 ++++-- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 163 ++++++++++++++++++- drivers/gpu/drm/msm/adreno/a5xx_gpu.h | 19 +++ drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 70 ++++++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 166 ++++++++++++++++++- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 7 - drivers/gpu/drm/msm/msm_drv.c | 25 ++- drivers/gpu/drm/msm/msm_drv.h | 5 + drivers/gpu/drm/msm/msm_gem.h | 2 + drivers/gpu/drm/msm/msm_gem_submit.c | 13 +- drivers/gpu/drm/msm/msm_gem_vma.c | 53 +++--- drivers/gpu/drm/msm/msm_gpu.c | 59 +------ drivers/gpu/drm/msm/msm_gpu.h | 3 + drivers/gpu/drm/msm/msm_iommu.c | 99 +++++++++++- drivers/gpu/drm/msm/msm_mmu.h | 4 + drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + drivers/iommu/arm-smmu.c | 176 ++++++++++++++++++-- drivers/iommu/io-pgtable-arm.c | 261 +++++++++++++++++++++++++++--- drivers/iommu/io-pgtable.c | 1 + include/linux/io-pgtable.h | 2 + include/linux/iommu.h | 2 + 24 files changed, 1082 insertions(+), 188 deletions(-) -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AEC4C28CC0 for ; Wed, 29 May 2019 20:59:56 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33A25241C3 for ; Wed, 29 May 2019 20:59:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Vp0ytwik"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cSnhvA7B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33A25241C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id DDD062A88; Wed, 29 May 2019 20:59:55 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B9B702A6B for ; Wed, 29 May 2019 20:55:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3FC9181A for ; Wed, 29 May 2019 20:55:06 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0CD3B60A63; Wed, 29 May 2019 20:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559163306; bh=a10cqXD3K1rvMJw3L43nt+iaIhgdpjlzVZD15xJBhaA=; h=From:To:Cc:Subject:Date:From; b=Vp0ytwik6JEWAQFO/yG5VFu3Z6MkCfPENawBVa/y59bquj5SpgduvRjs2xXk0Pdrg xAShGzTeW+ZhTTQJhO/ke4tluOhH90QajK5uXiU5Odl6uJsGHhWHgplxm1hmnN+M9s WYMKWEjF49mjefdBuETfWF9op/mMPhoYsCjvOGFs= Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 00F036030E; Wed, 29 May 2019 20:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559163304; bh=a10cqXD3K1rvMJw3L43nt+iaIhgdpjlzVZD15xJBhaA=; h=From:To:Cc:Subject:Date:From; b=cSnhvA7BCJGATHq0sbtLanP6Lv34+whQEyH5M/1UWMBpLxrtk5CUaKV7c2SE1lSQd 3/RMJ4i5inUbtIPaeQtlZgTz/sjprVqxt79t2tdd0hrHLlltv1Ng8V263HFJzEQIKv 05ODYE8MeXimWoQrEpyB//MZ6ROo8rVnPKiBQOC0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 00F036030E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org From: Jordan Crouse To: freedreno@lists.freedesktop.org Subject: [PATCH v3 00/16] drm/msm: Per-instance pagetable support Date: Wed, 29 May 2019 14:54:36 -0600 Message-Id: <1559163292-4792-1-git-send-email-jcrouse@codeaurora.org> X-Mailer: git-send-email 2.7.4 Cc: David Airlie , Will Deacon , dri-devel@lists.freedesktop.org, dianders@chromium.org, Wen Yang , Rob Herring , Jonathan Marek , jean-philippe.brucker@arm.com, iommu@lists.linux-foundation.org, Mamta Shukla , Kees Cook , linux-arm-msm@vger.kernel.org, Sharat Masetty , Daniel Vetter , Sean Paul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hoegsberg@google.com, Thomas Zimmermann , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org This is v3 of the per-instance pagetable support. Biggest change in this revision is moving nearly all of the split pagetable support into io-pgtable-arm and setting up specific ops to handle the unique behavior of the split pagetables. Now that I've spent some time with it, I like how it turned out. For background: Per-instance pagetables allow the target GPU driver to create and manage an individual pagetable for each file descriptor instance and switch between them asynchronously using the GPU to reprogram the pagetable registers on the fly. Most of the heavy lifting for this is done in the arm-smmu-v2 driver by taking advantage of the newly added multiple domain API. The first patch in the series allows opted-in clients to direct map a device with iommu_request_dm_for_dev(). This bypasses the DMA domain creation in the IOMMU core which serves several purposes for the GPU by skipping the otherwise unused DMA domain and also keeping context bank 0 unused on the hardware (for better or worse, the GPU is hardcoded to only use context bank 0 for switching). The next several patches enable split pagetable support. This is used to map global buffers for the GPU so we can safely switch the TTBR0 pagetable for the instance. The last two arm-smmu-v2 patches enable auxillary domain support. Again the SMMU client can opt-in to allow auxiliary domains, and if enabled will create a pagetable but not otherwise touch the hardware. The client can get the address of the pagetable through an attribute to perform its own switching. After the arm-smmu-v2 patches are more than several msm/gpu patches to allow for target specific address spaces, enable 64 bit virtual addressing and implement the mechanics of pagetable switching. For the purposes of merging all the patches between drm/msm/adreno: Enable 64 bit mode by default on a5xx and a6xx targets and drm/msm: Add support to create target specific address spaces can be merged to the msm-next tree without dependencies on the IOMMU changes. Only the last three patches will require coordination between the two areas. Jordan Crouse (16): iommu/arm-smmu: Allow client devices to select direct mapping iommu: Add DOMAIN_ATTR_SPLIT_TABLES iommu/io-pgtable-arm: Add support for AARCH64 split pagetables iommu/arm-smmu: Add support for DOMAIN_ATTR_SPLIT_TABLES iommu: Add DOMAIN_ATTR_PTBASE iommu/arm-smmu: Add auxiliary domain support for arm-smmuv2 drm/msm/adreno: Enable 64 bit mode by default on a5xx and a6xx targets drm/msm: Print all 64 bits of the faulting IOMMU address drm/msm: Pass the MMU domain index in struct msm_file_private drm/msm/gpu: Move address space setup to the GPU targets drm/msm: Add support for IOMMU auxiliary domains drm/msm: Add a helper function for a per-instance address space drm/msm: Add support to create target specific address spaces drm/msm/gpu: Add ttbr0 to the memptrs drm/msm/a6xx: Support per-instance pagetables drm/msm/a5xx: Support per-instance pagetables drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 37 +++-- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 50 ++++-- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 51 ++++-- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 163 ++++++++++++++++++- drivers/gpu/drm/msm/adreno/a5xx_gpu.h | 19 +++ drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 70 ++++++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 166 ++++++++++++++++++- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 7 - drivers/gpu/drm/msm/msm_drv.c | 25 ++- drivers/gpu/drm/msm/msm_drv.h | 5 + drivers/gpu/drm/msm/msm_gem.h | 2 + drivers/gpu/drm/msm/msm_gem_submit.c | 13 +- drivers/gpu/drm/msm/msm_gem_vma.c | 53 +++--- drivers/gpu/drm/msm/msm_gpu.c | 59 +------ drivers/gpu/drm/msm/msm_gpu.h | 3 + drivers/gpu/drm/msm/msm_iommu.c | 99 +++++++++++- drivers/gpu/drm/msm/msm_mmu.h | 4 + drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + drivers/iommu/arm-smmu.c | 176 ++++++++++++++++++-- drivers/iommu/io-pgtable-arm.c | 261 +++++++++++++++++++++++++++--- drivers/iommu/io-pgtable.c | 1 + include/linux/io-pgtable.h | 2 + include/linux/iommu.h | 2 + 24 files changed, 1082 insertions(+), 188 deletions(-) -- 2.7.4 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E1AC28CC0 for ; Wed, 29 May 2019 20:55:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 748D5241B6 for ; Wed, 29 May 2019 20:55:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DdrnoeqU"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Vp0ytwik"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cSnhvA7B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 748D5241B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ZooXboQ7yblX0zNX5cgMysBPiNrxidXp/p2MR68nPcE=; b=Ddr noeqUs9bFGgriTSmNT6vCkuuyZBRHC+DpZ+MpwkK2yxP4X0x2jGho+96MarvK9pRH1rSegeaMZO// Pi/pk8e4QpWIt1u8REsXmhSNPeetZje0DXCD3kq8lb8zKBwjFd6tVo0W5l0X/ILy/+B6vEo6+bpBN B+uz/kIzEgDhrStk6tVj3Te5GDnNDDX5CtE9CaYQ0qikd9uMk6y39QKAD6VvCQVqWOpbpVf9ysLej 1qNswIXnBl8MXpmyzKvl3nCeYk95L6QLeBE1/zbDWLMEmPwKFwVNvJWT2DZ/4eyQYZVYxBJz7SqbQ ZB46FmsqnMgbP23qcyAc7Rl/vXAKnfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW5bR-0007Ll-MG; Wed, 29 May 2019 20:55:17 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW5bI-0006vf-Pz for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2019 20:55:10 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 45E0360A4E; Wed, 29 May 2019 20:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559163306; bh=a10cqXD3K1rvMJw3L43nt+iaIhgdpjlzVZD15xJBhaA=; h=From:To:Cc:Subject:Date:From; b=Vp0ytwik6JEWAQFO/yG5VFu3Z6MkCfPENawBVa/y59bquj5SpgduvRjs2xXk0Pdrg xAShGzTeW+ZhTTQJhO/ke4tluOhH90QajK5uXiU5Odl6uJsGHhWHgplxm1hmnN+M9s WYMKWEjF49mjefdBuETfWF9op/mMPhoYsCjvOGFs= Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 00F036030E; Wed, 29 May 2019 20:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559163304; bh=a10cqXD3K1rvMJw3L43nt+iaIhgdpjlzVZD15xJBhaA=; h=From:To:Cc:Subject:Date:From; b=cSnhvA7BCJGATHq0sbtLanP6Lv34+whQEyH5M/1UWMBpLxrtk5CUaKV7c2SE1lSQd 3/RMJ4i5inUbtIPaeQtlZgTz/sjprVqxt79t2tdd0hrHLlltv1Ng8V263HFJzEQIKv 05ODYE8MeXimWoQrEpyB//MZ6ROo8rVnPKiBQOC0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 00F036030E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org From: Jordan Crouse To: freedreno@lists.freedesktop.org Subject: [PATCH v3 00/16] drm/msm: Per-instance pagetable support Date: Wed, 29 May 2019 14:54:36 -0600 Message-Id: <1559163292-4792-1-git-send-email-jcrouse@codeaurora.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_135509_024793_8710B1FF X-CRM114-Status: GOOD ( 18.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Will Deacon , dri-devel@lists.freedesktop.org, dianders@chromium.org, Wen Yang , Rob Herring , Jonathan Marek , jean-philippe.brucker@arm.com, Joerg Roedel , iommu@lists.linux-foundation.org, Mamta Shukla , Kees Cook , linux-arm-msm@vger.kernel.org, Sharat Masetty , Zhen Lei , Daniel Vetter , Sean Paul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Clark , hoegsberg@google.com, Thomas Zimmermann , Robin Murphy MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is v3 of the per-instance pagetable support. Biggest change in this revision is moving nearly all of the split pagetable support into io-pgtable-arm and setting up specific ops to handle the unique behavior of the split pagetables. Now that I've spent some time with it, I like how it turned out. For background: Per-instance pagetables allow the target GPU driver to create and manage an individual pagetable for each file descriptor instance and switch between them asynchronously using the GPU to reprogram the pagetable registers on the fly. Most of the heavy lifting for this is done in the arm-smmu-v2 driver by taking advantage of the newly added multiple domain API. The first patch in the series allows opted-in clients to direct map a device with iommu_request_dm_for_dev(). This bypasses the DMA domain creation in the IOMMU core which serves several purposes for the GPU by skipping the otherwise unused DMA domain and also keeping context bank 0 unused on the hardware (for better or worse, the GPU is hardcoded to only use context bank 0 for switching). The next several patches enable split pagetable support. This is used to map global buffers for the GPU so we can safely switch the TTBR0 pagetable for the instance. The last two arm-smmu-v2 patches enable auxillary domain support. Again the SMMU client can opt-in to allow auxiliary domains, and if enabled will create a pagetable but not otherwise touch the hardware. The client can get the address of the pagetable through an attribute to perform its own switching. After the arm-smmu-v2 patches are more than several msm/gpu patches to allow for target specific address spaces, enable 64 bit virtual addressing and implement the mechanics of pagetable switching. For the purposes of merging all the patches between drm/msm/adreno: Enable 64 bit mode by default on a5xx and a6xx targets and drm/msm: Add support to create target specific address spaces can be merged to the msm-next tree without dependencies on the IOMMU changes. Only the last three patches will require coordination between the two areas. Jordan Crouse (16): iommu/arm-smmu: Allow client devices to select direct mapping iommu: Add DOMAIN_ATTR_SPLIT_TABLES iommu/io-pgtable-arm: Add support for AARCH64 split pagetables iommu/arm-smmu: Add support for DOMAIN_ATTR_SPLIT_TABLES iommu: Add DOMAIN_ATTR_PTBASE iommu/arm-smmu: Add auxiliary domain support for arm-smmuv2 drm/msm/adreno: Enable 64 bit mode by default on a5xx and a6xx targets drm/msm: Print all 64 bits of the faulting IOMMU address drm/msm: Pass the MMU domain index in struct msm_file_private drm/msm/gpu: Move address space setup to the GPU targets drm/msm: Add support for IOMMU auxiliary domains drm/msm: Add a helper function for a per-instance address space drm/msm: Add support to create target specific address spaces drm/msm/gpu: Add ttbr0 to the memptrs drm/msm/a6xx: Support per-instance pagetables drm/msm/a5xx: Support per-instance pagetables drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 37 +++-- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 50 ++++-- drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 51 ++++-- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 163 ++++++++++++++++++- drivers/gpu/drm/msm/adreno/a5xx_gpu.h | 19 +++ drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 70 ++++++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 166 ++++++++++++++++++- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 7 - drivers/gpu/drm/msm/msm_drv.c | 25 ++- drivers/gpu/drm/msm/msm_drv.h | 5 + drivers/gpu/drm/msm/msm_gem.h | 2 + drivers/gpu/drm/msm/msm_gem_submit.c | 13 +- drivers/gpu/drm/msm/msm_gem_vma.c | 53 +++--- drivers/gpu/drm/msm/msm_gpu.c | 59 +------ drivers/gpu/drm/msm/msm_gpu.h | 3 + drivers/gpu/drm/msm/msm_iommu.c | 99 +++++++++++- drivers/gpu/drm/msm/msm_mmu.h | 4 + drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + drivers/iommu/arm-smmu.c | 176 ++++++++++++++++++-- drivers/iommu/io-pgtable-arm.c | 261 +++++++++++++++++++++++++++--- drivers/iommu/io-pgtable.c | 1 + include/linux/io-pgtable.h | 2 + include/linux/iommu.h | 2 + 24 files changed, 1082 insertions(+), 188 deletions(-) -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jordan Crouse Subject: [PATCH v3 00/16] drm/msm: Per-instance pagetable support Date: Wed, 29 May 2019 14:54:36 -0600 Message-ID: <1559163292-4792-1-git-send-email-jcrouse@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: freedreno@lists.freedesktop.org Cc: David Airlie , Will Deacon , dri-devel@lists.freedesktop.org, dianders@chromium.org, Wen Yang , Jonathan Marek , jean-philippe.brucker@arm.com, iommu@lists.linux-foundation.org, Mamta Shukla , Kees Cook , linux-arm-msm@vger.kernel.org, Sharat Masetty , Zhen Lei , Sean Paul , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hoegsberg@google.com, Thomas Zimmermann , Robin Murphy List-Id: dri-devel@lists.freedesktop.org VGhpcyBpcyB2MyBvZiB0aGUgcGVyLWluc3RhbmNlIHBhZ2V0YWJsZSBzdXBwb3J0LiBCaWdnZXN0 IGNoYW5nZSBpbiB0aGlzCnJldmlzaW9uIGlzIG1vdmluZyBuZWFybHkgYWxsIG9mIHRoZSBzcGxp dCBwYWdldGFibGUgc3VwcG9ydCBpbnRvCmlvLXBndGFibGUtYXJtIGFuZCBzZXR0aW5nIHVwIHNw ZWNpZmljIG9wcyB0byBoYW5kbGUgdGhlIHVuaXF1ZSBiZWhhdmlvcgpvZiB0aGUgc3BsaXQgcGFn ZXRhYmxlcy4gTm93IHRoYXQgSSd2ZSBzcGVudCBzb21lIHRpbWUgd2l0aCBpdCwgSSBsaWtlIGhv dwppdCB0dXJuZWQgb3V0LgoKRm9yIGJhY2tncm91bmQ6CgpQZXItaW5zdGFuY2UgcGFnZXRhYmxl cyBhbGxvdyB0aGUgdGFyZ2V0IEdQVSBkcml2ZXIgdG8gY3JlYXRlIGFuZCBtYW5hZ2UKYW4gaW5k aXZpZHVhbCBwYWdldGFibGUgZm9yIGVhY2ggZmlsZSBkZXNjcmlwdG9yIGluc3RhbmNlIGFuZCBz d2l0Y2gKYmV0d2VlbiB0aGVtIGFzeW5jaHJvbm91c2x5IHVzaW5nIHRoZSBHUFUgdG8gcmVwcm9n cmFtIHRoZSBwYWdldGFibGUKcmVnaXN0ZXJzIG9uIHRoZSBmbHkuCgpNb3N0IG9mIHRoZSBoZWF2 eSBsaWZ0aW5nIGZvciB0aGlzIGlzIGRvbmUgaW4gdGhlIGFybS1zbW11LXYyIGRyaXZlciBieQp0 YWtpbmcgYWR2YW50YWdlIG9mIHRoZSBuZXdseSBhZGRlZCBtdWx0aXBsZSBkb21haW4gQVBJLiBU aGUgZmlyc3QgcGF0Y2ggaW4gdGhlCnNlcmllcyBhbGxvd3Mgb3B0ZWQtaW4gY2xpZW50cyB0byBk aXJlY3QgbWFwIGEgZGV2aWNlIHdpdGgKaW9tbXVfcmVxdWVzdF9kbV9mb3JfZGV2KCkuIFRoaXMg YnlwYXNzZXMgdGhlIERNQSBkb21haW4gY3JlYXRpb24gaW4gdGhlIElPTU1VCmNvcmUgd2hpY2gg c2VydmVzIHNldmVyYWwgcHVycG9zZXMgZm9yIHRoZSBHUFUgYnkgc2tpcHBpbmcgdGhlIG90aGVy d2lzZSB1bnVzZWQKRE1BIGRvbWFpbiBhbmQgYWxzbyBrZWVwaW5nIGNvbnRleHQgYmFuayAwIHVu dXNlZCBvbiB0aGUgaGFyZHdhcmUgKGZvciBiZXR0ZXIgb3IKd29yc2UsIHRoZSBHUFUgaXMgaGFy ZGNvZGVkIHRvIG9ubHkgdXNlIGNvbnRleHQgYmFuayAwIGZvciBzd2l0Y2hpbmcpLgoKVGhlIG5l eHQgc2V2ZXJhbCBwYXRjaGVzIGVuYWJsZSBzcGxpdCBwYWdldGFibGUgc3VwcG9ydC4gVGhpcyBp cyB1c2VkIHRvIG1hcApnbG9iYWwgYnVmZmVycyBmb3IgdGhlIEdQVSBzbyB3ZSBjYW4gc2FmZWx5 IHN3aXRjaCB0aGUgVFRCUjAgcGFnZXRhYmxlIGZvciB0aGUKaW5zdGFuY2UuCgpUaGUgbGFzdCB0 d28gYXJtLXNtbXUtdjIgcGF0Y2hlcyBlbmFibGUgYXV4aWxsYXJ5IGRvbWFpbiBzdXBwb3J0LiBB Z2FpbiB0aGUKU01NVSBjbGllbnQgY2FuIG9wdC1pbiB0byBhbGxvdyBhdXhpbGlhcnkgZG9tYWlu cywgYW5kIGlmIGVuYWJsZWQgd2lsbCBjcmVhdGUKYSBwYWdldGFibGUgYnV0IG5vdCBvdGhlcndp c2UgdG91Y2ggdGhlIGhhcmR3YXJlLiBUaGUgY2xpZW50IGNhbiBnZXQgdGhlIGFkZHJlc3MKb2Yg dGhlIHBhZ2V0YWJsZSB0aHJvdWdoIGFuIGF0dHJpYnV0ZSB0byBwZXJmb3JtIGl0cyBvd24gc3dp dGNoaW5nLgoKQWZ0ZXIgdGhlIGFybS1zbW11LXYyIHBhdGNoZXMgYXJlIG1vcmUgdGhhbiBzZXZl cmFsIG1zbS9ncHUgcGF0Y2hlcyB0byBhbGxvdwpmb3IgdGFyZ2V0IHNwZWNpZmljIGFkZHJlc3Mg c3BhY2VzLCBlbmFibGUgNjQgYml0IHZpcnR1YWwgYWRkcmVzc2luZyBhbmQKaW1wbGVtZW50IHRo ZSBtZWNoYW5pY3Mgb2YgcGFnZXRhYmxlIHN3aXRjaGluZy4KCkZvciB0aGUgcHVycG9zZXMgb2Yg bWVyZ2luZyBhbGwgdGhlIHBhdGNoZXMgYmV0d2VlbgoKZHJtL21zbS9hZHJlbm86IEVuYWJsZSA2 NCBiaXQgbW9kZSBieSBkZWZhdWx0IG9uIGE1eHggYW5kIGE2eHggdGFyZ2V0cwoKYW5kCgpkcm0v bXNtOiBBZGQgc3VwcG9ydCB0byBjcmVhdGUgdGFyZ2V0IHNwZWNpZmljIGFkZHJlc3Mgc3BhY2Vz CgpjYW4gYmUgbWVyZ2VkIHRvIHRoZSBtc20tbmV4dCB0cmVlIHdpdGhvdXQgZGVwZW5kZW5jaWVz IG9uIHRoZSBJT01NVSBjaGFuZ2VzLgpPbmx5IHRoZSBsYXN0IHRocmVlIHBhdGNoZXMgd2lsbCBy ZXF1aXJlIGNvb3JkaW5hdGlvbiBiZXR3ZWVuIHRoZSB0d28gYXJlYXMuCgpKb3JkYW4gQ3JvdXNl ICgxNik6CiAgaW9tbXUvYXJtLXNtbXU6IEFsbG93IGNsaWVudCBkZXZpY2VzIHRvIHNlbGVjdCBk aXJlY3QgbWFwcGluZwogIGlvbW11OiBBZGQgRE9NQUlOX0FUVFJfU1BMSVRfVEFCTEVTCiAgaW9t bXUvaW8tcGd0YWJsZS1hcm06IEFkZCBzdXBwb3J0IGZvciBBQVJDSDY0IHNwbGl0IHBhZ2V0YWJs ZXMKICBpb21tdS9hcm0tc21tdTogQWRkIHN1cHBvcnQgZm9yIERPTUFJTl9BVFRSX1NQTElUX1RB QkxFUwogIGlvbW11OiBBZGQgRE9NQUlOX0FUVFJfUFRCQVNFCiAgaW9tbXUvYXJtLXNtbXU6IEFk ZCBhdXhpbGlhcnkgZG9tYWluIHN1cHBvcnQgZm9yIGFybS1zbW11djIKICBkcm0vbXNtL2FkcmVu bzogRW5hYmxlIDY0IGJpdCBtb2RlIGJ5IGRlZmF1bHQgb24gYTV4eCBhbmQgYTZ4eCB0YXJnZXRz CiAgZHJtL21zbTogUHJpbnQgYWxsIDY0IGJpdHMgb2YgdGhlIGZhdWx0aW5nIElPTU1VIGFkZHJl c3MKICBkcm0vbXNtOiBQYXNzIHRoZSBNTVUgZG9tYWluIGluZGV4IGluIHN0cnVjdCBtc21fZmls ZV9wcml2YXRlCiAgZHJtL21zbS9ncHU6IE1vdmUgYWRkcmVzcyBzcGFjZSBzZXR1cCB0byB0aGUg R1BVIHRhcmdldHMKICBkcm0vbXNtOiBBZGQgc3VwcG9ydCBmb3IgSU9NTVUgYXV4aWxpYXJ5IGRv bWFpbnMKICBkcm0vbXNtOiBBZGQgYSBoZWxwZXIgZnVuY3Rpb24gZm9yIGEgcGVyLWluc3RhbmNl IGFkZHJlc3Mgc3BhY2UKICBkcm0vbXNtOiBBZGQgc3VwcG9ydCB0byBjcmVhdGUgdGFyZ2V0IHNw ZWNpZmljIGFkZHJlc3Mgc3BhY2VzCiAgZHJtL21zbS9ncHU6IEFkZCB0dGJyMCB0byB0aGUgbWVt cHRycwogIGRybS9tc20vYTZ4eDogU3VwcG9ydCBwZXItaW5zdGFuY2UgcGFnZXRhYmxlcwogIGRy bS9tc20vYTV4eDogU3VwcG9ydCBwZXItaW5zdGFuY2UgcGFnZXRhYmxlcwoKIGRyaXZlcnMvZ3B1 L2RybS9tc20vYWRyZW5vL2EyeHhfZ3B1LmMgICAgIHwgIDM3ICsrKy0tCiBkcml2ZXJzL2dwdS9k cm0vbXNtL2FkcmVuby9hM3h4X2dwdS5jICAgICB8ICA1MCArKysrLS0KIGRyaXZlcnMvZ3B1L2Ry bS9tc20vYWRyZW5vL2E0eHhfZ3B1LmMgICAgIHwgIDUxICsrKystLQogZHJpdmVycy9ncHUvZHJt L21zbS9hZHJlbm8vYTV4eF9ncHUuYyAgICAgfCAxNjMgKysrKysrKysrKysrKysrKysrLQogZHJp dmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTV4eF9ncHUuaCAgICAgfCAgMTkgKysrCiBkcml2ZXJz L2dwdS9kcm0vbXNtL2FkcmVuby9hNXh4X3ByZWVtcHQuYyB8ICA3MCArKysrKystLQogZHJpdmVy cy9ncHUvZHJtL21zbS9hZHJlbm8vYTZ4eF9ncHUuYyAgICAgfCAxNjYgKysrKysrKysrKysrKysr KysrLQogZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYTZ4eF9ncHUuaCAgICAgfCAgIDEgKwog ZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8vYWRyZW5vX2dwdS5jICAgfCAgIDcgLQogZHJpdmVy cy9ncHUvZHJtL21zbS9tc21fZHJ2LmMgICAgICAgICAgICAgfCAgMjUgKystCiBkcml2ZXJzL2dw dS9kcm0vbXNtL21zbV9kcnYuaCAgICAgICAgICAgICB8ICAgNSArCiBkcml2ZXJzL2dwdS9kcm0v bXNtL21zbV9nZW0uaCAgICAgICAgICAgICB8ICAgMiArCiBkcml2ZXJzL2dwdS9kcm0vbXNtL21z bV9nZW1fc3VibWl0LmMgICAgICB8ICAxMyArLQogZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2Vt X3ZtYS5jICAgICAgICAgfCAgNTMgKysrLS0tCiBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9ncHUu YyAgICAgICAgICAgICB8ICA1OSArLS0tLS0tCiBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9ncHUu aCAgICAgICAgICAgICB8ICAgMyArCiBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9pb21tdS5jICAg ICAgICAgICB8ICA5OSArKysrKysrKysrKy0KIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX21tdS5o ICAgICAgICAgICAgIHwgICA0ICsKIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX3JpbmdidWZmZXIu aCAgICAgIHwgICAxICsKIGRyaXZlcnMvaW9tbXUvYXJtLXNtbXUuYyAgICAgICAgICAgICAgICAg IHwgMTc2ICsrKysrKysrKysrKysrKysrKy0tCiBkcml2ZXJzL2lvbW11L2lvLXBndGFibGUtYXJt LmMgICAgICAgICAgICB8IDI2MSArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0KIGRyaXZl cnMvaW9tbXUvaW8tcGd0YWJsZS5jICAgICAgICAgICAgICAgIHwgICAxICsKIGluY2x1ZGUvbGlu dXgvaW8tcGd0YWJsZS5oICAgICAgICAgICAgICAgIHwgICAyICsKIGluY2x1ZGUvbGludXgvaW9t bXUuaCAgICAgICAgICAgICAgICAgICAgIHwgICAyICsKIDI0IGZpbGVzIGNoYW5nZWQsIDEwODIg aW5zZXJ0aW9ucygrKSwgMTg4IGRlbGV0aW9ucygtKQoKLS0gCjIuNy40CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=