From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCHv2 2/5] ARM: dts: Add rotator node for exynos4210 Date: Fri, 09 Aug 2013 14:56:36 +0200 Message-ID: <1559260.ljnrQXSjF1@amdc1227> References: <1376034053-31910-1-git-send-email-chanho61.park@samsung.com> <1376034053-31910-3-git-send-email-chanho61.park@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:50124 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757403Ab3HIM4k (ORCPT ); Fri, 9 Aug 2013 08:56:40 -0400 In-reply-to: <1376034053-31910-3-git-send-email-chanho61.park@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Chanho Park Cc: inki.dae@samsung.com, kgene.kim@samsung.com, dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com, mark.rutland@arm.com, l.stach@pengutronix.de, s.nawrocki@samsung.com, tomasz.figa@gmail.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Thomas Abraham On Friday 09 of August 2013 16:40:50 Chanho Park wrote: > This patch adds a rotator node for exynos4210. The exynos4210 has > different limitation of image size compared with later chips. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi > b/arch/arm/boot/dts/exynos4.dtsi index 597cfcf..002b2b8 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -243,6 +243,15 @@ > status = "disabled"; > }; > > + rotator: rotator@12810000 { > + compatible = "samsung,exynos4210-rotator"; > + reg = <0x12810000 0x1000>; > + interrupts = <0 83 0>; > + clocks = <&clock 278>; > + clock-names = "rotator"; > + status = "disabled"; Does the rotator need any board-specific information to work? If no, it should not be disabled by default. Same comment goes to patch 4/5. Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Fri, 09 Aug 2013 14:56:36 +0200 Subject: [PATCHv2 2/5] ARM: dts: Add rotator node for exynos4210 In-Reply-To: <1376034053-31910-3-git-send-email-chanho61.park@samsung.com> References: <1376034053-31910-1-git-send-email-chanho61.park@samsung.com> <1376034053-31910-3-git-send-email-chanho61.park@samsung.com> Message-ID: <1559260.ljnrQXSjF1@amdc1227> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 09 of August 2013 16:40:50 Chanho Park wrote: > This patch adds a rotator node for exynos4210. The exynos4210 has > different limitation of image size compared with later chips. > > Signed-off-by: Chanho Park > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Inki Dae > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi > b/arch/arm/boot/dts/exynos4.dtsi index 597cfcf..002b2b8 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -243,6 +243,15 @@ > status = "disabled"; > }; > > + rotator: rotator at 12810000 { > + compatible = "samsung,exynos4210-rotator"; > + reg = <0x12810000 0x1000>; > + interrupts = <0 83 0>; > + clocks = <&clock 278>; > + clock-names = "rotator"; > + status = "disabled"; Does the rotator need any board-specific information to work? If no, it should not be disabled by default. Same comment goes to patch 4/5. Best regards, Tomasz