From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4978BC04AB5 for ; Thu, 6 Jun 2019 22:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24D4120868 for ; Thu, 6 Jun 2019 22:45:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbfFFWpZ (ORCPT ); Thu, 6 Jun 2019 18:45:25 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51204 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726567AbfFFWpZ (ORCPT ); Thu, 6 Jun 2019 18:45:25 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x56Mg7e2011147 for ; Thu, 6 Jun 2019 18:45:24 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2sya7y43s6-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 06 Jun 2019 18:45:23 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Jun 2019 23:45:22 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 6 Jun 2019 23:45:20 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x56MjDHZ29557022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Jun 2019 22:45:13 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75F6242080; Thu, 6 Jun 2019 22:45:19 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B56C34207E; Thu, 6 Jun 2019 22:45:18 +0000 (GMT) Received: from dhcp-9-31-103-88.watson.ibm.com (unknown [9.31.103.88]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 6 Jun 2019 22:45:18 +0000 (GMT) Subject: Re: [PATCH V4] IMA: Allow profiles to define the desired IMA template From: Mimi Zohar To: Roberto Sassu , Matthew Garrett Cc: linux-integrity , Mimi Zohar , prakhar srivastava , Thiago Jung Bauermann Date: Thu, 06 Jun 2019 18:45:18 -0400 In-Reply-To: <40275b34-c86e-7550-9eec-78a2b1d316f7@huawei.com> References: <20190604203859.181156-1-matthewgarrett@google.com> <1559691534.4278.14.camel@linux.ibm.com> <1559761830.4278.30.camel@linux.ibm.com> <40275b34-c86e-7550-9eec-78a2b1d316f7@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19060622-0012-0000-0000-000003260150 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19060622-0013-0000-0000-0000215EEAA2 Message-Id: <1559861118.4278.182.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-06_15:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=988 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906060154 Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Thu, 2019-06-06 at 10:09 +0200, Roberto Sassu wrote: > On 6/5/2019 9:10 PM, Mimi Zohar wrote: > > On Wed, 2019-06-05 at 11:12 -0700, Matthew Garrett wrote: > >> On Tue, Jun 4, 2019 at 4:39 PM Mimi Zohar wrote: > >>> Matthew, what is a "profile"? Could we rename this patch to something > >>> clearer? Maybe something like "support for per policy rule template > >>> formats"? > >> > >> Sounds good to me. Could you also add an Inspired-By: Roberto Sassu > >> ? > > > > Thanks, done. > > Thanks Matthew. > > If the patch it is not merged yet, please define and initialize the > template_name variable in ima_policy_show() as the same as in > ima_measurement_show(). The policy rule processing should prevent loading a custom policy with a template rule, without specifying a valid template name.  Why does ima_policy_show() need to initialize entry->template->name? Mimi