From: "Fang Hongjie(方洪杰)" <hongjiefang@asrmicro.com>
To: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Cc: "shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"wsa+renesas@sang-engineering.com"
<wsa+renesas@sang-engineering.com>,
"bst@pengutronix.de" <bst@pengutronix.de>,
"chanho.min@lge.com" <chanho.min@lge.com>,
"kyle.roeschley@ni.com" <kyle.roeschley@ni.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es
Date: Tue, 24 Jul 2018 05:49:34 +0000 [thread overview]
Message-ID: <155c45c3b69d487ab204398becdaf677@mail2012.asrmicro.com> (raw)
In-Reply-To: <1531818865-7387-1-git-send-email-hongjiefang@asrmicro.com>
> mmc_select_hs400es() calls mmc_select_bus_width() which will continue
> to set 4bit transfer mode if fail to set 8bit mode. The bus width
> should not be set to 4bit in HS400es.
>
> When fail to set 8bit mode, need return error directly for HS400es.
>
> Signed-off-by: Hongjie Fang <hongjiefang@asrmicro.com>
> ---
> drivers/mmc/core/mmc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 4466f5d..0dbc512 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1338,8 +1338,12 @@ static int mmc_select_hs400es(struct mmc_card *card)
> goto out_err;
>
> err = mmc_select_bus_width(card);
> - if (err < 0)
> + if (err != MMC_BUS_WIDTH_8) {
> + pr_err("%s: switch to 8bit bus width failed, err:%d\n",
> + mmc_hostname(host), err);
> + err = -EIO;
> goto out_err;
> + }
>
> /* Switch card to HS mode */
> err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> --
> 1.9.1
Ping.
Any suggestion for it?
B&R
Hongjie
next prev parent reply other threads:[~2018-07-24 5:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 9:14 [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es Hongjie Fang
2018-07-17 9:14 ` Hongjie Fang
2018-07-24 5:49 ` Fang Hongjie(方洪杰) [this message]
2018-07-30 15:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155c45c3b69d487ab204398becdaf677@mail2012.asrmicro.com \
--to=hongjiefang@asrmicro.com \
--cc=adrian.hunter@intel.com \
--cc=bst@pengutronix.de \
--cc=chanho.min@lge.com \
--cc=kyle.roeschley@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.