From: Oscar Salvador <osalvador@suse.de>
To: Yang Shi <yang.shi@linux.alibaba.com>,
ying.huang@intel.com, hannes@cmpxchg.org, mhocko@suse.com,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
josef@toxicpanda.com, hughd@google.com, shakeelb@google.com,
hdanton@sina.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [v7 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned
Date: Mon, 10 Jun 2019 23:36:55 +0200 [thread overview]
Message-ID: <1560202615.3312.6.camel@suse.de> (raw)
In-Reply-To: <1559025859-72759-1-git-send-email-yang.shi@linux.alibaba.com>
On Tue, 2019-05-28 at 14:44 +0800, Yang Shi wrote:
> The commit 9092c71bb724 ("mm: use sc->priority for slab shrink
> targets")
> has broken up the relationship between sc->nr_scanned and slab
> pressure.
> The sc->nr_scanned can't double slab pressure anymore. So, it sounds
> no
> sense to still keep sc->nr_scanned inc'ed. Actually, it would
> prevent
> from adding pressure on slab shrink since excessive sc->nr_scanned
> would
> prevent from scan->priority raise.
Hi Yang,
I might be misunderstanding this, but did you mean "prevent from scan-
priority decreasing"?
I guess we are talking about balance_pgdat(), and in case
kswapd_shrink_node() returns true (it means we have scanned more than
we had to reclaim), raise_priority becomes false, and this does not let
sc->priority to be decreased, which has the impact that less pages will
be reclaimed the next round.
Sorry for bugging here, I just wanted to see if I got this right.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2019-06-10 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 6:44 [v7 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned Yang Shi
2019-05-28 6:44 ` [v7 PATCH 2/2] mm: vmscan: correct some vmscan counters for THP swapout Yang Shi
2019-05-29 0:57 ` Huang, Ying
2019-06-10 21:36 ` Oscar Salvador [this message]
2019-06-11 17:12 ` [v7 PATCH 1/2] mm: vmscan: remove double slab pressure by inc'ing sc->nr_scanned Yang Shi
2019-06-11 17:17 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560202615.3312.6.camel@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=hughd@google.com \
--cc=josef@toxicpanda.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.