From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Alexey Brodkin , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 4/4 v2] drm: rcar-du - use generic drm_connector_register_all() helper Date: Mon, 21 Mar 2016 15:26:45 +0200 Message-ID: <1560693.4UujGVhTuc@avalon> In-Reply-To: <1458563320-30541-5-git-send-email-abrodkin@synopsys.com> References: <1458563320-30541-1-git-send-email-abrodkin@synopsys.com> <1458563320-30541-5-git-send-email-abrodkin@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Alexey, Thank you for the patch. On Monday 21 Mar 2016 15:28:40 Alexey Brodkin wrote: > Now when generic drm_connector_register_all() helper exists we may safely s/Now when/Now that a/ > substiture with it driver-specific implementation of connectors plugging in s/substiture with it/substitute it for the/ > sysfs. And while at it, in the subject line, s/rcar-du - use/rcar-du: Use/ > Signed-off-by: Alexey Brodkin > Cc: Daniel Vetter > Cc: David Airlie > Cc: Laurent Pinchart > Cc: linux-renesas-soc@vger.kernel.org Apart for the commit message fixes, Acked-by: Laurent Pinchart > --- > > No changes v1 -> v2. > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 644db36..0f251dc 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -361,14 +361,7 @@ static int rcar_du_probe(struct platform_device *pdev) > if (ret) > goto error; > > - mutex_lock(&ddev->mode_config.mutex); > - drm_for_each_connector(connector, ddev) { > - ret = drm_connector_register(connector); > - if (ret < 0) > - break; > - } > - mutex_unlock(&ddev->mode_config.mutex); > - > + ret = drm_connector_register_all(ddev); > if (ret < 0) > goto error; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/4 v2] drm: rcar-du - use generic drm_connector_register_all() helper Date: Mon, 21 Mar 2016 15:26:45 +0200 Message-ID: <1560693.4UujGVhTuc@avalon> References: <1458563320-30541-1-git-send-email-abrodkin@synopsys.com> <1458563320-30541-5-git-send-email-abrodkin@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 661706E5BC for ; Mon, 21 Mar 2016 13:26:37 +0000 (UTC) In-Reply-To: <1458563320-30541-5-git-send-email-abrodkin@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Alexey Brodkin , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgQWxleGV5LAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb25kYXkgMjEgTWFyIDIw MTYgMTU6Mjg6NDAgQWxleGV5IEJyb2RraW4gd3JvdGU6Cj4gTm93IHdoZW4gZ2VuZXJpYyBkcm1f Y29ubmVjdG9yX3JlZ2lzdGVyX2FsbCgpIGhlbHBlciBleGlzdHMgd2UgbWF5IHNhZmVseQoKcy9O b3cgd2hlbi9Ob3cgdGhhdCBhLwoKPiBzdWJzdGl0dXJlIHdpdGggaXQgZHJpdmVyLXNwZWNpZmlj IGltcGxlbWVudGF0aW9uIG9mIGNvbm5lY3RvcnMgcGx1Z2dpbmcgaW4KCnMvc3Vic3RpdHVyZSB3 aXRoIGl0L3N1YnN0aXR1dGUgaXQgZm9yIHRoZS8KCj4gc3lzZnMuCgpBbmQgd2hpbGUgYXQgaXQs IGluIHRoZSBzdWJqZWN0IGxpbmUsCgpzL3JjYXItZHUgLSB1c2UvcmNhci1kdTogVXNlLwoKPiBT aWduZWQtb2ZmLWJ5OiBBbGV4ZXkgQnJvZGtpbiA8YWJyb2RraW5Ac3lub3BzeXMuY29tPgo+IENj OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWly bGllZEBsaW51eC5pZT4KPiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBp ZGVhc29uYm9hcmQuY29tPgo+IENjOiBsaW51eC1yZW5lc2FzLXNvY0B2Z2VyLmtlcm5lbC5vcmcK CkFwYXJ0IGZvciB0aGUgY29tbWl0IG1lc3NhZ2UgZml4ZXMsCgpBY2tlZC1ieTogTGF1cmVudCBQ aW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAKPiBO byBjaGFuZ2VzIHYxIC0+IHYyLgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2Rydi5jIHwgOSArLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA4 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9y Y2FyX2R1X2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jIGlu ZGV4IDY0NGRiMzYuLjBmMjUxZGMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXIt ZHUvcmNhcl9kdV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVf ZHJ2LmMKPiBAQCAtMzYxLDE0ICszNjEsNyBAQCBzdGF0aWMgaW50IHJjYXJfZHVfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWlmIChyZXQpCj4gIAkJZ290byBlcnJvcjsK PiAKPiAtCW11dGV4X2xvY2soJmRkZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKPiAtCWRybV9mb3Jf ZWFjaF9jb25uZWN0b3IoY29ubmVjdG9yLCBkZGV2KSB7Cj4gLQkJcmV0ID0gZHJtX2Nvbm5lY3Rv cl9yZWdpc3Rlcihjb25uZWN0b3IpOwo+IC0JCWlmIChyZXQgPCAwKQo+IC0JCQlicmVhazsKPiAt CX0KPiAtCW11dGV4X3VubG9jaygmZGRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+IC0KPiArCXJl dCA9IGRybV9jb25uZWN0b3JfcmVnaXN0ZXJfYWxsKGRkZXYpOwo+ICAJaWYgKHJldCA8IDApCj4g IAkJZ290byBlcnJvcjsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==