diff for duplicates of <1560769988.5187.20.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 7d5971d..aca817a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,28 +1,36 @@ -T24gTW9uLCAyMDE5LTA2LTE3IGF0IDIzOjAxICsxMjAwLCBLYWkgSHVhbmcgd3JvdGU6DQo+IE9u -IE1vbiwgMjAxOS0wNi0xNyBhdCAxMTozMCArMDIwMCwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6DQo+ -ID4gT24gU2F0LCBKdW4gMTUsIDIwMTkgYXQgMDE6NDQ6NDNBTSArMDMwMCwgS2lyaWxsIEEuIFNo -dXRlbW92IHdyb3RlOg0KPiA+ID4gT24gRnJpLCBKdW4gMTQsIDIwMTkgYXQgMDE6MTI6NTlQTSAr -MDIwMCwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6DQo+ID4gPiA+IE9uIFdlZCwgTWF5IDA4LCAyMDE5 -IGF0IDA1OjQzOjQwUE0gKzAzMDAsIEtpcmlsbCBBLiBTaHV0ZW1vdiB3cm90ZToNCj4gPiA+ID4g -PiBwYWdlX2tleWlkKCkgaXMgaW5saW5lIGZ1bmNhdGlvbiB0aGF0IHVzZXMgbG9va3VwX3BhZ2Vf -ZXh0KCkuIEtWTSBpcw0KPiA+ID4gPiA+IGdvaW5nIHRvIHVzZSBwYWdlX2tleWlkKCkgYW5kIHNp -bmNlIEtWTSBjYW4gYmUgYnVpbHQgYXMgYSBtb2R1bGUNCj4gPiA+ID4gPiBsb29rdXBfcGFnZV9l -eHQoKSBoYXMgdG8gYmUgZXhwb3J0ZWQuDQo+ID4gPiA+IA0KPiA+ID4gPiBJIF9yZWFsbHlfIGhh -dGUgaGF2aW5nIHRvIGV4cG9ydCB3b3JsZCtkb2cgZm9yIEtWTS4gVGhpcyBvbmUgbWlnaHQgbm90 -DQo+ID4gPiA+IGJlIGEgcmVhbCBpc3N1ZSwgYnV0IEkgaXRjaCBldmVyeSB0aW1lIEkgc2VlIGFu -IGV4cG9ydCBmb3IgS1ZNIHRoZXNlDQo+ID4gPiA+IGRheXMuDQo+ID4gPiANCj4gPiA+IElzIHRo -ZXJlIGFueSBiZXR0ZXIgd2F5PyBEbyB3ZSBuZWVkIHRvIGludmVudCBFWFBPUlRfU1lNQk9MX0tW -TSgpPyA6UA0KPiA+IA0KPiA+IE9yIGRpc2FsbG93IEtWTSAob3IgcGFydHMgdGhlcmVvZikgZnJv -bSBiZWluZyBhIG1vZHVsZSBhbnltb3JlLg0KPiANCj4gRm9yIHRoaXMgcGFydGljdWxhciBzeW1i -b2wgZXhwb3NlLCBJIGRvbid0IHRoaW5rIGl0cyBmYWlyIHRvIGJsYW1lIEtWTSBzaW5jZSB0aGUg -ZnVuZGFtZW50YWwNCj4gcmVhc29uDQo+IGlzIGJlY2F1c2UgcGFnZV9rZXlpZCgpICh3aGljaCBj -YWxscyBsb29rdXBfcGFnZV9leHQoKSkgYmVpbmcgaW1wbGVtZW50ZWQgYXMgc3RhdGljIGlubGlu -ZQ0KPiBmdW5jdGlvbg0KPiBpbiBoZWFkZXIgZmlsZSwgc28gZXNzZW50aWFsbHkgaGF2aW5nIGFu -eSBvdGhlciBtb2R1bGUgd2hvIGNhbGxzIHBhZ2Vfa2V5aWQoKSB3aWxsIHRyaWdnZXIgdGhpcw0K -PiBwcm9ibGVtIC0tIGluIGZhY3QgSU9NTVUgZHJpdmVyIGNhbGxzIHBhZ2Vfa2V5aWQoKSB0b28g -c28gZXZlbiB3L28gS1ZNIGxvb2t1cF9wYWdlX2V4dCgpIG5lZWRzIHRvDQo+IGJlDQo+IGV4cG9z -ZWQuDQoNCk9vcHMgaXQgc2VlbXMgSW50ZWwgSU9NTVUgZHJpdmVyIGlzIG5vdCBhIG1vZHVsZSBi -dXQgYnVpbGRpbiBzbyB5ZXMgS1ZNIGlzIHRoZSBvbmx5IG1vZHVsZSB3aG8gY2FsbHMNCnBhZ2Vf -a2V5aWQoKSBub3cuIFNvcnJ5IG15IGJhZC4gQnV0IGlmIHRoZXJlJ3MgYW55IG90aGVyIG1vZHVs -ZSBjYWxscyBwYWdlX2tleWlkKCksIHRoaXMgcGF0Y2ggaXMNCnJlcXVpcmVkLg0KDQpUaGFua3Ms -DQotS2FpDQo+IA0KPiBUaGFua3MsDQo+IC1LYWkNCj4g +On Mon, 2019-06-17 at 23:01 +1200, Kai Huang wrote: +> On Mon, 2019-06-17 at 11:30 +0200, Peter Zijlstra wrote: +> > On Sat, Jun 15, 2019 at 01:44:43AM +0300, Kirill A. Shutemov wrote: +> > > On Fri, Jun 14, 2019 at 01:12:59PM +0200, Peter Zijlstra wrote: +> > > > On Wed, May 08, 2019 at 05:43:40PM +0300, Kirill A. Shutemov wrote: +> > > > > page_keyid() is inline funcation that uses lookup_page_ext(). KVM is +> > > > > going to use page_keyid() and since KVM can be built as a module +> > > > > lookup_page_ext() has to be exported. +> > > > +> > > > I _really_ hate having to export world+dog for KVM. This one might not +> > > > be a real issue, but I itch every time I see an export for KVM these +> > > > days. +> > > +> > > Is there any better way? Do we need to invent EXPORT_SYMBOL_KVM()? :P +> > +> > Or disallow KVM (or parts thereof) from being a module anymore. +> +> For this particular symbol expose, I don't think its fair to blame KVM since the fundamental +> reason +> is because page_keyid() (which calls lookup_page_ext()) being implemented as static inline +> function +> in header file, so essentially having any other module who calls page_keyid() will trigger this +> problem -- in fact IOMMU driver calls page_keyid() too so even w/o KVM lookup_page_ext() needs to +> be +> exposed. + +Oops it seems Intel IOMMU driver is not a module but buildin so yes KVM is the only module who calls +page_keyid() now. Sorry my bad. But if there's any other module calls page_keyid(), this patch is +required. + +Thanks, +-Kai +> +> Thanks, +> -Kai +> diff --git a/a/content_digest b/N1/content_digest index e2f42c6..4557b55 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -30,33 +30,41 @@ " Alison <alison.schofield@intel.com>\0" "\00:1\0" "b\0" - "T24gTW9uLCAyMDE5LTA2LTE3IGF0IDIzOjAxICsxMjAwLCBLYWkgSHVhbmcgd3JvdGU6DQo+IE9u\n" - "IE1vbiwgMjAxOS0wNi0xNyBhdCAxMTozMCArMDIwMCwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6DQo+\n" - "ID4gT24gU2F0LCBKdW4gMTUsIDIwMTkgYXQgMDE6NDQ6NDNBTSArMDMwMCwgS2lyaWxsIEEuIFNo\n" - "dXRlbW92IHdyb3RlOg0KPiA+ID4gT24gRnJpLCBKdW4gMTQsIDIwMTkgYXQgMDE6MTI6NTlQTSAr\n" - "MDIwMCwgUGV0ZXIgWmlqbHN0cmEgd3JvdGU6DQo+ID4gPiA+IE9uIFdlZCwgTWF5IDA4LCAyMDE5\n" - "IGF0IDA1OjQzOjQwUE0gKzAzMDAsIEtpcmlsbCBBLiBTaHV0ZW1vdiB3cm90ZToNCj4gPiA+ID4g\n" - "PiBwYWdlX2tleWlkKCkgaXMgaW5saW5lIGZ1bmNhdGlvbiB0aGF0IHVzZXMgbG9va3VwX3BhZ2Vf\n" - "ZXh0KCkuIEtWTSBpcw0KPiA+ID4gPiA+IGdvaW5nIHRvIHVzZSBwYWdlX2tleWlkKCkgYW5kIHNp\n" - "bmNlIEtWTSBjYW4gYmUgYnVpbHQgYXMgYSBtb2R1bGUNCj4gPiA+ID4gPiBsb29rdXBfcGFnZV9l\n" - "eHQoKSBoYXMgdG8gYmUgZXhwb3J0ZWQuDQo+ID4gPiA+IA0KPiA+ID4gPiBJIF9yZWFsbHlfIGhh\n" - "dGUgaGF2aW5nIHRvIGV4cG9ydCB3b3JsZCtkb2cgZm9yIEtWTS4gVGhpcyBvbmUgbWlnaHQgbm90\n" - "DQo+ID4gPiA+IGJlIGEgcmVhbCBpc3N1ZSwgYnV0IEkgaXRjaCBldmVyeSB0aW1lIEkgc2VlIGFu\n" - "IGV4cG9ydCBmb3IgS1ZNIHRoZXNlDQo+ID4gPiA+IGRheXMuDQo+ID4gPiANCj4gPiA+IElzIHRo\n" - "ZXJlIGFueSBiZXR0ZXIgd2F5PyBEbyB3ZSBuZWVkIHRvIGludmVudCBFWFBPUlRfU1lNQk9MX0tW\n" - "TSgpPyA6UA0KPiA+IA0KPiA+IE9yIGRpc2FsbG93IEtWTSAob3IgcGFydHMgdGhlcmVvZikgZnJv\n" - "bSBiZWluZyBhIG1vZHVsZSBhbnltb3JlLg0KPiANCj4gRm9yIHRoaXMgcGFydGljdWxhciBzeW1i\n" - "b2wgZXhwb3NlLCBJIGRvbid0IHRoaW5rIGl0cyBmYWlyIHRvIGJsYW1lIEtWTSBzaW5jZSB0aGUg\n" - "ZnVuZGFtZW50YWwNCj4gcmVhc29uDQo+IGlzIGJlY2F1c2UgcGFnZV9rZXlpZCgpICh3aGljaCBj\n" - "YWxscyBsb29rdXBfcGFnZV9leHQoKSkgYmVpbmcgaW1wbGVtZW50ZWQgYXMgc3RhdGljIGlubGlu\n" - "ZQ0KPiBmdW5jdGlvbg0KPiBpbiBoZWFkZXIgZmlsZSwgc28gZXNzZW50aWFsbHkgaGF2aW5nIGFu\n" - "eSBvdGhlciBtb2R1bGUgd2hvIGNhbGxzIHBhZ2Vfa2V5aWQoKSB3aWxsIHRyaWdnZXIgdGhpcw0K\n" - "PiBwcm9ibGVtIC0tIGluIGZhY3QgSU9NTVUgZHJpdmVyIGNhbGxzIHBhZ2Vfa2V5aWQoKSB0b28g\n" - "c28gZXZlbiB3L28gS1ZNIGxvb2t1cF9wYWdlX2V4dCgpIG5lZWRzIHRvDQo+IGJlDQo+IGV4cG9z\n" - "ZWQuDQoNCk9vcHMgaXQgc2VlbXMgSW50ZWwgSU9NTVUgZHJpdmVyIGlzIG5vdCBhIG1vZHVsZSBi\n" - "dXQgYnVpbGRpbiBzbyB5ZXMgS1ZNIGlzIHRoZSBvbmx5IG1vZHVsZSB3aG8gY2FsbHMNCnBhZ2Vf\n" - "a2V5aWQoKSBub3cuIFNvcnJ5IG15IGJhZC4gQnV0IGlmIHRoZXJlJ3MgYW55IG90aGVyIG1vZHVs\n" - "ZSBjYWxscyBwYWdlX2tleWlkKCksIHRoaXMgcGF0Y2ggaXMNCnJlcXVpcmVkLg0KDQpUaGFua3Ms\n" - DQotS2FpDQo+IA0KPiBUaGFua3MsDQo+IC1LYWkNCj4g + "On Mon, 2019-06-17 at 23:01 +1200, Kai Huang wrote:\n" + "> On Mon, 2019-06-17 at 11:30 +0200, Peter Zijlstra wrote:\n" + "> > On Sat, Jun 15, 2019 at 01:44:43AM +0300, Kirill A. Shutemov wrote:\n" + "> > > On Fri, Jun 14, 2019 at 01:12:59PM +0200, Peter Zijlstra wrote:\n" + "> > > > On Wed, May 08, 2019 at 05:43:40PM +0300, Kirill A. Shutemov wrote:\n" + "> > > > > page_keyid() is inline funcation that uses lookup_page_ext(). KVM is\n" + "> > > > > going to use page_keyid() and since KVM can be built as a module\n" + "> > > > > lookup_page_ext() has to be exported.\n" + "> > > > \n" + "> > > > I _really_ hate having to export world+dog for KVM. This one might not\n" + "> > > > be a real issue, but I itch every time I see an export for KVM these\n" + "> > > > days.\n" + "> > > \n" + "> > > Is there any better way? Do we need to invent EXPORT_SYMBOL_KVM()? :P\n" + "> > \n" + "> > Or disallow KVM (or parts thereof) from being a module anymore.\n" + "> \n" + "> For this particular symbol expose, I don't think its fair to blame KVM since the fundamental\n" + "> reason\n" + "> is because page_keyid() (which calls lookup_page_ext()) being implemented as static inline\n" + "> function\n" + "> in header file, so essentially having any other module who calls page_keyid() will trigger this\n" + "> problem -- in fact IOMMU driver calls page_keyid() too so even w/o KVM lookup_page_ext() needs to\n" + "> be\n" + "> exposed.\n" + "\n" + "Oops it seems Intel IOMMU driver is not a module but buildin so yes KVM is the only module who calls\n" + "page_keyid() now. Sorry my bad. But if there's any other module calls page_keyid(), this patch is\n" + "required.\n" + "\n" + "Thanks,\n" + "-Kai\n" + "> \n" + "> Thanks,\n" + "> -Kai\n" + > -dfbe365b3cfdfb632289de0904d89a0196e52350506dc1fabc8b576947f7f342 +59bd74683c83b944056b4f1cc05af3e552637631d188ff2301f1bef301617ba2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.