All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: ath11k@lists.infradead.org
Subject: [PATCH 2/5] ath11k: this statement may fall through [-Wimplicit-fallthrough=]
Date: Mon, 17 Jun 2019 19:32:56 +0300	[thread overview]
Message-ID: <1560789179-3857-2-git-send-email-kvalo@codeaurora.org> (raw)
In-Reply-To: <1560789179-3857-1-git-send-email-kvalo@codeaurora.org>

With W=1 GCC warns:

drivers/net/wireless/ath/ath11k/core.c:757:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
vers/net/wireless/ath/ath11k/mac.c:1332:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
drivers/net/wireless/ath/ath11k/dp.c:133:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/core.c | 1 +
 drivers/net/wireless/ath/ath11k/dp.c   | 1 +
 drivers/net/wireless/ath/ath11k/mac.c  | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index be4f86a0f83b..26fdcb161965 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -755,6 +755,7 @@ static void ath11k_core_restart(struct work_struct *work)
 			break;
 		case ATH11K_STATE_RESTARTED:
 			ar->state = ATH11K_STATE_WEDGED;
+			/* fall through */
 		case ATH11K_STATE_WEDGED:
 			ath11k_warn(sc,
 				    "device is wedged, will not restart radio %d\n", i);
diff --git a/drivers/net/wireless/ath/ath11k/dp.c b/drivers/net/wireless/ath/ath11k/dp.c
index 0aec840fc360..be10e98b0bcd 100644
--- a/drivers/net/wireless/ath/ath11k/dp.c
+++ b/drivers/net/wireless/ath/ath11k/dp.c
@@ -138,6 +138,7 @@ int ath11k_dp_srng_setup(struct ath11k_base *ab, struct dp_srng *ring,
 			break;
 		}
 		/* follow through when ring_num >= 3 */
+		/* fall through */
 	case HAL_REO_EXCEPTION:
 	case HAL_REO_REINJECT:
 	case HAL_REO_CMD:
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index ab71e121e107..fd133813636e 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -1330,7 +1330,7 @@ static void ath11k_peer_assoc_h_he(struct ath11k *ar,
 		arg->peer_he_tx_mcs_set[WMI_HECAP_TXRX_MCS_NSS_IDX_160] = v;
 
 		arg->peer_he_mcs_count++;
-		/* drop through */
+		/* fall through */
 
 	default:
 		v = le16_to_cpu(he_cap->he_mcs_nss_supp.rx_mcs_80);
-- 
2.7.4


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2019-06-17 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 16:32 [PATCH 1/5] ath11k: 'static' is not at beginning of declaration [-Wold-style-declaration] Kalle Valo
2019-06-17 16:32 ` Kalle Valo [this message]
2019-06-17 16:32 ` [PATCH 3/5] ath11k: variable set but not used [-Wunused-but-set-variable] Kalle Valo
2019-06-17 16:32 ` [PATCH 4/5] ath11k: comparison is always true due to limited range of data type [-Wtype-limits] Kalle Valo
2019-06-17 16:32 ` [PATCH 5/5] ath11k: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Kalle Valo
2019-06-18 12:26 ` [PATCH 1/5] ath11k: 'static' is not at beginning of declaration [-Wold-style-declaration] Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560789179-3857-2-git-send-email-kvalo@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.