From: Mimi Zohar <zohar@linux.ibm.com>
To: Sven Van Asbroeck <thesven73@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>
Cc: Stable <stable@vger.kernel.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: improve LSM/IMA security behaviour
Date: Mon, 17 Jun 2019 14:34:02 -0400 [thread overview]
Message-ID: <1560796442.4072.170.camel@linux.ibm.com> (raw)
In-Reply-To: <20190617182354.10846-1-TheSven73@gmail.com>
On Mon, 2019-06-17 at 14:23 -0400, Sven Van Asbroeck wrote:
> The firmware loader queries if LSM/IMA permits it to load firmware
> via the sysfs fallback. Unfortunately, the code does the opposite:
> it expressly permits sysfs fw loading if security_kernel_load_data(
> LOADING_FIRMWARE) returns -EACCES. This happens because a
> zero-on-success return value is cast to a bool that's true on success.
>
> Fix the return value handling so we get the correct behaviour.
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
prev parent reply other threads:[~2019-06-17 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 18:23 [PATCH] firmware: improve LSM/IMA security behaviour Sven Van Asbroeck
2019-06-17 18:34 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560796442.4072.170.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.