All of lore.kernel.org
 help / color / mirror / Atom feed
From: Venkateswara Naralasetty <vnaralas@codeaurora.org>
To: ath11k@lists.infradead.org
Cc: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Subject: [PATCH] ath11k: add wrapper function to ath11k_dbg
Date: Tue, 18 Jun 2019 16:22:32 +0530	[thread overview]
Message-ID: <1560855152-2609-1-git-send-email-vnaralas@codeaurora.org> (raw)

This patch define a macro for ath11k_dbg() which improves
the Rx performance by avoid calling ath11k_dbg() from
ath11k_dp_rx_deliver_msdu() when no dbg_mask set.

Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
---
v2:
 * corrected one style issue

 drivers/net/wireless/ath/ath11k/debug.c |  6 +++---
 drivers/net/wireless/ath/ath11k/debug.h | 18 ++++++++++++------
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c
index 69a2340..6e16c29 100644
--- a/drivers/net/wireless/ath/ath11k/debug.c
+++ b/drivers/net/wireless/ath/ath11k/debug.c
@@ -53,8 +53,8 @@ void ath11k_warn(struct ath11k_base *sc, const char *fmt, ...)
 }
 
 #ifdef CONFIG_ATH11K_DEBUG
-void ath11k_dbg(struct ath11k_base *ab, enum ath11k_debug_mask mask,
-		const char *fmt, ...)
+void __ath11k_dbg(struct ath11k_base *ab, enum ath11k_debug_mask mask,
+		  const char *fmt, ...)
 {
 	struct va_format vaf;
 	va_list args;
@@ -83,7 +83,7 @@ void ath11k_dbg_dump(struct ath11k_base *ab,
 
 	if (ath11k_debug_mask & mask) {
 		if (msg)
-			ath11k_dbg(ab, mask, "%s\n", msg);
+			__ath11k_dbg(ab, mask, "%s\n", msg);
 
 		for (ptr = buf; (ptr - buf) < len; ptr += 16) {
 			linebuflen = 0;
diff --git a/drivers/net/wireless/ath/ath11k/debug.h b/drivers/net/wireless/ath/ath11k/debug.h
index 5774f53..ebc807e 100644
--- a/drivers/net/wireless/ath/ath11k/debug.h
+++ b/drivers/net/wireless/ath/ath11k/debug.h
@@ -106,17 +106,17 @@ __printf(2, 3) void ath11k_warn(struct ath11k_base *sc, const char *fmt, ...);
 extern unsigned int ath11k_debug_mask;
 
 #ifdef CONFIG_ATH11K_DEBUG
-__printf(3, 4) void ath11k_dbg(struct ath11k_base *ab,
-			       enum ath11k_debug_mask mask,
-			       const char *fmt, ...);
+__printf(3, 4) void __ath11k_dbg(struct ath11k_base *ab,
+				 enum ath11k_debug_mask mask,
+				 const char *fmt, ...);
 void ath11k_dbg_dump(struct ath11k_base *ab,
 		     enum ath11k_debug_mask mask,
 		     const char *msg, const char *prefix,
 		     const void *buf, size_t len);
 #else /* CONFIG_ATH11K_DEBUG */
-static inline int ath11k_dbg(struct ath11k_base *ab,
-			     enum ath11k_debug_mask dbg_mask,
-			     const char *fmt, ...)
+static inline int __ath11k_dbg(struct ath11k_base *ab,
+			       enum ath11k_debug_mask dbg_mask,
+			       const char *fmt, ...)
 {
 	return 0;
 }
@@ -272,4 +272,10 @@ static inline void ath11k_sta_update_rx_duration(struct ath11k *ar,
 
 #endif /* CONFIG_MAC80211_DEBUGFS*/
 
+#define ath11k_dbg(ar, dbg_mask, fmt, ...)			\
+do {								\
+	if (ath11k_debug_mask & dbg_mask)			\
+		__ath11k_dbg(ar, dbg_mask, fmt, ##__VA_ARGS__);	\
+} while (0)
+
 #endif /* _ATH11K_DEBUG_H_ */
-- 
2.7.4


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

             reply	other threads:[~2019-06-18 10:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 10:52 Venkateswara Naralasetty [this message]
2019-06-18 12:51 ` [PATCH] ath11k: add wrapper function to ath11k_dbg Kalle Valo
2019-06-20 13:40 ` Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2019-06-18 10:46 Venkateswara Naralasetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560855152-2609-1-git-send-email-vnaralas@codeaurora.org \
    --to=vnaralas@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.