From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH] drm/imx: correct order of crtc disable Date: Thu, 20 Jun 2019 13:50:31 +0200 Message-ID: <1561031431.14349.13.camel@pengutronix.de> References: <20190618155003.18499-1-bob.beckett@collabora.com> <1560937217.2398.1.camel@pengutronix.de> <4fceab36a9d800249b66bfd37114d63fc3386d29.camel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1E5D6E3B8 for ; Thu, 20 Jun 2019 11:50:33 +0000 (UTC) In-Reply-To: <4fceab36a9d800249b66bfd37114d63fc3386d29.camel@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Robert Beckett , Daniel Vetter Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org SGkgUm9iZXJ0LCBEYW5pZWwsCgpPbiBUaHUsIDIwMTktMDYtMjAgYXQgMTI6MTIgKzAxMDAsIFJv YmVydCBCZWNrZXR0IHdyb3RlOgo+IE9uIFRodSwgMjAxOS0wNi0yMCBhdCAxMDo1MCArMDIwMCwg RGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIFdlZCwgSnVuIDE5LCAyMDE5IGF0IDExOjQwIEFN IFBoaWxpcHAgWmFiZWwgPAo+ID4gcC56YWJlbEBwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4gPiA+ IAo+ID4gPiBIaSBSb2JlcnQsCj4gPiA+IAo+ID4gPiB0aGFuayB5b3UgZm9yIHRoZSBwYXRjaC4K PiA+ID4gCj4gPiA+IE9uIFR1ZSwgMjAxOS0wNi0xOCBhdCAxNjo1MCArMDEwMCwgUm9iZXJ0IEJl Y2tldHQgd3JvdGU6Cj4gPiA+ID4gTm90aWZ5IGRybSBjb3JlIGJlZm9yZSBzZW5kaW5nIHBlbmRp bmcgZXZlbnRzIGR1cmluZyBjcnRjCj4gPiA+ID4gZGlzYWJsZS4KPiA+ID4gPiBUaGlzIGZpeGVz IHRoZSBmaXJzdCBldmVudCBhZnRlciBkaXNhYmxlIGhhdmluZyBhbiBvbGQgc3RhbGUKPiA+ID4g PiB0aW1lc3RhbXAKPiA+ID4gPiBieSBoYXZpbmcgZHJtX2NydGNfdmJsYW5rX29mZiB1cGRhdGUg dGhlIHRpbWVzdGFtcCB0byBub3cuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyB3YXMgc2VlbiB3aGls ZSBkZWJ1Z2dpbmcgd2VzdG9uIGxvZyBtZXNzYWdlOgo+ID4gPiA+IFdhcm5pbmc6IGNvbXB1dGVk IHJlcGFpbnQgZGVsYXkgaXMgaW5zYW5lOiAtODIxMiBtc2VjCj4gPiA+ID4gCj4gPiA+IAo+ID4g PiBXb3VsZCB5b3Ugc2F5IHRoaXMKPiA+ID4gRml4ZXM6IGE0NzQ0Nzg2NDJkNSAoImRybS9pbXg6 IGZpeCBjcnRjIHZibGFuayBzdGF0ZSByZWdyZXNzaW9uIikKPiA+ID4gPwo+ID4gPiAKPiA+ID4g PiBTaWduZWQtb2ZmLWJ5OiBSb2JlcnQgQmVja2V0dCA8Ym9iLmJlY2tldHRAY29sbGFib3JhLmNv bT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2lteC9pcHV2My1jcnRjLmMg fCA2ICsrKy0tLQo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aW14L2lwdXYzLWNydGMuYwo+ID4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2lteC9pcHV2My1jcnRj LmMKPiA+ID4gPiBpbmRleCA5Y2MxZDY3ODY3NGYuLmM0MzZhMjhkNTBlNCAxMDA2NDQKPiA+ID4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaW14L2lwdXYzLWNydGMuYwo+ID4gPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pbXgvaXB1djMtY3J0Yy5jCj4gPiA+ID4gQEAgLTkxLDE0ICs5MSwxNCBA QCBzdGF0aWMgdm9pZCBpcHVfY3J0Y19hdG9taWNfZGlzYWJsZShzdHJ1Y3QKPiA+ID4gPiBkcm1f Y3J0YyAqY3J0YywKPiA+ID4gPiAgICAgICBpcHVfZGNfZGlzYWJsZShpcHUpOwo+ID4gPiA+ICAg ICAgIGlwdV9wcmdfZGlzYWJsZShpcHUpOwo+ID4gPiA+IAo+ID4gPiA+ICsgICAgIGRybV9jcnRj X3ZibGFua19vZmYoY3J0Yyk7Cj4gPiA+ID4gKwo+ID4gPiAKPiA+ID4gVGhpcyBpcyBleHBsYWlu ZWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIGFuZCBhbGlnbnMgd2l0aCB0aGUKPiA+ID4gZHJtX2Ny dGNfc3RhdGUgQGV2ZW50IGRvY3VtZW50YXRpb24uCj4gPiAKPiA+IFRoaXMgcGFydCBoZXJlIGxv b2tzIGZpc2h5LiBUaGUgZHJtX3ZibGFuay5jIGNvZGUgaXMgc3VwcG9zZWQgdG8gZG8KPiA+IHRo ZSByaWdodCB0aGluZywgbm8gbWF0dGVyIHdoZXJlIG9yIHdoZW4geW91IGFzayBpdCB0byBnZW5l cmF0ZSBhbgo+ID4gZXZlbnQuIEl0IGRlZmluaXRlbHkgc2hvdWxkbid0IGdlbmVyYXRlIGEgdGlt ZXN0YW1wIHRoYXQncyBhIGZldwo+ID4gc2Vjb25kcyB0b28gZWFybHkuIEJ1bmNoIG9mIG9wdGlv bnM6Cj4gPiAtIHRoZXJlJ3MgYSBidWcgaW4gZHJtX3ZibGFuay5jIGFuZCBpdCdzIG1peGluZyB1 cCBzb21ldGhpbmcgYW5kCj4gPiBnZW5lcmF0aW5nIGEgdG90YWxseSBib2d1cyB2YWx1ZS4KPiA+ IC0gdGhlcmUncyBhIGxpZSBpbiB5b3VyIGlteCB2YmxhbmsgY29kZSwgd2hpY2ggdHJpcHMgdGhl IGRybV92YmxhbmsuYwo+ID4gY291bnRlciBpbnRlcnBvbGF0aW9uIGFuZCByZXN1bHRzIGluIGEg dG90YWxseSBib2d1cyB2YWx1ZS4KPiA+IAo+ID4gZHJtX3ZibGFuay5jIGFzc3VtZXMgdGhhdCBp ZiB5b3UgZG8gY2xhaW0gdG8gaGF2ZSBhIGh3IGNvdW50ZXIgYW5kCj4gPiBnZW5lcmF0ZSB0aW1l c3RhbXBzLCB0aGF0IHRob3NlIGFyZSBwZXJmZWN0bHkgYWNjdXJhdGUuIEl0IG9ubHkgZmFsbHMK PiA+IGJhY2sgdG8gZ3Vlc3RpbWF0aW5nIHVzaW5nIHRoZSBzeXN0ZW0gdGltZXIgaWYgdGhhdCdz IG5vdCBwcmVzZW50Lgo+ID4gCj4gPiBFaXRoZXIgd2F5LCB0aGlzIHZlcnkgbXVjaCBzbWVsbHMg bGlrZSBwYXBlcmluZyBvdmVyIGEgYnVnIGlmIHRoaXMKPiA+IGNoYW5nZSBpbmRlZWQgZml4ZXMg eW91ciB3cm9uZyB2YmxhbmsgdGltZXN0YW1wcy4KClRoYW5rIHlvdSBmb3IgY2hpbWluZyBpbiwg SSBjYW4gY29uZmlybSB0aGF0IGp1c3QgbW92aW5nIHRoZQpkcm1fY3J0Y192Ymxhbmtfb2ZmIGFy b3VuZCBkb2VzIG5vdCBjaGFuZ2UgYW55dGhpbmcuCkknbGwgZHJvcCB0aGlzIHBhdGNoIGFuZCB3 YWl0IGZvciB2My4KCj4gQSBxdWljayBleHBsYWluYXRpb24gb2Ygd2hlcmUgdGhlIGRvZGd5IHRp bWVzdGFtcCBjYW1lIGZyb206Cj4gMS4gZHJpdmVyIHN0YXJ0cyB1cAo+IDIuIGZiY29uIGNvbWVz IGFsb25nIGFuZCByZXN0b3JlcyBmYmRldiwgZW5hYmxpbmcgdmJsYW5rCj4gMy4gdmJsYW5rX2Rp c2FibGVfZm4gZmlyZXMgdmlhIHRpbWVyIGRpc2FibGluZyB2YmxhbmssIGtlZXBpbmcgdmJsYW5r Cj4gc2VxIG51bWJlciBhbmQgdGltZSBzZXQgYXQgY3VycmVudCB2YWx1ZQo+IChzb21lIHRpbWUg bGF0ZXIpCj4gNC4gd2VzdG9uIHN0YXJ0cyBhbmQgZG9lcyBhIG1vZGVzZXQKPiA1LiBhdG9taWMg Y29tbWl0IGRpc2FibGVzIGNydGMgd2hpbGUgaXQgZG9lcyB0aGUgbW9kZXNldAo+IDYuIGlwdV9j cnRjX2F0b21pY19kaXNhYmxlIHNlbmRzIHZibGFuayB3aXRoIG9sZCBzZXEgbnVtYmVyIGFuZCB0 aW1lCgpJdCB3b3VsZCBiZSBncmVhdCB0byBoYXZlIHRoaXMgaW4gdGhlIGNvbW1pdCBtZXNzYWdl IGZvciBjb250ZXh0LgoKPiBJdCB0dXJucyBvdXQgdGhlIGFjdHVhbCBmaXggZm9yIHRoZSBvbGQg dmJsYW5rIGlzIHRoZSBuZXh0IGNoYW5nZSwKPiB3aGljaCBzdG9wcyBpdCBiZWluZyBzZW50IGF0 IGFsbCBkdXJpbmcgdGhlIGNydGMgZGlzYWJsZSBhcyBpdCBpcyBpcwo+IHN0aWxsIGFjdGl2ZSwg aXQgd291bGQgdGhlbiBnbyB0aHJvdWdoIGRybV9jcnRjX3ZibGFua19vZmYsIHJlc2V0aW5nCj4g dGhlIHRpbWVzdGFtcCwgYW5kIGdldCBkZWxpdmVyZWQgZHVyaW5nIHRoZSB2YmxhbmsgZW5hYmxl IGFzIHBhcnQgb2YKPiB0aGUgYXRvbWljIGNvbW1pdC4KCldoaWNoIG1lYW5zIHRoaXMgcGF0Y2gg aXNuJ3QgIkZpeGVzOiBhNDc0NDc4NjQyZDUiIGFmdGVyIGFsbC4KVGhlIG9mZmVuZGluZyBjb2Rl IGhhcyBiZWVuIHRoZXJlIHNpbmNlIGNvbW1pdCA1ZjJmOTExNTc4ZmIgKCJkcm0vaW14OgphdG9t aWMgcGhhc2UgMyBzdGVwIDE6IFVzZSBhdG9taWMgY29uZmlndXJhdGlvbiIpLgoKPiBTbywgaW4g dGhlb3J5LCB3ZSBjb3VsZCBqdXN0IGhhdmUgdGhlIGZvbGxvd2luZyBjaGFuZ2UgdG8gZml4IHRo ZQo+IHNwZWNpZmljIGlzc3VlIG9mIGEgc3RhbGUgdGltZXN0YW1wLgo+Cj4gSG93ZXZlciwgZ2l2 ZW4gdGhlIGRvY3VtZW50YXRpb24gZm9yIHRoZSBldmVudCBpbgo+IGluY2x1ZGUvZHJtL2RybV9j cnRjLmg6Cj4gCj4gICAgICAgICAgKiAgLSBUaGUgZXZlbnQgaXMgZm9yIGEgQ1JUQyB3aGljaCBp cyBiZWluZyBkaXNhYmxlZCB0aHJvdWdoIHRoaXMKPiAgICAgICAgICAqICAgIGF0b21pYyBjb21t aXQuIEluIHRoYXQgY2FzZSB0aGUgZXZlbnQgY2FuIGJlIHNlbmQgb3V0IGFueSB0aW1lCj4gICAg ICAgICAgKiAgICBhZnRlciB0aGUgaGFyZHdhcmUgaGFzIHN0b3BwZWQgc2Nhbm5pbmcgb3V0IHRo ZSBjdXJyZW50IAo+ICAgICAgICAgICogICAgZnJhbWVidWZmZXJzLiBJdCBzaG91bGQgY29udGFp biB0aGUgdGltZXN0YW1wIGFuZCBjb3VudGVyIGZvciB0aGUKPiAgICAgICAgICAqICAgIGxhc3Qg dmJsYW5rIGJlZm9yZSB0aGUgZGlzcGxheSBwaXBlbGluZSB3YXMgc2h1dCBvZmYuIFRoZSBzaW1w bGVzdAo+ICAgICAgICAgICogICAgd2F5IHRvIGFjaGlldmUgdGhhdCBpcyBjYWxsaW5nIGRybV9j cnRjX3NlbmRfdmJsYW5rX2V2ZW50KCkKPiAgICAgICAgICAqICAgIHNvbWV3aGVuIGFmdGVyIGRy bV9jcnRjX3ZibGFua19vZmYoKSBoYXMgYmVlbiBjYWxsZWQuCj4gCj4gVGhpcyBzdGlsbCBzZWVt cyBsaWtlIGEgc2Vuc2libGUgY2hhbmdlIGZvciB3aGVuIHRoZSBjcnRjIGlzIGJlaW5nCj4gZGlz YWJsZWQuCgpUaGlzIGlzIHdoYXQgaGFkIG1lIGNvbmZ1c2VkIGFzIHdlbGwuIEl0IGRvZXNuJ3Qg cmVhbGx5IHNheSwgYnV0IGl0CnNlZW1zIHRvIGltcGx5IHRoYXQgZHJtX2NydGNfc2VuZF92Ymxh bmtfZXZlbnQgbXVzdCBvbmx5IGJlIHNlbnQgYWZ0ZXIKZHJtX2NydGNfdmJsYW5rX29mZi4KSWYg dGhpcyBpcyBub3QgYSBoYXJkIHJlcXVpcmVtZW50LCBtYXliZSB0aGlzIGNvdWxkIGJlIG1lbnRp b25lZCBoZXJlPwoKPiA+ID4gPiAgICAgICBzcGluX2xvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50 X2xvY2spOwo+ID4gPiA+IC0gICAgIGlmIChjcnRjLT5zdGF0ZS0+ZXZlbnQpCj4gPiA+ID4gewo+ ID4gPiA+ICsgICAgIGlmIChjcnRjLT5zdGF0ZS0+ZXZlbnQgJiYgIWNydGMtPnN0YXRlLT5hY3Rp dmUpIHsKPiA+ID4gCj4gPiA+IFRoaXMgaXMgbm90IG1lbnRpb25lZCB0aG91Z2guCj4gPiA+IAo+ ID4gPiBJZiB0aGUgcGVuZGluZyBldmVudCBpcyBub3Qgc2VudCBoZXJlLCBJIGFzc3VtZSBpdCB3 aWxsIGJlIHBpY2tlZAo+ID4gPiB1cCBieQo+ID4gPiAuYXRvbWljX2ZsdXNoIGFuZCB3aWxsIHRo ZW4gYmUgc2VudCBhZnRlciB0aGUgZmlyc3QgRU9GIGludGVycnVwdAo+ID4gPiBhZnRlcgo+ID4g PiB0aGUgbW9kZXNldCBpcyBjb21wbGV0ZS4gQ2FuIHlvdSBleHBsYWluIHRoaXMgaW4gdGhlIGNv bW1pdAo+ID4gPiBtZXNzYWdlPwo+ID4gCj4gPiBZZWFoIGxvb2tzIGNvcnJlY3QgKHlvdSBvbmx5 IHdhbnQgdG8gZ2VuZXJhdGUgdGhlIGV2ZW50IGhlcmUgd2hlbiB0aGUKPiA+IGNydGMgc3RheXMg b2ZmKSwgaWYgaXQgZ2V0cyByZS1lbmFibGVkIHRoZSBldmVudCBzaG91bGQgb25seSBiZQo+ID4g Z2VuZXJhdGVkIGxhdGVyIG9uIG9uY2UgdGhhdCdzIGFsbCBmaW5pc2hlZC4gQnV0IHNlcGFyYXRl IGJ1Z2ZpeC4KPiA+IC1EYW5pZWwKPiA+IAo+IAo+IEl0IGxvb2tzIGxpa2UgdGhpcyBpcyBhY3R1 YWxseSB0aGUgZml4IG5lZWRlZCB0byBhdm9pZCB0aGUgYm9ndXMKPiB0aW1lc3RhbXAuCj4gCj4g SSBjYW4gc3BsaXQgdGhpcyBwYXRjaCB1cCBpbiB0byAyIGNvbW1pdHMgaWYgZGVzaXJlZD8KClll cywgcGxlYXNlLiBUaGUgIXN0YXRlLT5hY3RpdmUgZml4IGlzIHN0YWJsZSBtYXRlcmlhbCwgbW92 aW5nCmRybV9jcnRjX3ZibGFua19vZmYgYXJvdW5kIGFwcGFyZW50bHkgbm90IHNvIG11Y2guCgpy ZWdhcmRzClBoaWxpcHAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs