From: Mimi Zohar <zohar@linux.ibm.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v5 06/11] ima-evm-utils: Start converting find_keyid to use EVP_PKEY API
Date: Thu, 20 Jun 2019 09:21:49 -0400 [thread overview]
Message-ID: <1561036909.4525.29.camel@linux.ibm.com> (raw)
In-Reply-To: <20190620010713.wfmkjkf3fprgc3h6@altlinux.org>
Hi Vitaly,
> > > > If so, why are there other changes in this patch?
> > >
> > > There is no other changes beside stated in description.
> >
> > Are the changes from read_pub_key() to read_pub_pkey() and
> > calc_keyid_v2() to calc_pkeyid_v2() needed for making find_keyid() a
> > wrapper for find_keyid_pkey()?
>
> Of course. `entry->key' now have different type. If we keep old type
> (RSA) where will be nothing to wrap.
The question wasn't if the changes in init_public_keys() need to be
made, the question is its correlation to find_keyid(). Unlesss I'm
missing something, find_keyid() is only called by verify_hash_v2(),
not calc_keyid_v2().
Mimi
next prev parent reply other threads:[~2019-06-20 13:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 13:56 [PATCH v5 00/11] ima-evm-utils: Convert sign v2 from RSA to EVP_PKEY API Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 01/11] ima-evm-utils: Make sure sig buffer is always MAX_SIGNATURE_SIZE Vitaly Chikunov
2019-06-20 21:42 ` Mimi Zohar
2019-06-21 6:59 ` Vitaly Chikunov
2019-06-21 11:08 ` Mimi Zohar
2019-06-21 11:22 ` Vitaly Chikunov
2019-06-21 11:27 ` Mimi Zohar
2019-06-21 12:28 ` Vitaly Chikunov
2019-06-21 13:03 ` Mimi Zohar
2019-06-23 8:36 ` Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 02/11] ima-evm-utils: Change read_pub_key to use EVP_PKEY API Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 03/11] ima-evm-utils: Change read_priv_key " Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 04/11] ima-evm-utils: Start converting calc keyid v2 to " Vitaly Chikunov
2019-06-19 11:56 ` Mimi Zohar
2019-06-18 13:56 ` [PATCH v5 05/11] ima-evm-utils: Convert cmd_import to use " Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 06/11] ima-evm-utils: Start converting find_keyid " Vitaly Chikunov
2019-06-19 12:26 ` Mimi Zohar
2019-06-19 15:43 ` Vitaly Chikunov
2019-06-19 16:46 ` Mimi Zohar
2019-06-20 1:07 ` Vitaly Chikunov
2019-06-20 13:21 ` Mimi Zohar [this message]
2019-06-20 13:40 ` Mimi Zohar
2019-06-20 14:23 ` Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 07/11] ima-evm-utils: Convert verify_hash_v2 to " Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 08/11] ima-evm-utils: Finish conversion of find_keyid " Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 09/11] ima-evm-utils: Convert sign_hash_v2 to use " Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 10/11] ima-evm-utils: Finish converting calc keyid v2 to " Vitaly Chikunov
2019-06-18 13:56 ` [PATCH v5 11/11] ima-evm-utils: Remove RSA_ASN1_templates Vitaly Chikunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561036909.4525.29.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=vt@altlinux.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.