All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gix, Brian" <brian.gix@intel.com>
To: "michal.lowas-rzechonek@silvair.com" 
	<michal.lowas-rzechonek@silvair.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Cc: "Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH BlueZ 2/3] mesh: Add DevKeySend call
Date: Fri, 28 Jun 2019 14:33:14 +0000	[thread overview]
Message-ID: <1561732393.7802.50.camel@intel.com> (raw)
In-Reply-To: <20190628132932.bhcvcx4tzlfkertu@mlowasrzechonek2133>


Hi Michał,

On Fri, 2019-06-28 at 15:29 +0200, Michał Lowas-Rzechonek wrote:
> Hi,
> 
> On 06/28, Michał Lowas-Rzechonek wrote:
> > +	if (!l_dbus_message_get_arguments(msg, "oqqay", &ele_path, &dst,
> > +							&net_idx, &iter_data))
> > +		return dbus_error(msg, MESH_ERROR_INVALID_ARGS, NULL);
> 
> I have a question here: what's the idea behind net_index argument in
> this API? There is no such argument in regular Send() call, and I don't

Unlike App Keys, Device keys do not have a bound Net Key...  They can be sent on *any* network key.  So while
sending a message on a specific App index implies the Net Key to use, the Dev Key send does not, and so needs
it to be explicit.



> quite get why.
> 
> regards

  reply	other threads:[~2019-06-28 14:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 12:52 [PATCH BlueZ 0/3] Add support for remote dev keys Michał Lowas-Rzechonek
2019-06-28 12:52 ` [PATCH BlueZ 1/3] mesh: Rename APP_IDX_DEV to APP_IDX_DEV_LOCAL, add APP_IDX_DEV_REMOTE Michał Lowas-Rzechonek
2019-06-28 12:52 ` [PATCH BlueZ 2/3] mesh: Add DevKeySend call Michał Lowas-Rzechonek
2019-06-28 13:29   ` Michał Lowas-Rzechonek
2019-06-28 14:33     ` Gix, Brian [this message]
2019-06-28 17:18       ` michal.lowas-rzechonek
2019-07-01 20:00       ` michal.lowas-rzechonek
2019-07-01 20:08         ` Gix, Brian
2019-07-01 20:14           ` michal.lowas-rzechonek
2019-06-28 12:52 ` [PATCH BlueZ 3/3] mesh: Handle messages encrypted with a remote dev key Michał Lowas-Rzechonek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1561732393.7802.50.camel@intel.com \
    --to=brian.gix@intel.com \
    --cc=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=michal.lowas-rzechonek@silvair.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.