From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Cercueil Subject: Re: [PATCH 1/3] DRM: ingenic: Use devm_platform_ioremap_resource Date: Sun, 30 Jun 2019 13:09:09 +0200 Message-ID: <1561892949.1773.0@crapouillou.net> References: <20190627182114.27299-1-paul@crapouillou.net> <20190630081833.GC5081@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190630081833.GC5081@ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org To: Sam Ravnborg Cc: David Airlie , Daniel Vetter , od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Le dim. 30 juin 2019 =E0 10:18, Sam Ravnborg a =E9crit=20 : > Hi Paul. >=20 > On Thu, Jun 27, 2019 at 08:21:12PM +0200, Paul Cercueil wrote: >> Simplify a bit the probe function by using the newly introduced >> devm_platform_ioremap_resource(), instead of having to call >> platform_get_resource() followed by devm_ioremap_resource(). >>=20 >> Signed-off-by: Paul Cercueil >> --- >> drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >>=20 >> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c=20 >> b/drivers/gpu/drm/ingenic/ingenic-drm.c >> index a069579ca749..02c4788ef1c7 100644 >> --- a/drivers/gpu/drm/ingenic/ingenic-drm.c >> +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c >> @@ -580,7 +580,6 @@ static int ingenic_drm_probe(struct=20 >> platform_device *pdev) >> struct drm_bridge *bridge; >> struct drm_panel *panel; >> struct drm_device *drm; >> - struct resource *mem; >> void __iomem *base; >> long parent_rate; >> int ret, irq; >> @@ -614,8 +613,7 @@ static int ingenic_drm_probe(struct=20 >> platform_device *pdev) >> drm->mode_config.max_height =3D 600; >> drm->mode_config.funcs =3D &ingenic_drm_mode_config_funcs; >>=20 >> - mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - base =3D devm_ioremap_resource(dev, mem); >> + base =3D devm_platform_ioremap_resource(pdev, 0); >> if (IS_ERR(base)) { >> dev_err(dev, "Failed to get memory resource"); > Consider to include the error code in the error message here. I don't think it's needed; a non-zero error code in the probe function=20 will have the drivers core automatically print a message with the name of the failing driver and the return code. >> return PTR_ERR(base); >=20 > With the above fixed/considered: > Reviewed-by: Sam Ravnborg =