From: Oliver Neukum <oneukum@suse.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Tejun Heo <tj@kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [RFC] deadlock with flush_work() in UAS
Date: Mon, 01 Jul 2019 13:02:27 +0200 [thread overview]
Message-ID: <1561978947.10014.12.camel@suse.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1906261036550.1550-100000@iolanthe.rowland.org>
Am Mittwoch, den 26.06.2019, 10:38 -0400 schrieb Alan Stern:
> On Wed, 26 Jun 2019, Oliver Neukum wrote:
>
> > Am Montag, den 24.06.2019, 10:22 -0400 schrieb Alan Stern:
> > > But that pattern makes no sense; a driver would never use it. The
> > > driver would just do the reset itself.
> >
> > Correct. But UAS and storage themselves still need to use
> > WQ_MEM_RECLAIM for their workqueues, don't they?
>
> Perhaps so for uas. usb-storage uses a work queue only for scanning
> targets, which doesn't interfere with the block I/O pathway.
Are you sure? What about hub_tt_work? As far as I can tell, hub_quiesce
will flush it, hence it is used in error handling.
Regards
Oliver
next prev parent reply other threads:[~2019-07-01 11:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 14:53 [RFC] deadlock with flush_work() in UAS Oliver Neukum
2019-06-18 15:29 ` Alan Stern
2019-06-18 15:29 ` Oliver Neukum
2019-06-18 15:59 ` Alan Stern
2019-06-20 14:10 ` Tejun Heo
2019-06-24 8:56 ` Oliver Neukum
2019-06-24 14:22 ` Alan Stern
2019-06-26 8:10 ` Oliver Neukum
2019-06-26 14:38 ` Alan Stern
2019-07-01 11:02 ` Oliver Neukum [this message]
2019-07-01 14:20 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561978947.10014.12.camel@suse.com \
--to=oneukum@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.