All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gix, Brian" <brian.gix@intel.com>
To: "jakub.witowski@silvair.com" <jakub.witowski@silvair.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Cc: "Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH] mesh: Clear nodes queue on get_managed_objects_cb() fails
Date: Mon, 1 Jul 2019 16:07:08 +0000	[thread overview]
Message-ID: <1561997227.458.1.camel@intel.com> (raw)
In-Reply-To: <20190628095049.10595-1-jakub.witowski@silvair.com>

Hi Jakub,

I am applying this, but please in the future subject tag your BlueZ mesh patches as [PATCH BlueZ <...>] so that
they are easier to spot.

On Fri, 2019-06-28 at 11:50 +0200, Jakub Witowski wrote:
> Currently when the get_managed_objects_cb() fails it frees
> the node resources but the node still remains on the "nodes" queue.
> 
> This implementation calls node_remove() instead of
> free_node_resources()."
> ---
>  mesh/node.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mesh/node.c b/mesh/node.c
> index 4e35bb3ff..2229aa711 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -1601,7 +1601,7 @@ fail:
>  	} else {
>  		/* Handle failed Join and Create requests */
>  		if (node)
> -			free_node_resources(node);
> +			node_remove(node);
>  
>  		if (req->type == REQUEST_TYPE_JOIN) {
>  			node_join_ready_func_t cb = req->cb;

      reply	other threads:[~2019-07-01 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  9:50 [PATCH] mesh: Clear nodes queue on get_managed_objects_cb() fails Jakub Witowski
2019-07-01 16:07 ` Gix, Brian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1561997227.458.1.camel@intel.com \
    --to=brian.gix@intel.com \
    --cc=inga.stotland@intel.com \
    --cc=jakub.witowski@silvair.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.