From: Oliver Neukum <oneukum@suse.com>
To: JC Kuo <jckuo@nvidia.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: usb-storage@lists.one-eyed-alien.net, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: storage: skip only when uas driver is loaded
Date: Tue, 02 Jul 2019 08:53:43 +0200 [thread overview]
Message-ID: <1562050423.5819.1.camel@suse.com> (raw)
In-Reply-To: <8e8e8703-8620-b625-4917-bbb8d999caa4@nvidia.com>
Am Dienstag, den 02.07.2019, 10:36 +0800 schrieb JC Kuo:
> An user might want to completely disable uas for some reason so he/she adds "blacklist uas" to modprobe conf file. I think in case of this, usb-storage driver has to enable this device with the legacy Bulk-only protocol instead of ignoring the device.
>
> As an alternative to this patch, I thought I could get uas driver loaded before usb-storage driver so I tried moving the functions in drivers/usb/storage/uas-detect.h into uas.c and letting usb-storage links uas_use_uas_driver() of uas.ko. However, that didn't work because uas driver actually depends on usb-storage driver for usb_stor_adjust_quirks(). There will be a recursive dependency.
>
> Please let me know if there is better approach to avoid the issue.
Use US_FL_IGNORE_UAS. You can trigger this with a module parameter.
We cannot just use another driver because the user block a module
load.
Regards
Oliver
prev parent reply other threads:[~2019-07-02 7:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 8:48 [PATCH] usb: storage: skip only when uas driver is loaded JC Kuo
2019-07-01 8:52 ` Greg KH
2019-07-02 2:36 ` JC Kuo
2019-07-02 4:42 ` Greg KH
2019-07-02 5:29 ` JC Kuo
2019-07-02 6:56 ` JC Kuo
2019-07-02 7:34 ` Greg KH
2019-07-02 7:57 ` JC Kuo
2019-07-02 8:14 ` Greg KH
2019-07-02 9:11 ` Oliver Neukum
2019-07-02 14:05 ` JC Kuo
2019-07-02 15:29 ` Oliver Neukum
2019-07-02 6:53 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1562050423.5819.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.