Re: [dpdk-stable] [PATCH v3] kni: fix build with gcc 8.1

[Thomas Monjalon <thomas@monjalon.net>]

26/06/2018 15:43, De Lara Guarch, Pablo:
> 
> > Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is
> > enabled.
> > 
> > build error:
> > In function ‘strncpy’,
> >     inlined from ‘igb_get_drvinfo’ at
> >     .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2:
> >     .../include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output
> >     may be truncated copying 31 bytes from a string of length 42
> >     [-Werror=stringop-truncation]
> >       return __builtin_strncpy(p, q, size);
> >                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Fixed by using strlcpy instead of strncpy.
> > 
> > adapter->fw_version size kept same because of
> > c3698192940c ("kni: fix build with gcc 7.1")
> > 
> > Also next line strncpy usage replaced with strlcpy while arround.
> > 
> > Fixes: c3698192940c ("kni: fix build with gcc 7.1")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks