From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 1/2] drivers: add common folder
Date: Tue, 27 Mar 2018 18:11:13 +0200
Message-ID: <1562446.8uNvKBYxys@xps>
References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>
 <20180326075344.2209-1-pbhagavatula@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
 santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com,
 lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com,
 shreyansh.jain@nxp.com, hemant.agrawal@nxp.com
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 40AA02B9C
 for <dev@dpdk.org>; Tue, 27 Mar 2018 18:11:30 +0200 (CEST)
In-Reply-To: <20180326075344.2209-1-pbhagavatula@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/03/2018 09:53, Pavan Nikhilesh:
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -3,18 +3,19 @@
> 
>  include $(RTE_SDK)/mk/rte.vars.mk
> 
> +DIRS-y += common
>  DIRS-y += bus
>  DIRS-y += mempool
> -DEPDIRS-mempool := bus
> +DEPDIRS-mempool := bus common
>  DIRS-y += net
> -DEPDIRS-net := bus mempool
> +DEPDIRS-net := bus common mempool
>  DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += bbdev
> -DEPDIRS-bbdev := bus mempool
> +DEPDIRS-bbdev := bus common mempool
>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
> -DEPDIRS-crypto := bus mempool
> +DEPDIRS-crypto := bus common mempool
>  DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
> -DEPDIRS-event := bus mempool net
> +DEPDIRS-event := bus common mempool net
>  DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw
> -DEPDIRS-raw := bus mempool net event
> +DEPDIRS-raw := bus common mempool net event

> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -2,11 +2,12 @@
>  # Copyright(c) 2017 Intel Corporation
> 
>  # Defines the order in which the drivers are buit.
> -driver_classes = ['bus',
> -	       'mempool', # depends on bus.
> -	       'net',     # depends on bus and mempool.
> -	       'crypto',  # depenss on bus, mempool (net in future).
> -	       'event']   # depends on bus, mempool and net.
> +driver_classes = ['common',
> +	       'bus',
> +	       'mempool', # depends on bus and common.
> +	       'net',     # depends on bus, common and mempool.
> +	       'crypto',  # depenss on bus, common and mempool (net in future).
> +	       'event']   # depends on bus, common, mempool and net.

It seems you used alphabetical order to list dependencies in the Makefile
and in meson.build. I think it would be more logical to have common
before bus in dependencies.

You can also take the opportunity to fix the typo on "depenss".

Thanks