From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_ALL,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC00C742D2 for ; Fri, 12 Jul 2019 15:58:36 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D5EC221670 for ; Fri, 12 Jul 2019 15:58:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.de header.i=@amazon.de header.b="BUptkUbB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5EC221670 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3E97A4A52F; Fri, 12 Jul 2019 11:58:35 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@amazon.de Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VAbwVC7TzgSi; Fri, 12 Jul 2019 11:58:34 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 065FB4A531; Fri, 12 Jul 2019 11:58:34 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 50A434A52F for ; Fri, 12 Jul 2019 11:58:32 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dVNsm3b9IA0P for ; Fri, 12 Jul 2019 11:58:30 -0400 (EDT) Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 315294A4EA for ; Fri, 12 Jul 2019 11:58:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1562947110; x=1594483110; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:mime-version: content-transfer-encoding; bh=Xv6oMdRCDU5+Rbt92DK7ZqXDl23JyeTh31Mje6oJEeA=; b=BUptkUbBsw/1MQUzYSTzxK6Y7fJxNeJhT0qJd6SxDMBuTKZ0ZfCVlHT3 4xJ7OLHp3yNF2DEf7zXmCQFmWYVHEk2VPT2gi61Le1rkQAjy6N807VHWf H945+GlXJDMAn4+sO6ngnFFTTfP8RCS7ml5pP9SmVGPPKn71rFZVRqwhk k=; X-IronPort-AV: E=Sophos;i="5.62,483,1554768000"; d="scan'208";a="810893324" Received: from sea3-co-svc-lb6-vlan3.sea.amazon.com (HELO email-inbound-relay-2c-168cbb73.us-west-2.amazon.com) ([10.47.22.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 12 Jul 2019 15:58:25 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2c-168cbb73.us-west-2.amazon.com (Postfix) with ESMTPS id 819EEA2452; Fri, 12 Jul 2019 15:58:25 +0000 (UTC) Received: from EX13D01EUB003.ant.amazon.com (10.43.166.248) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Jul 2019 15:58:24 +0000 Received: from EX13D01EUB003.ant.amazon.com (10.43.166.248) by EX13D01EUB003.ant.amazon.com (10.43.166.248) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Jul 2019 15:58:24 +0000 Received: from EX13D01EUB003.ant.amazon.com ([10.43.166.248]) by EX13D01EUB003.ant.amazon.com ([10.43.166.248]) with mapi id 15.00.1367.000; Fri, 12 Jul 2019 15:58:24 +0000 From: "Raslan, KarimAllah" To: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] KVM: arm/arm64: Properly check for MMIO regions Thread-Topic: [PATCH] KVM: arm/arm64: Properly check for MMIO regions Thread-Index: AQHVOIsEiyNRFKEvKk+KpgFJVWRN7KbHJC2A Date: Fri, 12 Jul 2019 15:58:23 +0000 Message-ID: <1562947103.19043.1.camel@amazon.de> References: <1562919728-642-1-git-send-email-karahmed@amazon.de> In-Reply-To: <1562919728-642-1-git-send-email-karahmed@amazon.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.54] Content-ID: <5D2353EA90095E4081DA8A6D66A19A79@amazon.com> MIME-Version: 1.0 Precedence: Bulk Cc: "marc.zyngier@arm.com" , "kvmarm@lists.cs.columbia.edu" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, 2019-07-12 at 10:22 +0200, KarimAllah Ahmed wrote: > Valid RAM can live outside kernel control (e.g. using "mem=" command-line > parameter). This memory can still be used as valid guest memory for KVM. So > ensure that we validate that this memory is definitely not "RAM" before > assuming that it is an MMIO region. This patch actually suffers from the same problem pointed out here: https://lkml.org/lkml/2019/7/12/760 .. so I will need to rework them together. > > One way to use memory outside kernel control is: > > 1- Pass 'mem=' in the kernel command-line to limit the amount of memory managed > by the kernel. > 2- Map this physical memory you want to give to the guest with: > mmap("/dev/mem", physical_address_offset, ..) > 3- Use the user-space virtual address as the "userspace_addr" field in > KVM_SET_USER_MEMORY_REGION ioctl. > > One of the limitations of the current /dev/mem for ARM is that it would map > this memory as uncached without this patch: > https://lkml.org/lkml/2019/7/11/684 > > This work is similar to the work done on x86 here: > https://lkml.org/lkml/2019/1/31/933 > > Cc: Marc Zyngier > Cc: James Morse > Cc: Julien Thierry > Cc: Suzuki K Pouloze > Cc: linux-arm-kernel@lists.infradead.org > Cc: kvmarm@lists.cs.columbia.edu > Cc: linux-kernel@vger.kernel.org > Signed-off-by: KarimAllah Ahmed > --- > virt/kvm/arm/mmu.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > index 06180c9..2105134 100644 > --- a/virt/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -89,7 +90,7 @@ static void kvm_flush_dcache_pud(struct kvm *kvm, > > static bool kvm_is_device_pfn(unsigned long pfn) > { > - return !pfn_valid(pfn); > + return !memblock_is_memory(__pfn_to_phys(pfn)); > } > > /** > @@ -949,6 +950,7 @@ static void stage2_unmap_memslot(struct kvm *kvm, > do { > struct vm_area_struct *vma = find_vma(current->mm, hva); > hva_t vm_start, vm_end; > + gpa_t gpa; > > if (!vma || vma->vm_start >= reg_end) > break; > @@ -959,11 +961,14 @@ static void stage2_unmap_memslot(struct kvm *kvm, > vm_start = max(hva, vma->vm_start); > vm_end = min(reg_end, vma->vm_end); > > - if (!(vma->vm_flags & VM_PFNMAP)) { > - gpa_t gpa = addr + (vm_start - memslot->userspace_addr); > - unmap_stage2_range(kvm, gpa, vm_end - vm_start); > - } > hva = vm_end; > + > + if ((vma->vm_flags & VM_PFNMAP) && > + !memblock_is_memory(__pfn_to_phys(vma->vm_pgoff))) > + continue; > + > + gpa = addr + (vm_start - memslot->userspace_addr); > + unmap_stage2_range(kvm, gpa, vm_end - vm_start); > } while (hva < reg_end); > } > > @@ -2329,7 +2334,8 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm, > vm_start = max(hva, vma->vm_start); > vm_end = min(reg_end, vma->vm_end); > > - if (vma->vm_flags & VM_PFNMAP) { > + if ((vma->vm_flags & VM_PFNMAP) && > + !memblock_is_memory(__pfn_to_phys(vma->vm_pgoff))) { > gpa_t gpa = mem->guest_phys_addr + > (vm_start - mem->userspace_addr); > phys_addr_t pa; Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29F6C742D1 for ; Fri, 12 Jul 2019 15:58:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC0722166E for ; Fri, 12 Jul 2019 15:58:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YQKE0axN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.de header.i=@amazon.de header.b="iiavQVDX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC0722166E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/oEz4xjyGgwzdwlM67pmZiCLjWYK9y8seVWgwgdiYBI=; b=YQKE0axNiemYvP W0VRO0gMxs16ZtQ2I09huAYJhOfhD8SNzZsPhm/cCxMcn7UrhegcGtWRhlp2ncfsDgXmiQ2X1MHXf 8UMXKQkgCPf+ImufXa800onZYSWlHuUiSnNCep7WT+6GH8a8+bRsTJPCQgGh+RLh+txrbR/fuvda8 1LeALxpqxHd+oTaIfTzy9rMRhpzS1gcrMwjKZF+QmuuzRI/pFvLoYrAtATgGOqfByX0O/yoE7PiZn hQnXhWtBShbYyfiiMA1jlyhUwqaygwbW6Oivy5EmqWZ1VhOoPleypYZnRgT4lKBUFSmEiKH02mYrv tGnemAFxPGytwqJsMfag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlxwP-0007Qr-KA; Fri, 12 Jul 2019 15:58:33 +0000 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlxwM-0007Q5-10 for linux-arm-kernel@lists.infradead.org; Fri, 12 Jul 2019 15:58:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1562947109; x=1594483109; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:mime-version: content-transfer-encoding; bh=Xv6oMdRCDU5+Rbt92DK7ZqXDl23JyeTh31Mje6oJEeA=; b=iiavQVDXsfKYvtjb7AVbbq5zd8PPT9jaocdsU3LJ8SOBHOaD2IePIVpA inGN1kXir/lbAYBBE9D4HHVhaCfpcDp1Zu8jseGM/dF2RaQ2qWfja9Cz5 cAvfkVllJ2cwW3qHFn9nn0otncWPgB8UBakvanPXLS6+OzR4DBqZZ7i6B s=; X-IronPort-AV: E=Sophos;i="5.62,483,1554768000"; d="scan'208";a="810893324" Received: from sea3-co-svc-lb6-vlan3.sea.amazon.com (HELO email-inbound-relay-2c-168cbb73.us-west-2.amazon.com) ([10.47.22.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 12 Jul 2019 15:58:25 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2c-168cbb73.us-west-2.amazon.com (Postfix) with ESMTPS id 819EEA2452; Fri, 12 Jul 2019 15:58:25 +0000 (UTC) Received: from EX13D01EUB003.ant.amazon.com (10.43.166.248) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Jul 2019 15:58:24 +0000 Received: from EX13D01EUB003.ant.amazon.com (10.43.166.248) by EX13D01EUB003.ant.amazon.com (10.43.166.248) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Jul 2019 15:58:24 +0000 Received: from EX13D01EUB003.ant.amazon.com ([10.43.166.248]) by EX13D01EUB003.ant.amazon.com ([10.43.166.248]) with mapi id 15.00.1367.000; Fri, 12 Jul 2019 15:58:24 +0000 From: "Raslan, KarimAllah" To: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] KVM: arm/arm64: Properly check for MMIO regions Thread-Topic: [PATCH] KVM: arm/arm64: Properly check for MMIO regions Thread-Index: AQHVOIsEiyNRFKEvKk+KpgFJVWRN7KbHJC2A Date: Fri, 12 Jul 2019 15:58:23 +0000 Message-ID: <1562947103.19043.1.camel@amazon.de> References: <1562919728-642-1-git-send-email-karahmed@amazon.de> In-Reply-To: <1562919728-642-1-git-send-email-karahmed@amazon.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.54] Content-ID: <5D2353EA90095E4081DA8A6D66A19A79@amazon.com> MIME-Version: 1.0 Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190712_085830_130950_A1ADBB0A X-CRM114-Status: GOOD ( 20.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "marc.zyngier@arm.com" , "suzuki.poulose@arm.com" , "james.morse@arm.com" , "kvmarm@lists.cs.columbia.edu" , "julien.thierry@arm.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-07-12 at 10:22 +0200, KarimAllah Ahmed wrote: > Valid RAM can live outside kernel control (e.g. using "mem=" command-line > parameter). This memory can still be used as valid guest memory for KVM. So > ensure that we validate that this memory is definitely not "RAM" before > assuming that it is an MMIO region. This patch actually suffers from the same problem pointed out here: https://lkml.org/lkml/2019/7/12/760 .. so I will need to rework them together. > > One way to use memory outside kernel control is: > > 1- Pass 'mem=' in the kernel command-line to limit the amount of memory managed > by the kernel. > 2- Map this physical memory you want to give to the guest with: > mmap("/dev/mem", physical_address_offset, ..) > 3- Use the user-space virtual address as the "userspace_addr" field in > KVM_SET_USER_MEMORY_REGION ioctl. > > One of the limitations of the current /dev/mem for ARM is that it would map > this memory as uncached without this patch: > https://lkml.org/lkml/2019/7/11/684 > > This work is similar to the work done on x86 here: > https://lkml.org/lkml/2019/1/31/933 > > Cc: Marc Zyngier > Cc: James Morse > Cc: Julien Thierry > Cc: Suzuki K Pouloze > Cc: linux-arm-kernel@lists.infradead.org > Cc: kvmarm@lists.cs.columbia.edu > Cc: linux-kernel@vger.kernel.org > Signed-off-by: KarimAllah Ahmed > --- > virt/kvm/arm/mmu.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > index 06180c9..2105134 100644 > --- a/virt/kvm/arm/mmu.c > +++ b/virt/kvm/arm/mmu.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -89,7 +90,7 @@ static void kvm_flush_dcache_pud(struct kvm *kvm, > > static bool kvm_is_device_pfn(unsigned long pfn) > { > - return !pfn_valid(pfn); > + return !memblock_is_memory(__pfn_to_phys(pfn)); > } > > /** > @@ -949,6 +950,7 @@ static void stage2_unmap_memslot(struct kvm *kvm, > do { > struct vm_area_struct *vma = find_vma(current->mm, hva); > hva_t vm_start, vm_end; > + gpa_t gpa; > > if (!vma || vma->vm_start >= reg_end) > break; > @@ -959,11 +961,14 @@ static void stage2_unmap_memslot(struct kvm *kvm, > vm_start = max(hva, vma->vm_start); > vm_end = min(reg_end, vma->vm_end); > > - if (!(vma->vm_flags & VM_PFNMAP)) { > - gpa_t gpa = addr + (vm_start - memslot->userspace_addr); > - unmap_stage2_range(kvm, gpa, vm_end - vm_start); > - } > hva = vm_end; > + > + if ((vma->vm_flags & VM_PFNMAP) && > + !memblock_is_memory(__pfn_to_phys(vma->vm_pgoff))) > + continue; > + > + gpa = addr + (vm_start - memslot->userspace_addr); > + unmap_stage2_range(kvm, gpa, vm_end - vm_start); > } while (hva < reg_end); > } > > @@ -2329,7 +2334,8 @@ int kvm_arch_prepare_memory_region(struct kvm *kvm, > vm_start = max(hva, vma->vm_start); > vm_end = min(reg_end, vma->vm_end); > > - if (vma->vm_flags & VM_PFNMAP) { > + if ((vma->vm_flags & VM_PFNMAP) && > + !memblock_is_memory(__pfn_to_phys(vma->vm_pgoff))) { > gpa_t gpa = mem->guest_phys_addr + > (vm_start - mem->userspace_addr); > phys_addr_t pa; Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E862C742CA for ; Fri, 12 Jul 2019 15:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24B96206B8 for ; Fri, 12 Jul 2019 15:58:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.de header.i=@amazon.de header.b="iiavQVDX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727246AbfGLP6b (ORCPT ); Fri, 12 Jul 2019 11:58:31 -0400 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:61294 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfGLP6b (ORCPT ); Fri, 12 Jul 2019 11:58:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1562947109; x=1594483109; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:mime-version: content-transfer-encoding; bh=Xv6oMdRCDU5+Rbt92DK7ZqXDl23JyeTh31Mje6oJEeA=; b=iiavQVDXsfKYvtjb7AVbbq5zd8PPT9jaocdsU3LJ8SOBHOaD2IePIVpA inGN1kXir/lbAYBBE9D4HHVhaCfpcDp1Zu8jseGM/dF2RaQ2qWfja9Cz5 cAvfkVllJ2cwW3qHFn9nn0otncWPgB8UBakvanPXLS6+OzR4DBqZZ7i6B s=; X-IronPort-AV: E=Sophos;i="5.62,483,1554768000"; d="scan'208";a="810893324" Received: from sea3-co-svc-lb6-vlan3.sea.amazon.com (HELO email-inbound-relay-2c-168cbb73.us-west-2.amazon.com) ([10.47.22.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 12 Jul 2019 15:58:25 +0000 Received: from EX13MTAUEA001.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2c-168cbb73.us-west-2.amazon.com (Postfix) with ESMTPS id 819EEA2452; Fri, 12 Jul 2019 15:58:25 +0000 (UTC) Received: from EX13D01EUB003.ant.amazon.com (10.43.166.248) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Jul 2019 15:58:24 +0000 Received: from EX13D01EUB003.ant.amazon.com (10.43.166.248) by EX13D01EUB003.ant.amazon.com (10.43.166.248) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Jul 2019 15:58:24 +0000 Received: from EX13D01EUB003.ant.amazon.com ([10.43.166.248]) by EX13D01EUB003.ant.amazon.com ([10.43.166.248]) with mapi id 15.00.1367.000; Fri, 12 Jul 2019 15:58:24 +0000 From: "Raslan, KarimAllah" To: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" CC: "marc.zyngier@arm.com" , "kvmarm@lists.cs.columbia.edu" , "james.morse@arm.com" , "julien.thierry@arm.com" , "suzuki.poulose@arm.com" Subject: Re: [PATCH] KVM: arm/arm64: Properly check for MMIO regions Thread-Topic: [PATCH] KVM: arm/arm64: Properly check for MMIO regions Thread-Index: AQHVOIsEiyNRFKEvKk+KpgFJVWRN7KbHJC2A Date: Fri, 12 Jul 2019 15:58:23 +0000 Message-ID: <1562947103.19043.1.camel@amazon.de> References: <1562919728-642-1-git-send-email-karahmed@amazon.de> In-Reply-To: <1562919728-642-1-git-send-email-karahmed@amazon.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.54] Content-Type: text/plain; charset="utf-8" Content-ID: <5D2353EA90095E4081DA8A6D66A19A79@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gRnJpLCAyMDE5LTA3LTEyIGF0IDEwOjIyICswMjAwLCBLYXJpbUFsbGFoIEFobWVkIHdyb3Rl Og0KPiBWYWxpZCBSQU0gY2FuIGxpdmUgb3V0c2lkZSBrZXJuZWwgY29udHJvbCAoZS5nLiB1c2lu ZyAibWVtPSIgY29tbWFuZC1saW5lDQo+IHBhcmFtZXRlcikuIFRoaXMgbWVtb3J5IGNhbiBzdGls bCBiZSB1c2VkIGFzIHZhbGlkIGd1ZXN0IG1lbW9yeSBmb3IgS1ZNLiBTbw0KPiBlbnN1cmUgdGhh dCB3ZSB2YWxpZGF0ZSB0aGF0IHRoaXMgbWVtb3J5IGlzIGRlZmluaXRlbHkgbm90ICJSQU0iIGJl Zm9yZQ0KPiBhc3N1bWluZyB0aGF0IGl0IGlzIGFuIE1NSU8gcmVnaW9uLg0KDQpUaGlzIHBhdGNo IGFjdHVhbGx5IHN1ZmZlcnMgZnJvbSB0aGUgc2FtZSBwcm9ibGVtIHBvaW50ZWQgb3V0IGhlcmU6 DQpodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOS83LzEyLzc2MA0KDQouLiBzbyBJIHdpbGwgbmVl ZCB0byByZXdvcmsgdGhlbSB0b2dldGhlci4NCg0KPiANCj4gT25lIHdheSB0byB1c2UgbWVtb3J5 IG91dHNpZGUga2VybmVsIGNvbnRyb2wgaXM6DQo+IA0KPiAxLSBQYXNzICdtZW09JyBpbiB0aGUg a2VybmVsIGNvbW1hbmQtbGluZSB0byBsaW1pdCB0aGUgYW1vdW50IG9mIG1lbW9yeSBtYW5hZ2Vk DQo+ICAgIGJ5IHRoZSBrZXJuZWwuDQo+IDItIE1hcCB0aGlzIHBoeXNpY2FsIG1lbW9yeSB5b3Ug d2FudCB0byBnaXZlIHRvIHRoZSBndWVzdCB3aXRoOg0KPiAgICBtbWFwKCIvZGV2L21lbSIsIHBo eXNpY2FsX2FkZHJlc3Nfb2Zmc2V0LCAuLikNCj4gMy0gVXNlIHRoZSB1c2VyLXNwYWNlIHZpcnR1 YWwgYWRkcmVzcyBhcyB0aGUgInVzZXJzcGFjZV9hZGRyIiBmaWVsZCBpbg0KPiAgICBLVk1fU0VU X1VTRVJfTUVNT1JZX1JFR0lPTiBpb2N0bC4NCj4gDQo+IE9uZSBvZiB0aGUgbGltaXRhdGlvbnMg b2YgdGhlIGN1cnJlbnQgL2Rldi9tZW0gZm9yIEFSTSBpcyB0aGF0IGl0IHdvdWxkIG1hcA0KPiB0 aGlzIG1lbW9yeSBhcyB1bmNhY2hlZCB3aXRob3V0IHRoaXMgcGF0Y2g6DQo+IGh0dHBzOi8vbGtt bC5vcmcvbGttbC8yMDE5LzcvMTEvNjg0DQo+IA0KPiBUaGlzIHdvcmsgaXMgc2ltaWxhciB0byB0 aGUgd29yayBkb25lIG9uIHg4NiBoZXJlOg0KPiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOS8x LzMxLzkzMw0KPiANCj4gQ2M6IE1hcmMgWnluZ2llciA8bWFyYy56eW5naWVyQGFybS5jb20+DQo+ IENjOiBKYW1lcyBNb3JzZSA8amFtZXMubW9yc2VAYXJtLmNvbT4NCj4gQ2M6IEp1bGllbiBUaGll cnJ5IDxqdWxpZW4udGhpZXJyeUBhcm0uY29tPg0KPiBDYzogU3V6dWtpIEsgUG91bG96ZSA8c3V6 dWtpLnBvdWxvc2VAYXJtLmNvbT4NCj4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZw0KPiBDYzoga3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQ0KPiBDYzogbGludXgt a2VybmVsQHZnZXIua2VybmVsLm9yZw0KPiBTaWduZWQtb2ZmLWJ5OiBLYXJpbUFsbGFoIEFobWVk IDxrYXJhaG1lZEBhbWF6b24uZGU+DQo+IC0tLQ0KPiAgdmlydC9rdm0vYXJtL21tdS5jIHwgMTgg KysrKysrKysrKysrLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwg NiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS92aXJ0L2t2bS9hcm0vbW11LmMgYi92 aXJ0L2t2bS9hcm0vbW11LmMNCj4gaW5kZXggMDYxODBjOS4uMjEwNTEzNCAxMDA2NDQNCj4gLS0t IGEvdmlydC9rdm0vYXJtL21tdS5jDQo+ICsrKyBiL3ZpcnQva3ZtL2FybS9tbXUuYw0KPiBAQCAt OCw2ICs4LDcgQEANCj4gICNpbmNsdWRlIDxsaW51eC9rdm1faG9zdC5oPg0KPiAgI2luY2x1ZGUg PGxpbnV4L2lvLmg+DQo+ICAjaW5jbHVkZSA8bGludXgvaHVnZXRsYi5oPg0KPiArI2luY2x1ZGUg PGxpbnV4L21lbWJsb2NrLmg+DQo+ICAjaW5jbHVkZSA8bGludXgvc2NoZWQvc2lnbmFsLmg+DQo+ ICAjaW5jbHVkZSA8dHJhY2UvZXZlbnRzL2t2bS5oPg0KPiAgI2luY2x1ZGUgPGFzbS9wZ2FsbG9j Lmg+DQo+IEBAIC04OSw3ICs5MCw3IEBAIHN0YXRpYyB2b2lkIGt2bV9mbHVzaF9kY2FjaGVfcHVk KHN0cnVjdCBrdm0gKmt2bSwNCj4gIA0KPiAgc3RhdGljIGJvb2wga3ZtX2lzX2RldmljZV9wZm4o dW5zaWduZWQgbG9uZyBwZm4pDQo+ICB7DQo+IC0JcmV0dXJuICFwZm5fdmFsaWQocGZuKTsNCj4g KwlyZXR1cm4gIW1lbWJsb2NrX2lzX21lbW9yeShfX3Bmbl90b19waHlzKHBmbikpOw0KPiAgfQ0K PiAgDQo+ICAvKioNCj4gQEAgLTk0OSw2ICs5NTAsNyBAQCBzdGF0aWMgdm9pZCBzdGFnZTJfdW5t YXBfbWVtc2xvdChzdHJ1Y3Qga3ZtICprdm0sDQo+ICAJZG8gew0KPiAgCQlzdHJ1Y3Qgdm1fYXJl YV9zdHJ1Y3QgKnZtYSA9IGZpbmRfdm1hKGN1cnJlbnQtPm1tLCBodmEpOw0KPiAgCQlodmFfdCB2 bV9zdGFydCwgdm1fZW5kOw0KPiArCQlncGFfdCBncGE7DQo+ICANCj4gIAkJaWYgKCF2bWEgfHwg dm1hLT52bV9zdGFydCA+PSByZWdfZW5kKQ0KPiAgCQkJYnJlYWs7DQo+IEBAIC05NTksMTEgKzk2 MSwxNCBAQCBzdGF0aWMgdm9pZCBzdGFnZTJfdW5tYXBfbWVtc2xvdChzdHJ1Y3Qga3ZtICprdm0s DQo+ICAJCXZtX3N0YXJ0ID0gbWF4KGh2YSwgdm1hLT52bV9zdGFydCk7DQo+ICAJCXZtX2VuZCA9 IG1pbihyZWdfZW5kLCB2bWEtPnZtX2VuZCk7DQo+ICANCj4gLQkJaWYgKCEodm1hLT52bV9mbGFn cyAmIFZNX1BGTk1BUCkpIHsNCj4gLQkJCWdwYV90IGdwYSA9IGFkZHIgKyAodm1fc3RhcnQgLSBt ZW1zbG90LT51c2Vyc3BhY2VfYWRkcik7DQo+IC0JCQl1bm1hcF9zdGFnZTJfcmFuZ2Uoa3ZtLCBn cGEsIHZtX2VuZCAtIHZtX3N0YXJ0KTsNCj4gLQkJfQ0KPiAgCQlodmEgPSB2bV9lbmQ7DQo+ICsN Cj4gKwkJaWYgKCh2bWEtPnZtX2ZsYWdzICYgVk1fUEZOTUFQKSAmJg0KPiArCQkgICAgIW1lbWJs b2NrX2lzX21lbW9yeShfX3Bmbl90b19waHlzKHZtYS0+dm1fcGdvZmYpKSkNCj4gKwkJCWNvbnRp bnVlOw0KPiArDQo+ICsJCWdwYSA9IGFkZHIgKyAodm1fc3RhcnQgLSBtZW1zbG90LT51c2Vyc3Bh Y2VfYWRkcik7DQo+ICsJCXVubWFwX3N0YWdlMl9yYW5nZShrdm0sIGdwYSwgdm1fZW5kIC0gdm1f c3RhcnQpOw0KPiAgCX0gd2hpbGUgKGh2YSA8IHJlZ19lbmQpOw0KPiAgfQ0KPiAgDQo+IEBAIC0y MzI5LDcgKzIzMzQsOCBAQCBpbnQga3ZtX2FyY2hfcHJlcGFyZV9tZW1vcnlfcmVnaW9uKHN0cnVj dCBrdm0gKmt2bSwNCj4gIAkJdm1fc3RhcnQgPSBtYXgoaHZhLCB2bWEtPnZtX3N0YXJ0KTsNCj4g IAkJdm1fZW5kID0gbWluKHJlZ19lbmQsIHZtYS0+dm1fZW5kKTsNCj4gIA0KPiAtCQlpZiAodm1h LT52bV9mbGFncyAmIFZNX1BGTk1BUCkgew0KPiArCQlpZiAoKHZtYS0+dm1fZmxhZ3MgJiBWTV9Q Rk5NQVApICYmDQo+ICsJCSAgICAhbWVtYmxvY2tfaXNfbWVtb3J5KF9fcGZuX3RvX3BoeXModm1h LT52bV9wZ29mZikpKSB7DQo+ICAJCQlncGFfdCBncGEgPSBtZW0tPmd1ZXN0X3BoeXNfYWRkciAr DQo+ICAJCQkJICAgICh2bV9zdGFydCAtIG1lbS0+dXNlcnNwYWNlX2FkZHIpOw0KPiAgCQkJcGh5 c19hZGRyX3QgcGE7DQoKCgpBbWF6b24gRGV2ZWxvcG1lbnQgQ2VudGVyIEdlcm1hbnkgR21iSApL cmF1c2Vuc3RyLiAzOAoxMDExNyBCZXJsaW4KR2VzY2hhZWZ0c2Z1ZWhydW5nOiBDaHJpc3RpYW4g U2NobGFlZ2VyLCBSYWxmIEhlcmJyaWNoCkVpbmdldHJhZ2VuIGFtIEFtdHNnZXJpY2h0IENoYXJs b3R0ZW5idXJnIHVudGVyIEhSQiAxNDkxNzMgQgpTaXR6OiBCZXJsaW4KVXN0LUlEOiBERSAyODkg MjM3IDg3OQoKCg==