All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/sdbusplus: new package
Date: Fri, 19 Jul 2019 20:18:55 +0000	[thread overview]
Message-ID: <1563567534.2343.96.camel@impinj.com> (raw)
In-Reply-To: <710b4b46-81d6-e5e6-4820-f8e1fb435750@mind.be>

On Thu, 2019-07-11 at 16:21 +0200, Arnout Vandecappelle wrote:
> 
> > diff --git a/package/sdbusplus/0001-build-Fix-example-build-with-disable-sdbuspp.patch b/package/sdbusplus/0001-build-Fix-example-build-with-disable-sdbuspp.patch
> > new file mode 100644
> > index 0000000000..e1364796fb
> > --- /dev/null
> > +++ b/package/sdbusplus/0001-build-Fix-example-build-with-disable-sdbuspp.patch
> > @@ -0,0 +1,42 @@
> > +From c5d5a94f8e554f160e3f120b826e97b2961e2706 Mon Sep 17 00:00:00 2001
> > +From: Trent Piepho <tpiepho@impinj.com>
> > +Date: Mon, 14 May 2018 16:17:38 -0700
> > +Subject: [PATCH] build: Fix example build with --disable-sdbuspp
> > +
> > +The calculator server example uses the sdbus++ python program to build.
> > +If this has been disabled, then trying to use it to build the example
> > +could fail. For instance, if python and all necessary python packages
> > +are not available. This might be the case when cross-building only
> > +the library component for a target system.
> > +
> > +Don't build the calculator example when sdbus++ has been disabled.
> 
> what's the upstream status of this patch? Please mention it in the patch itself.

It was submitted, back in May 16 2018, https://gerrit.openbmc-project.x
yz/c/openbmc/sdbusplus/+/10629

But merging to sdbusplus requires corporate lawyers to get involved to
for CLA, and a 5 line patch wasn't really worth it.

It was fixed later in another patch:

commit ad7e686b5563a146728aa9477f6e814dc0a3cbd4
Author: Manojkiran Eda <manojkiran.eda@gmail.com>
Date:   Thu Sep 27 13:19:20 2018 +0530

    Avoid build failure when sdbus++ tool is disabled

It would make more sense to include that patch here or to update to a
sdbusplus version that already includes, if one has been released.

  reply	other threads:[~2019-07-19 20:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 20:43 [Buildroot] [PATCH v2 0/1] package/sdbusplus: new package John Faith
2019-07-02 20:43 ` [Buildroot] [PATCH v2 1/1] " John Faith
2019-07-11 14:21   ` Arnout Vandecappelle
2019-07-19 20:18     ` Trent Piepho [this message]
2019-08-05 22:52     ` [Buildroot] [PATCH v3] " John Faith
2019-08-06 21:10       ` Thomas Petazzoni
2019-08-07 18:51         ` John Faith
2019-08-07 19:12     ` [Buildroot] [PATCH v4] " John Faith
2019-11-13 13:02       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1563567534.2343.96.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.