From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hpbBv-0004WL-DB for mharc-qemu-riscv@gnu.org; Mon, 22 Jul 2019 12:29:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36787) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpbBZ-0004Va-JA for qemu-riscv@nongnu.org; Mon, 22 Jul 2019 12:29:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpbBF-0007QH-87 for qemu-riscv@nongnu.org; Mon, 22 Jul 2019 12:29:13 -0400 Received: from smtpe1.intersmtp.com ([213.121.35.76]:18659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpbAa-0007Ar-TI; Mon, 22 Jul 2019 12:28:13 -0400 Received: from tpw09926dag18f.domain1.systemhost.net (10.9.212.26) by BWP09926081.bt.com (10.36.82.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1713.5; Mon, 22 Jul 2019 17:28:09 +0100 Received: from tpw09926dag18e.domain1.systemhost.net (10.9.212.18) by tpw09926dag18f.domain1.systemhost.net (10.9.212.26) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 22 Jul 2019 17:28:10 +0100 Received: from tpw09926dag18e.domain1.systemhost.net ([fe80::a946:6348:ccf4:fa6c]) by tpw09926dag18e.domain1.systemhost.net ([fe80::a946:6348:ccf4:fa6c%12]) with mapi id 15.00.1395.000; Mon, 22 Jul 2019 17:28:10 +0100 From: To: , CC: , , , , , , , , , , , , , , , , , , , , , , , , Thread-Topic: [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPARCv9 MMU TTE Thread-Index: AQHVQKLzQYdvLYhbLUSW1HY6Ut95kabWuu6AgAAS8LY= Date: Mon, 22 Jul 2019 16:28:10 +0000 Message-ID: <1563812889499.73128@bt.com> References: , <2b6eb033-4b6e-4d64-c57e-a3257088d0dd@linaro.org> In-Reply-To: <2b6eb033-4b6e-4d64-c57e-a3257088d0dd@linaro.org> Accept-Language: en-AU, en-GB, en-US Content-Language: en-AU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.187.101.37] Content-Type: multipart/alternative; boundary="_000_156381288949973128btcom_" MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 213.121.35.76 Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPARCv9 MMU TTE X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jul 2019 16:29:33 -0000 --_000_156381288949973128btcom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On 7/22/19 8:59 AM, Richard Henderson wrote: >On 7/22/19 8:34 AM, tony.nguyen@bt.com wrote: >> Tony Nguyen (20): >> tcg: Replace MO_8 with MO_UB alias >> tcg: Replace MO_16 with MO_UW alias >> tcg: Replace MO_32 with MO_UL alias >> tcg: Replace MO_64 with MO_UQ alias >> tcg: Move size+sign+endian from TCGMemOp to MemOp > >I don't like any of these first 5 patches. >I don't understand your motivation here. Why? The motivation is to only move the attributes required by the memory API from TCGMemOp into accelerator independent MemOp. Once I moved MO_{8|16|32|64} into MemOp, there arose many -Wenum-compare an= d -Wenum-conversion as a TCGMemOp and a MemOp are being compared and implicit= ly coerced. Thus the idea to replace MO_{8|16|32|64} with MO_{UB|UW|UL|UQ} so we remain comparing and coercing the same enum type, both TCGMemOps. Do you prefer the v1 implementation of making TCGMemOp -> MemOp? Tony. --_000_156381288949973128btcom_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

On 7/22/19 8:59= AM, Richard Henderson wrote:


>On 7/22/19 8:34 AM, tony.nguyen@bt.com wrote:
>> Tony Nguyen (20):
>>   tcg: Replace MO_8 with MO_UB alias
>>   tcg: Replace MO_16 with MO_UW alias
>>   tcg: Replace MO_32 with MO_UL alias
>>   tcg: Replace MO_64 with MO_UQ alias
>>   tcg: Move size+sign+endian from TCGMemOp to Me= mOp
>
>I don't like any of these first 5 patches.
>I don't understand your motivation here.  Why?

The motivation is to only move the attributes required by the memory A= PI
from TCGMemOp into accelerator independent MemOp.

Once I moved MO_{8|16|32|64} into MemOp, there arose many -W= enum-compare and
-Wenum-conversion as a TCGMemOp and a MemOp are being compared an= d implicitly
coerced.

Thus the idea to replace MO_{8|16|32|64} with MO_{UB|UW|UL|UQ} so we r= emain
comparing and coercing the same enum type, both TCGMemOps.

Do you prefer the v1 implementation o= f making TCGMemOp -> MemOp?

Tony.
--_000_156381288949973128btcom_-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:51d0:0:0:0:0:0 with SMTP id n16csp7081629wrv; Mon, 22 Jul 2019 09:30:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzNdCRFN3kY0vKB8zQPDMq1KE1Wf9xnYT6D9HtMIwMpuqjAqaUN8cjK+5whE/HuHTRFiEv9 X-Received: by 2002:a50:f4d8:: with SMTP id v24mr61855284edm.166.1563813016484; Mon, 22 Jul 2019 09:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563813016; cv=none; d=google.com; s=arc-20160816; b=GFEFGf4xl2RYBd+V7lpYZJm95YjLZgkSkG47hSnzmYG4Kh02hhW0GZbouA71N0eshy 7bIXi4UooK3cf/Ybjdjx9RLHPLfZ1zADPK+0hrfI0X6prbZt8y5MAWVGxS+2VOLwW62y xi8sZSvqTQ7hZatj6C4WWzyWW41Afa6li4L9PcZoKsYKS2I1KlrLz7oOMrFOKur6u/6a SRbqj+ystVvkZZdxuPzfeANIxIZ3OH/xKrDnm74MBxeRQftwWqL3BTsNNXxU4I+RLPJG eKkBwAIqUiYX7tCvlBvpk+wYfOwS3EUPi9LwGySS/POMCA6ijbydI1gbZXhREkB7xSva KuYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:mime-version :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:to:from; bh=tq1AlVcjZBu7V/F7RZIYpaQwd074CFEdx/tkNYzFMNQ=; b=EfbN4TM++rsST6rTUPvsZ1J+3xXjp5i1Jw6IcaMVljikKm7qphOH4ifi5/iFIEwcjX UHWQdDNcvdgX5Uwu+3yuHvQudO7HDL4m/HxxkvhzvXX4CyLp84UKzr1n9FSkPkI7WpSX EH34i3JVIatREp6oEzMSQZUm7kMydbwGGmDvsbnZIQCKBHHUCGX+JXT5dssQ6+1stHkq oxraq4PnpunV9JaOzfs9ySTO8vbjXzoCEaxsMbSmaFjPgURkyIclReq7plI80XtURl/c sJJmHxJqWBsf9prYVwBP0XiJQtQeQutUITHi++uJe1Lvnjl0NDCTYWLEWzMd5YhLJ0Ba vTLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bt.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i25si4970537edv.222.2019.07.22.09.30.16 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jul 2019 09:30:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bt.com Received: from localhost ([::1]:35788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpbCZ-0004da-Dr for alex.bennee@linaro.org; Mon, 22 Jul 2019 12:30:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36849) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpbCD-0004a8-FD for qemu-arm@nongnu.org; Mon, 22 Jul 2019 12:30:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpbBt-0007eZ-UJ for qemu-arm@nongnu.org; Mon, 22 Jul 2019 12:29:53 -0400 Received: from smtpe1.intersmtp.com ([213.121.35.76]:18659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpbAa-0007Ar-TI; Mon, 22 Jul 2019 12:28:13 -0400 Received: from tpw09926dag18f.domain1.systemhost.net (10.9.212.26) by BWP09926081.bt.com (10.36.82.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1713.5; Mon, 22 Jul 2019 17:28:09 +0100 Received: from tpw09926dag18e.domain1.systemhost.net (10.9.212.18) by tpw09926dag18f.domain1.systemhost.net (10.9.212.26) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 22 Jul 2019 17:28:10 +0100 Received: from tpw09926dag18e.domain1.systemhost.net ([fe80::a946:6348:ccf4:fa6c]) by tpw09926dag18e.domain1.systemhost.net ([fe80::a946:6348:ccf4:fa6c%12]) with mapi id 15.00.1395.000; Mon, 22 Jul 2019 17:28:10 +0100 From: To: , Thread-Topic: [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPARCv9 MMU TTE Thread-Index: AQHVQKLzQYdvLYhbLUSW1HY6Ut95kabWuu6AgAAS8LY= Date: Mon, 22 Jul 2019 16:28:10 +0000 Message-ID: <1563812889499.73128@bt.com> References: , <2b6eb033-4b6e-4d64-c57e-a3257088d0dd@linaro.org> In-Reply-To: <2b6eb033-4b6e-4d64-c57e-a3257088d0dd@linaro.org> Accept-Language: en-AU, en-GB, en-US Content-Language: en-AU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.187.101.37] Content-Type: multipart/alternative; boundary="_000_156381288949973128btcom_" MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 213.121.35.76 Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPARCv9 MMU TTE X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, walling@linux.ibm.com, mst@redhat.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, Alistair.Francis@wdc.com, arikalo@wavecomp.com, david@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, rth@twiddle.net, atar4qemu@gmail.com, ehabkost@redhat.com, sw@weilnetz.de, alex.williamson@redhat.com, qemu-arm@nongnu.org, david@gibson.dropbear.id.au, qemu-riscv@nongnu.org, cohuck@redhat.com, claudio.fontana@huawei.com, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, amarkovic@wavecomp.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: tu4vA3/rIGUA --_000_156381288949973128btcom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On 7/22/19 8:59 AM, Richard Henderson wrote: >On 7/22/19 8:34 AM, tony.nguyen@bt.com wrote: >> Tony Nguyen (20): >> tcg: Replace MO_8 with MO_UB alias >> tcg: Replace MO_16 with MO_UW alias >> tcg: Replace MO_32 with MO_UL alias >> tcg: Replace MO_64 with MO_UQ alias >> tcg: Move size+sign+endian from TCGMemOp to MemOp > >I don't like any of these first 5 patches. >I don't understand your motivation here. Why? The motivation is to only move the attributes required by the memory API from TCGMemOp into accelerator independent MemOp. Once I moved MO_{8|16|32|64} into MemOp, there arose many -Wenum-compare an= d -Wenum-conversion as a TCGMemOp and a MemOp are being compared and implicit= ly coerced. Thus the idea to replace MO_{8|16|32|64} with MO_{UB|UW|UL|UQ} so we remain comparing and coercing the same enum type, both TCGMemOps. Do you prefer the v1 implementation of making TCGMemOp -> MemOp? Tony. --_000_156381288949973128btcom_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

On 7/22/19 8:59= AM, Richard Henderson wrote:


>On 7/22/19 8:34 AM, tony.nguyen@bt.com wrote:
>> Tony Nguyen (20):
>>   tcg: Replace MO_8 with MO_UB alias
>>   tcg: Replace MO_16 with MO_UW alias
>>   tcg: Replace MO_32 with MO_UL alias
>>   tcg: Replace MO_64 with MO_UQ alias
>>   tcg: Move size+sign+endian from TCGMemOp to Me= mOp
>
>I don't like any of these first 5 patches.
>I don't understand your motivation here.  Why?

The motivation is to only move the attributes required by the memory A= PI
from TCGMemOp into accelerator independent MemOp.

Once I moved MO_{8|16|32|64} into MemOp, there arose many -W= enum-compare and
-Wenum-conversion as a TCGMemOp and a MemOp are being compared an= d implicitly
coerced.

Thus the idea to replace MO_{8|16|32|64} with MO_{UB|UW|UL|UQ} so we r= emain
comparing and coercing the same enum type, both TCGMemOps.

Do you prefer the v1 implementation o= f making TCGMemOp -> MemOp?

Tony.
--_000_156381288949973128btcom_-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B17C7618F for ; Mon, 22 Jul 2019 16:31:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 826862190F for ; Mon, 22 Jul 2019 16:31:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 826862190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bt.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpbDx-0005Uj-K3 for qemu-devel@archiver.kernel.org; Mon, 22 Jul 2019 12:31:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45703) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpbDT-0004yS-Tp for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:31:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpbDA-0000Ft-9W for qemu-devel@nongnu.org; Mon, 22 Jul 2019 12:31:11 -0400 Received: from smtpe1.intersmtp.com ([213.121.35.76]:18659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpbAa-0007Ar-TI; Mon, 22 Jul 2019 12:28:13 -0400 Received: from tpw09926dag18f.domain1.systemhost.net (10.9.212.26) by BWP09926081.bt.com (10.36.82.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1713.5; Mon, 22 Jul 2019 17:28:09 +0100 Received: from tpw09926dag18e.domain1.systemhost.net (10.9.212.18) by tpw09926dag18f.domain1.systemhost.net (10.9.212.26) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 22 Jul 2019 17:28:10 +0100 Received: from tpw09926dag18e.domain1.systemhost.net ([fe80::a946:6348:ccf4:fa6c]) by tpw09926dag18e.domain1.systemhost.net ([fe80::a946:6348:ccf4:fa6c%12]) with mapi id 15.00.1395.000; Mon, 22 Jul 2019 17:28:10 +0100 From: To: , Thread-Topic: [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPARCv9 MMU TTE Thread-Index: AQHVQKLzQYdvLYhbLUSW1HY6Ut95kabWuu6AgAAS8LY= Date: Mon, 22 Jul 2019 16:28:10 +0000 Message-ID: <1563812889499.73128@bt.com> References: , <2b6eb033-4b6e-4d64-c57e-a3257088d0dd@linaro.org> In-Reply-To: <2b6eb033-4b6e-4d64-c57e-a3257088d0dd@linaro.org> Accept-Language: en-AU, en-GB, en-US Content-Language: en-AU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.187.101.37] MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 213.121.35.76 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: [Qemu-devel] [PATCH v2 00/20] Invert Endian bit in SPARCv9 MMU TTE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, walling@linux.ibm.com, mst@redhat.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, Alistair.Francis@wdc.com, arikalo@wavecomp.com, david@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, rth@twiddle.net, atar4qemu@gmail.com, ehabkost@redhat.com, sw@weilnetz.de, alex.williamson@redhat.com, qemu-arm@nongnu.org, david@gibson.dropbear.id.au, qemu-riscv@nongnu.org, cohuck@redhat.com, claudio.fontana@huawei.com, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, amarkovic@wavecomp.com, pbonzini@redhat.com, aurelien@aurel32.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/22/19 8:59 AM, Richard Henderson wrote: >On 7/22/19 8:34 AM, tony.nguyen@bt.com wrote: >> Tony Nguyen (20): >> tcg: Replace MO_8 with MO_UB alias >> tcg: Replace MO_16 with MO_UW alias >> tcg: Replace MO_32 with MO_UL alias >> tcg: Replace MO_64 with MO_UQ alias >> tcg: Move size+sign+endian from TCGMemOp to MemOp > >I don't like any of these first 5 patches. >I don't understand your motivation here. Why? The motivation is to only move the attributes required by the memory API from TCGMemOp into accelerator independent MemOp. Once I moved MO_{8|16|32|64} into MemOp, there arose many -Wenum-compare an= d -Wenum-conversion as a TCGMemOp and a MemOp are being compared and implicit= ly coerced. Thus the idea to replace MO_{8|16|32|64} with MO_{UB|UW|UL|UQ} so we remain comparing and coercing the same enum type, both TCGMemOps. Do you prefer the v1 implementation of making TCGMemOp -> MemOp? Tony.