From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] net/virtio-user: Fix missing brackets in if
	condition
Date: Fri, 15 Jul 2016 22:18:48 +0200
Message-ID: <1563829.pzlCzMBiVk@xps13>
References: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>
 <20160712121114.GF26521@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 huawei.xie@intel.com, Jianfeng Tan <jianfeng.tan@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 571D73237
 for <dev@dpdk.org>; Fri, 15 Jul 2016 22:18:50 +0200 (CEST)
Received: by mail-wm0-f50.google.com with SMTP id f126so38427393wma.1
 for <dev@dpdk.org>; Fri, 15 Jul 2016 13:18:50 -0700 (PDT)
In-Reply-To: <20160712121114.GF26521@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-12 20:11, Yuanhan Liu:
> On Tue, Jul 12, 2016 at 11:30:25AM +0200, Maxime Coquelin wrote:
> > The error is reported using test build script:
> >=20
> > $ scripts/test-build.sh x86_64-native-linuxapp-gcc
> > ...
> > drivers/net/virtio/virtio_user_ethdev.c: In function =E2=80=98virti=
o_user_pmd_devinit=E2=80=99:
> > drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this =E2=80=98=
if=E2=80=99 clause does not guard... [-Werror=3Dmisleading-indentation]=

> >   if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1)
> >     ^~
> >=20
> > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked=
")
> >=20
> > Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>=20
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>=20
> Thanks for the fix.

Applied, thanks