Re: [PATCH 1/2] ima-evm-utils: Do not allow fallback and unknown hash algos

[Mimi Zohar <zohar@linux.ibm.com>]

On Thu, 2019-07-25 at 17:08 +0300, Vitaly Chikunov wrote:
> Mimi,
> 
> On Thu, Jul 25, 2019 at 09:44:02AM -0400, Mimi Zohar wrote:
> > On Thu, 2019-07-25 at 09:13 +0300, Vitaly Chikunov wrote:
> > > Falling back and permissiveness could have security implications.
> > > 
> > > Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> > 
> > Thanks!  Please update the README, removing "(default)", and rebase on
> > top of the "param" changes.
> 
> In my understanding this text in README should not be changed, since not
> specifying `-a' is the same as `-a sha1', so default holds. Code
> handling this is not changed (which is in src/libimaevm.c:87).

Agreed

> 
> What I changed is some other unexpected switching to sha1. Like when
> user specify wrong hash name in `-a'.
> 
> So I will not resend this (as there is no changes). And I want to rebase
> `param' & `imaevm_' prefix patch over these two commits.

That works.

thanks,

Mimi