diff for duplicates of <1564120985317.14967@bt.com> diff --git a/a/content_digest b/N1/content_digest index 5600808..bd686f0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,38 +2,37 @@ "ref\01564048354001.54262@bt.com\0" "ref\0ee5949da-4457-0560-4525-40e4d4aaef4a@redhat.com\0" "From\0<tony.nguyen@bt.com>\0" - "Subject\0Re: [Qemu-riscv] [Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp\0" + "Subject\0Re: [Qemu-arm] [Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp\0" "Date\0Fri, 26 Jul 2019 06:03:05 +0000\0" "To\0<philmd@redhat.com>" " <qemu-devel@nongnu.org>\0" - "Cc\0<peter.maydell@linaro.org>" - <walling@linux.ibm.com> - <sagark@eecs.berkeley.edu> - <david@redhat.com> - <palmer@sifive.com> - <mark.cave-ayland@ilande.co.uk> - <laurent@vivier.eu> - <Alistair.Francis@wdc.com> - <edgar.iglesias@gmail.com> - <arikalo@wavecomp.com> - <pasic@linux.ibm.com> - <borntraeger@de.ibm.com> - <rth@twiddle.net> - <atar4qemu@gmail.com> - <ehabkost@redhat.com> - <qemu-s390x@nongnu.org> - <qemu-arm@nongnu.org> - <stefanha@redhat.com> - <shorne@gmail.com> - <david@gibson.dropbear.id.au> - <qemu-riscv@nongnu.org> - <kbastian@mail.uni-paderborn.de> - <cohuck@redhat.com> - <alex.williamson@redhat.com> - <qemu-ppc@nongnu.org> - <amarkovic@wavecomp.com> - <pbonzini@redhat.com> - " <aurelien@aurel32.net>\0" + "Cc\0peter.maydell@linaro.org" + walling@linux.ibm.com + sagark@eecs.berkeley.edu + david@redhat.com + palmer@sifive.com + mark.cave-ayland@ilande.co.uk + Alistair.Francis@wdc.com + alex.williamson@redhat.com + arikalo@wavecomp.com + pasic@linux.ibm.com + borntraeger@de.ibm.com + rth@twiddle.net + atar4qemu@gmail.com + ehabkost@redhat.com + qemu-s390x@nongnu.org + qemu-arm@nongnu.org + stefanha@redhat.com + shorne@gmail.com + david@gibson.dropbear.id.au + qemu-riscv@nongnu.org + kbastian@mail.uni-paderborn.de + cohuck@redhat.com + laurent@vivier.eu + qemu-ppc@nongnu.org + amarkovic@wavecomp.com + pbonzini@redhat.com + " aurelien@aurel32.net\0" "\01:1\0" "b\0" "On 7/25/19 9:45 PM, Philippe Mathieu-Daud\303\251 wrote:\n" @@ -136,4 +135,4 @@ "</body>\r\n" "</html>\r\n" -1311268d955e653b4c5657a6365ed45421f91ed62b550cfe93080d4872e14066 +17fab7ec1998c4b819dcac596f8e603ab9eea4976d4a2b578b2225332dc59aa6
diff --git a/a/2.bin b/a/2.bin deleted file mode 100644 index ba2be5a..0000000 --- a/a/2.bin +++ /dev/null @@ -1,56 +0,0 @@ -<html> -<head> -<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> -<style type="text/css" style="display:none"><!-- P { margin-top: 0px; margin-bottom: 0px; } .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left-width: 2px; border-left-style: solid; border-left-color: rgb(128, 0, 0); }--></style> -</head> -<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> -<p></p> -<div>On 7/25/19 9:45 PM, Philippe Mathieu-Daudé wrote: </div> -<div>>On 7/25/19 11:52 AM, tony.nguyen@bt.com wrote:</div> -<div>>> Replacing size with size+sign+endianness (MemOp) will enable us to</div> -<div>>> collapse the two byte swaps, adjust_endianness and handle_bswap, along</div> -<div>>> the I/O path.</div> -<div>>> </div> -<div>>> While interfaces are converted, callers will have existing unsigned</div> -<div>>> size coerced into a MemOp, and the callee will use this MemOp as an</div> -<div>>> unsigned size.</div> -<div>>> </div> -<div>>> Signed-off-by: Tony Nguyen <tony.nguyen@bt.com></div> -<div>>> ---</div> -<div>>> include/exec/memop.h | 4 ++++</div> -<div>>> include/exec/memory.h | 9 +++++----</div> -<div>>> memory.c | 7 +++++--</div> -<div>>> 3 files changed, 14 insertions(+), 6 deletions(-)</div> -<div>>> </div> -<div>>> diff --git a/include/exec/memop.h b/include/exec/memop.h</div> -<div>>> index ac58066..09c8d20 100644</div> -<div>>> --- a/include/exec/memop.h</div> -<div>>> +++ b/include/exec/memop.h</div> -<div>>> @@ -106,4 +106,8 @@ typedef enum MemOp {</div> -<div>>> MO_SSIZE = MO_SIZE | MO_SIGN,</div> -<div>>> } MemOp;</div> -<div>>> </div> -<div>>> +/* No-op while memory_region_dispatch_[read|write] is converted to MemOp */</div> -<div>>> +#define MEMOP_SIZE(op) (op) /* MemOp to size. */</div> -<div>>> +#define SIZE_MEMOP(ul) (ul) /* Size to MemOp. */</div> -<div>></div> -<div>>SIZE_MEMOP() is never used until patch #10 "memory: Access MemoryRegion</div> -<div>>with MemOp semantics", it would be clearer to only introduce the</div> -<div>>MEMOP_SIZE() no-op here, and directly introduce the correct SIZE_MEMOP()</div> -<div>>macro in patch #10.</div> -<div><br> -</div> -<div>SIZE_MEMOP() is used, and is the main change, in patches #3 to #10. Perhaps you</div> -<div>meant MEMOP_SIZE()?</div> -<div><br> -</div> -<div>Either way, you have raised an issue :)</div> -<div><br> -</div> -<div>There is a lack of clarity in how the two macros are used to update the</div> -<div>interfaces.​<br> -</div> -<p><br> -</p> -</body> -</html> diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index e54d0ae..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: text/html; charset="iso-8859-1" -Content-Transfer-Encoding: quoted-printable diff --git a/a/content_digest b/N2/content_digest index 5600808..14bbac8 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,39 +2,39 @@ "ref\01564048354001.54262@bt.com\0" "ref\0ee5949da-4457-0560-4525-40e4d4aaef4a@redhat.com\0" "From\0<tony.nguyen@bt.com>\0" - "Subject\0Re: [Qemu-riscv] [Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp\0" + "Subject\0Re: [Qemu-devel] [PATCH v4 02/15] memory: Access MemoryRegion with MemOp\0" "Date\0Fri, 26 Jul 2019 06:03:05 +0000\0" "To\0<philmd@redhat.com>" " <qemu-devel@nongnu.org>\0" - "Cc\0<peter.maydell@linaro.org>" - <walling@linux.ibm.com> - <sagark@eecs.berkeley.edu> - <david@redhat.com> - <palmer@sifive.com> - <mark.cave-ayland@ilande.co.uk> - <laurent@vivier.eu> - <Alistair.Francis@wdc.com> - <edgar.iglesias@gmail.com> - <arikalo@wavecomp.com> - <pasic@linux.ibm.com> - <borntraeger@de.ibm.com> - <rth@twiddle.net> - <atar4qemu@gmail.com> - <ehabkost@redhat.com> - <qemu-s390x@nongnu.org> - <qemu-arm@nongnu.org> - <stefanha@redhat.com> - <shorne@gmail.com> - <david@gibson.dropbear.id.au> - <qemu-riscv@nongnu.org> - <kbastian@mail.uni-paderborn.de> - <cohuck@redhat.com> - <alex.williamson@redhat.com> - <qemu-ppc@nongnu.org> - <amarkovic@wavecomp.com> - <pbonzini@redhat.com> - " <aurelien@aurel32.net>\0" - "\01:1\0" + "Cc\0peter.maydell@linaro.org" + walling@linux.ibm.com + sagark@eecs.berkeley.edu + david@redhat.com + palmer@sifive.com + mark.cave-ayland@ilande.co.uk + Alistair.Francis@wdc.com + edgar.iglesias@gmail.com + alex.williamson@redhat.com + arikalo@wavecomp.com + pasic@linux.ibm.com + borntraeger@de.ibm.com + rth@twiddle.net + atar4qemu@gmail.com + ehabkost@redhat.com + qemu-s390x@nongnu.org + qemu-arm@nongnu.org + stefanha@redhat.com + shorne@gmail.com + david@gibson.dropbear.id.au + qemu-riscv@nongnu.org + kbastian@mail.uni-paderborn.de + cohuck@redhat.com + laurent@vivier.eu + qemu-ppc@nongnu.org + amarkovic@wavecomp.com + pbonzini@redhat.com + " aurelien@aurel32.net\0" + "\00:1\0" "b\0" "On 7/25/19 9:45 PM, Philippe Mathieu-Daud\303\251 wrote:\n" ">On 7/25/19 11:52 AM, tony.nguyen@bt.com wrote:\n" @@ -77,63 +77,5 @@ "\n" "There is a lack of clarity in how the two macros are used to update the\n" interfaces.? - "\01:2\0" - "b\0" - "<html>\r\n" - "<head>\r\n" - "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=iso-8859-1\">\r\n" - "<style type=\"text/css\" style=\"display:none\"><!-- P { margin-top: 0px; margin-bottom: 0px; } .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left-width: 2px; border-left-style: solid; border-left-color: rgb(128, 0, 0); }--></style>\r\n" - "</head>\r\n" - "<body dir=\"ltr\" style=\"font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;\">\r\n" - "<p></p>\r\n" - "<div>On 7/25/19 9:45 PM, Philippe Mathieu-Daud\351 wrote: </div>\r\n" - "<div>>On 7/25/19 11:52 AM, tony.nguyen@bt.com wrote:</div>\r\n" - "<div>>> Replacing size with size+sign+endianness (MemOp) will enable us to</div>\r\n" - "<div>>> collapse the two byte swaps, adjust_endianness and handle_bswap, along</div>\r\n" - "<div>>> the I/O path.</div>\r\n" - "<div>>> </div>\r\n" - "<div>>> While interfaces are converted, callers will have existing unsigned</div>\r\n" - "<div>>> size coerced into a MemOp, and the callee will use this MemOp as an</div>\r\n" - "<div>>> unsigned size.</div>\r\n" - "<div>>> </div>\r\n" - "<div>>> Signed-off-by: Tony Nguyen <tony.nguyen@bt.com></div>\r\n" - "<div>>> ---</div>\r\n" - "<div>>> include/exec/memop.h | 4 ++++</div>\r\n" - "<div>>> include/exec/memory.h | 9 +++++----</div>\r\n" - "<div>>> memory.c | 7 +++++--</div>\r\n" - "<div>>> 3 files changed, 14 insertions(+), 6 deletions(-)</div>\r\n" - "<div>>> </div>\r\n" - "<div>>> diff --git a/include/exec/memop.h b/include/exec/memop.h</div>\r\n" - "<div>>> index ac58066..09c8d20 100644</div>\r\n" - "<div>>> --- a/include/exec/memop.h</div>\r\n" - "<div>>> +++ b/include/exec/memop.h</div>\r\n" - "<div>>> @@ -106,4 +106,8 @@ typedef enum MemOp {</div>\r\n" - "<div>>> MO_SSIZE = MO_SIZE | MO_SIGN,</div>\r\n" - "<div>>> } MemOp;</div>\r\n" - "<div>>> </div>\r\n" - "<div>>> +/* No-op while memory_region_dispatch_[read|write] is converted to MemOp */</div>\r\n" - "<div>>> +#define MEMOP_SIZE(op) (op) /* MemOp to size. */</div>\r\n" - "<div>>> +#define SIZE_MEMOP(ul) (ul) /* Size to MemOp. */</div>\r\n" - "<div>></div>\r\n" - "<div>>SIZE_MEMOP() is never used until patch #10 "memory: Access MemoryRegion</div>\r\n" - "<div>>with MemOp semantics", it would be clearer to only introduce the</div>\r\n" - "<div>>MEMOP_SIZE() no-op here, and directly introduce the correct SIZE_MEMOP()</div>\r\n" - "<div>>macro in patch #10.</div>\r\n" - "<div><br>\r\n" - "</div>\r\n" - "<div>SIZE_MEMOP() is used, and is the main change, in patches #3 to #10. Perhaps you</div>\r\n" - "<div>meant MEMOP_SIZE()?</div>\r\n" - "<div><br>\r\n" - "</div>\r\n" - "<div>Either way, you have raised an issue :)</div>\r\n" - "<div><br>\r\n" - "</div>\r\n" - "<div>There is a lack of clarity in how the two macros are used to update the</div>\r\n" - "<div>interfaces.​<br>\r\n" - "</div>\r\n" - "<p><br>\r\n" - "</p>\r\n" - "</body>\r\n" - "</html>\r\n" -1311268d955e653b4c5657a6365ed45421f91ed62b550cfe93080d4872e14066 +6e77ddd45af86b33aadd635c19eedc2acf9aeb409a64e5cc8ad41d84dd9f597c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.