From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE0DC433FF for ; Tue, 30 Jul 2019 18:33:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BDDC2064A for ; Tue, 30 Jul 2019 18:33:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JUA9FbUP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BDDC2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hsWvb-00053N-Tx; Tue, 30 Jul 2019 18:32:51 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hsWva-00053I-Ok for xen-devel@lists.xenproject.org; Tue, 30 Jul 2019 18:32:50 +0000 X-Inumbo-ID: 6ebb428b-b2f8-11e9-8980-bc764e045a96 Received: from mail-pg1-x544.google.com (unknown [2607:f8b0:4864:20::544]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 6ebb428b-b2f8-11e9-8980-bc764e045a96; Tue, 30 Jul 2019 18:32:49 +0000 (UTC) Received: by mail-pg1-x544.google.com with SMTP id i70so19758623pgd.4 for ; Tue, 30 Jul 2019 11:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6fCIBt83Qg0xm9/csFeyeLFWARKqAMvTELcBmphTpo0=; b=JUA9FbUPr0F6xNgBd5J9MHwHtCHrMpBJuNDTvZBzKBZeCmNsbohHado2HBbGTi0It9 yThD+OL5Bkf6Da9wJnEKF7n1ZuYfE+RCaAChBqmkI/jmB2QhloDai+ucTPidoKT2u6UQ 29UC6QoAyrEf4tN2GNQniwXjZkr83rJH4ak6SFrbJFSb15jmyMBIWZiHh1EgvVH6j48q cZKmuIlqPfwxsnRzt4ye0SXQ2NpyGAmqO03R0RsRzNRYkzGXP/3U1W6hIGXqsFMnjHXR g7Xo3I2gA+uPgrVqyPZw3rp948eNJFIjP60aR0GcG/CsRV9BR7dafhIdCpB5PUi2sogn ixHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6fCIBt83Qg0xm9/csFeyeLFWARKqAMvTELcBmphTpo0=; b=aza+YUpQeZ0J/kE1BHMi0XkVKFD2GccFNHk1VfR1/k8pUvYR1NisYnzwGXprk1jZjB o/0ccjHOsNNxC3yuXFyjk0E/+ReO53B+Vh2g3mpBc+4oDB06PlzVWIBzU0o+JgXmrKSi YioNI019PsKypVju0du2I3qJdv+KMvgwD9QK51O01QEvn4J5vlkK+68Sxx53d45fkcF7 jwIRnQRJbl/c4jO4sL+xTJS4sYfbecTKKopXKybCeYqv1xBhQTsAK7P/QcDkUuTXY94t xLm8yk3RKpg2sUQATe8GvHCcQ/viMfWnABr2mie15YP2PzvYxVbi5pjTX1TTrZzYLkUA ZBiw== X-Gm-Message-State: APjAAAVNM4kMXjUt6KmI96LSkBsDHhbMP+pmmT+DqWH2iRaCa628Qkix zUnF7hj/oHG9FyWaveJB8ZE= X-Google-Smtp-Source: APXvYqz3TKO5CR8bm9L/zAhw0K/5mmOOXYnkeug29AHRYcKaRz4UPuCN4Qa7WYzWXEa+PlUkZGXEBw== X-Received: by 2002:a62:754d:: with SMTP id q74mr42050335pfc.211.1564511568653; Tue, 30 Jul 2019 11:32:48 -0700 (PDT) Received: from jordon-HP-15-Notebook-PC.domain.name ([106.51.16.0]) by smtp.gmail.com with ESMTPSA id j5sm57328671pgp.59.2019.07.30.11.32.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Jul 2019 11:32:47 -0700 (PDT) From: Souptick Joarder To: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, marmarek@invisiblethingslab.com Date: Wed, 31 Jul 2019 00:04:56 +0530 Message-Id: <1564511696-4044-1-git-send-email-jrdr.linux@gmail.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] xen/gntdev.c: Replace vm_map_pages() with vm_map_pages_zero() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, willy@infradead.org, linux@armlinux.org.uk, linux-mm@kvack.org, stable@vger.kernel.org, xen-devel@lists.xenproject.org, akpm@linux-foundation.org, Souptick Joarder Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" J2NvbW1pdCBkZjliZGUwMTVhNzIgKCJ4ZW4vZ250ZGV2LmM6IGNvbnZlcnQgdG8gdXNlIHZtX21h cF9wYWdlcygpIiknCmJyZWFrcyBnbnRkZXYgZHJpdmVyLiBJZiB2bWEtPnZtX3Bnb2ZmID4gMCwg dm1fbWFwX3BhZ2VzKCkKd2lsbDoKIC0gdXNlIG1hcC0+cGFnZXMgc3RhcnRpbmcgYXQgdm1hLT52 bV9wZ29mZiBpbnN0ZWFkIG9mIDAKIC0gdmVyaWZ5IG1hcC0+Y291bnQgYWdhaW5zdCB2bWFfcGFn ZXMoKSt2bWEtPnZtX3Bnb2ZmIGluc3RlYWQgb2YganVzdAogICB2bWFfcGFnZXMoKS4KCkluIHBy YWN0aWNlLCB0aGlzIGJyZWFrcyB1c2luZyBhIHNpbmdsZSBnbnRkZXYgRkQgZm9yIG1hcHBpbmcg bXVsdGlwbGUKZ3JhbnRzLgoKcmVsZXZhbnQgc3RyYWNlIG91dHB1dDoKW3BpZCAgIDg1N10gaW9j dGwoNywgSU9DVExfR05UREVWX01BUF9HUkFOVF9SRUYsIDB4N2ZmZDM0MDdiNmQwKSA9IDAKW3Bp ZCAgIDg1N10gbW1hcChOVUxMLCA0MDk2LCBQUk9UX1JFQUR8UFJPVF9XUklURSwgTUFQX1NIQVJF RCwgNywgMCkgPQoweDc3N2YxMjExYjAwMApbcGlkICAgODU3XSBpb2N0bCg3LCBJT0NUTF9HTlRE RVZfU0VUX1VOTUFQX05PVElGWSwgMHg3ZmZkMzQwN2I3MTApID0gMApbcGlkICAgODU3XSBpb2N0 bCg3LCBJT0NUTF9HTlRERVZfTUFQX0dSQU5UX1JFRiwgMHg3ZmZkMzQwN2I2ZDApID0gMApbcGlk ICAgODU3XSBtbWFwKE5VTEwsIDQwOTYsIFBST1RfUkVBRHxQUk9UX1dSSVRFLCBNQVBfU0hBUkVE LCA3LAoweDEwMDApID0gLTEgRU5YSU8gKE5vIHN1Y2ggZGV2aWNlIG9yIGFkZHJlc3MpCgpkZXRh aWxzIGhlcmU6Cmh0dHBzOi8vZ2l0aHViLmNvbS9RdWJlc09TL3F1YmVzLWlzc3Vlcy9pc3N1ZXMv NTE5OQoKVGhlIHJlYXNvbiBpcyAtPiAoIGNvcHlpbmcgTWFyZWsncyB3b3JkIGZyb20gZGlzY3Vz c2lvbikKCnZtYS0+dm1fcGdvZmYgaXMgdXNlZCBhcyBpbmRleCBwYXNzZWQgdG8gZ250ZGV2X2Zp bmRfbWFwX2luZGV4LiBJdCdzCmJhc2ljYWxseSB1c2luZyB0aGlzIHBhcmFtZXRlciBmb3IgIndo aWNoIGdyYW50IHJlZmVyZW5jZSB0byBtYXAiLgptYXAgc3RydWN0IHJldHVybmVkIGJ5IGdudGRl dl9maW5kX21hcF9pbmRleCgpIGRlc2NyaWJlcyBqdXN0IHRoZSBwYWdlcwp0byBiZSBtYXBwZWQu IFNwZWNpZmljYWxseSBtYXAtPnBhZ2VzWzBdIHNob3VsZCBiZSBtYXBwZWQgYXQKdm1hLT52bV9z dGFydCwgbm90IHZtYS0+dm1fc3RhcnQrdm1hLT52bV9wZ29mZipQQUdFX1NJWkUuCgpXaGVuIHRy eWluZyB0byBtYXAgZ3JhbnQgd2l0aCBpbmRleCAoYWthIHZtYS0+dm1fcGdvZmYpID4gMSwKX192 bV9tYXBfcGFnZXMoKSB3aWxsIHJlZnVzZSB0byBtYXAgaXQgYmVjYXVzZSBpdCB3aWxsIGV4cGVj dCBtYXAtPmNvdW50CnRvIGJlIGF0IGxlYXN0IHZtYV9wYWdlcyh2bWEpK3ZtYS0+dm1fcGdvZmYs IHdoaWxlIGl0IGlzIGV4YWN0bHkKdm1hX3BhZ2VzKHZtYSkuCgpDb252ZXJ0aW5nIHZtX21hcF9w YWdlcygpIHRvIHVzZSB2bV9tYXBfcGFnZXNfemVybygpIHdpbGwgZml4IHRoZQpwcm9ibGVtLgoK TWFyZWsgaGFzIHRlc3RlZCBhbmQgY29uZmlybWVkIHRoZSBzYW1lLgoKUmVwb3J0ZWQtYnk6IE1h cmVrIE1hcmN6eWtvd3NraS1Hw7NyZWNraSA8bWFybWFyZWtAaW52aXNpYmxldGhpbmdzbGFiLmNv bT4KU2lnbmVkLW9mZi1ieTogU291cHRpY2sgSm9hcmRlciA8anJkci5saW51eEBnbWFpbC5jb20+ ClRlc3RlZC1ieTogTWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tpIDxtYXJtYXJla0BpbnZpc2li bGV0aGluZ3NsYWIuY29tPgotLS0KIGRyaXZlcnMveGVuL2dudGRldi5jIHwgMiArLQogMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJp dmVycy94ZW4vZ250ZGV2LmMgYi9kcml2ZXJzL3hlbi9nbnRkZXYuYwppbmRleCA0YzMzOWM3Li5h NDQ2YTcyIDEwMDY0NAotLS0gYS9kcml2ZXJzL3hlbi9nbnRkZXYuYworKysgYi9kcml2ZXJzL3hl bi9nbnRkZXYuYwpAQCAtMTE0Myw3ICsxMTQzLDcgQEAgc3RhdGljIGludCBnbnRkZXZfbW1hcChz dHJ1Y3QgZmlsZSAqZmxpcCwgc3RydWN0IHZtX2FyZWFfc3RydWN0ICp2bWEpCiAJCWdvdG8gb3V0 X3B1dF9tYXA7CiAKIAlpZiAoIXVzZV9wdGVtb2QpIHsKLQkJZXJyID0gdm1fbWFwX3BhZ2VzKHZt YSwgbWFwLT5wYWdlcywgbWFwLT5jb3VudCk7CisJCWVyciA9IHZtX21hcF9wYWdlc196ZXJvKHZt YSwgbWFwLT5wYWdlcywgbWFwLT5jb3VudCk7CiAJCWlmIChlcnIpCiAJCQlnb3RvIG91dF9wdXRf bWFwOwogCX0gZWxzZSB7Ci0tIAoxLjkuMQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz LnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9259C31E40 for ; Tue, 30 Jul 2019 18:32:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A3662064A for ; Tue, 30 Jul 2019 18:32:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JUA9FbUP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A3662064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B059B8E0003; Tue, 30 Jul 2019 14:32:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB6FB8E0001; Tue, 30 Jul 2019 14:32:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A5DC8E0003; Tue, 30 Jul 2019 14:32:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by kanga.kvack.org (Postfix) with ESMTP id 64DBA8E0001 for ; Tue, 30 Jul 2019 14:32:50 -0400 (EDT) Received: by mail-pl1-f197.google.com with SMTP id y9so35834618plp.12 for ; Tue, 30 Jul 2019 11:32:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:mime-version:content-transfer-encoding; bh=6fCIBt83Qg0xm9/csFeyeLFWARKqAMvTELcBmphTpo0=; b=mSxpDZ05qQr87UsOdnhCVswEpoF8Q7XWTtAQApIJtpwvqZWmAOUgbjtYwnWKnDKz1t 65WZ5zsZEWlWN894VJ5IxFkIJSoyErSFsdY/eGMIqUh6e//xXT7QCkVsm3vCbItcvxC8 qnmgoslaCDY5sjMAqqn5M7jJGsd82og5os1F93eEIIv7DR5uzGJ0kDIUz+Ul/C/qmB+z oi9LhIVvOun6rPabRr9QAXgOXUB5Vi2ylxZ7JQd3PyZYnKmkqBDG6bLvAXQyFADz/6PM 99zjxx9nqOs+vIgmELPlvp/VmjhaWHRH265fr8M3ZCKD3Y+7JvmYskxQ6WzKLPAgZzG8 9mew== X-Gm-Message-State: APjAAAWmxf1lHa6/9A8c3dX9w7XO6uPXQUeIRg0IqcAhj8XA8TpIB9pD jjFfdlisenhUqpPK2/3cn6Vx5+cZdmHXo97ge8cn7+tPRwvCyA8gDBWHLkumK04EulQNYYf5rSJ TG5ZG1AP4GcngbJ+2AomYX5jEuk5aFoReQIaTv9Q58pmHWsbVo1wSkoJynuveXMAPeQ== X-Received: by 2002:a17:902:aa83:: with SMTP id d3mr113003944plr.74.1564511569918; Tue, 30 Jul 2019 11:32:49 -0700 (PDT) X-Received: by 2002:a17:902:aa83:: with SMTP id d3mr113003891plr.74.1564511569060; Tue, 30 Jul 2019 11:32:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564511569; cv=none; d=google.com; s=arc-20160816; b=RNScVMncVneQgs5A/4Jpt2N7mrZr8+5pLsCdTdjRFD8ZGHMNsnQmt5Q3A8DERm2dov j46z8r3HFoGFHwnDDVTze6OCc1nwm1eEcTsJe2MTzIoh238oL2sjxNsFLa+tZ6BDrdX6 KcS7rZzbKGmOLgoCS0T6Z01HGvk7bsX/z2DhK1V82ZrqZivw+3pRRYDnbLPhBXth4cD0 mTBk/rVYL1UqGXORItAgj61mRuqPirk9jTNXMggcqsxQAiKnWtf4+TycckGG0zvgWakQ S3+PYgib4isXddd12VCHcqzyNLc2nkUhYeIdJZkJovoK5Xi3VUFzjRL9XrtKED6QSIJQ BLhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=6fCIBt83Qg0xm9/csFeyeLFWARKqAMvTELcBmphTpo0=; b=oeoTaD2GHUrhBmOjAWkiFb+BPjeBe/fWoUAvGmin3Sj1rMzoGCKmzPrVTPai10e8cQ dNuTltlDOqnVZ/AWiH2HI/AhsEHOjuCAs4hrSewPe7UeEVvIVneYWKPnHVqIUIhCb95E g2pYIyZpS/szJpmIS1Pp24a0rkPUGi4JdG1oWLaXuS3KcxTxakhrnFQA8BbEWOcJw7TJ 3HEm6bnI6eRIIANOWJkKmwnOSJLWFWkW1VpUysmgI/ZRfCENUTENls8ZYjJyi7hVQiiJ gZ5ixc5UfFNZDxiHWQ/8l0yLcWJBE6Sm3WJqpsiFpfQ/dGJNg46LYzdgKHoEBFJxiLy3 gxRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JUA9FbUP; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id n6sor47056200pfq.67.2019.07.30.11.32.48 for (Google Transport Security); Tue, 30 Jul 2019 11:32:49 -0700 (PDT) Received-SPF: pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JUA9FbUP; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6fCIBt83Qg0xm9/csFeyeLFWARKqAMvTELcBmphTpo0=; b=JUA9FbUPr0F6xNgBd5J9MHwHtCHrMpBJuNDTvZBzKBZeCmNsbohHado2HBbGTi0It9 yThD+OL5Bkf6Da9wJnEKF7n1ZuYfE+RCaAChBqmkI/jmB2QhloDai+ucTPidoKT2u6UQ 29UC6QoAyrEf4tN2GNQniwXjZkr83rJH4ak6SFrbJFSb15jmyMBIWZiHh1EgvVH6j48q cZKmuIlqPfwxsnRzt4ye0SXQ2NpyGAmqO03R0RsRzNRYkzGXP/3U1W6hIGXqsFMnjHXR g7Xo3I2gA+uPgrVqyPZw3rp948eNJFIjP60aR0GcG/CsRV9BR7dafhIdCpB5PUi2sogn ixHw== X-Google-Smtp-Source: APXvYqz3TKO5CR8bm9L/zAhw0K/5mmOOXYnkeug29AHRYcKaRz4UPuCN4Qa7WYzWXEa+PlUkZGXEBw== X-Received: by 2002:a62:754d:: with SMTP id q74mr42050335pfc.211.1564511568653; Tue, 30 Jul 2019 11:32:48 -0700 (PDT) Received: from jordon-HP-15-Notebook-PC.domain.name ([106.51.16.0]) by smtp.gmail.com with ESMTPSA id j5sm57328671pgp.59.2019.07.30.11.32.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 30 Jul 2019 11:32:47 -0700 (PDT) From: Souptick Joarder To: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, marmarek@invisiblethingslab.com Cc: willy@infradead.org, akpm@linux-foundation.org, linux@armlinux.org.uk, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, gregkh@linuxfoundation.org, Souptick Joarder Subject: [PATCH] xen/gntdev.c: Replace vm_map_pages() with vm_map_pages_zero() Date: Wed, 31 Jul 2019 00:04:56 +0530 Message-Id: <1564511696-4044-1-git-send-email-jrdr.linux@gmail.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 'commit df9bde015a72 ("xen/gntdev.c: convert to use vm_map_pages()")' breaks gntdev driver. If vma->vm_pgoff > 0, vm_map_pages() will: - use map->pages starting at vma->vm_pgoff instead of 0 - verify map->count against vma_pages()+vma->vm_pgoff instead of just vma_pages(). In practice, this breaks using a single gntdev FD for mapping multiple grants. relevant strace output: [pid 857] ioctl(7, IOCTL_GNTDEV_MAP_GRANT_REF, 0x7ffd3407b6d0) = 0 [pid 857] mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED, 7, 0) = 0x777f1211b000 [pid 857] ioctl(7, IOCTL_GNTDEV_SET_UNMAP_NOTIFY, 0x7ffd3407b710) = 0 [pid 857] ioctl(7, IOCTL_GNTDEV_MAP_GRANT_REF, 0x7ffd3407b6d0) = 0 [pid 857] mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_SHARED, 7, 0x1000) = -1 ENXIO (No such device or address) details here: https://github.com/QubesOS/qubes-issues/issues/5199 The reason is -> ( copying Marek's word from discussion) vma->vm_pgoff is used as index passed to gntdev_find_map_index. It's basically using this parameter for "which grant reference to map". map struct returned by gntdev_find_map_index() describes just the pages to be mapped. Specifically map->pages[0] should be mapped at vma->vm_start, not vma->vm_start+vma->vm_pgoff*PAGE_SIZE. When trying to map grant with index (aka vma->vm_pgoff) > 1, __vm_map_pages() will refuse to map it because it will expect map->count to be at least vma_pages(vma)+vma->vm_pgoff, while it is exactly vma_pages(vma). Converting vm_map_pages() to use vm_map_pages_zero() will fix the problem. Marek has tested and confirmed the same. Reported-by: Marek Marczykowski-Górecki Signed-off-by: Souptick Joarder Tested-by: Marek Marczykowski-Górecki --- drivers/xen/gntdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4c339c7..a446a72 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -1143,7 +1143,7 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) goto out_put_map; if (!use_ptemod) { - err = vm_map_pages(vma, map->pages, map->count); + err = vm_map_pages_zero(vma, map->pages, map->count); if (err) goto out_put_map; } else { -- 1.9.1