From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:37914 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731844AbfHASAS (ORCPT ); Thu, 1 Aug 2019 14:00:18 -0400 Subject: [net v1 PATCH 0/4] net: fix regressions for generic-XDP From: Jesper Dangaard Brouer Date: Thu, 01 Aug 2019 20:00:11 +0200 Message-ID: <156468229108.27559.2443904494495785131.stgit@firesoul> In-Reply-To: <20190731211211.GA87084@multapplied.net> References: <20190731211211.GA87084@multapplied.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: xdp-newbies-owner@vger.kernel.org List-ID: To: netdev@vger.kernel.org, "David S. Miller" Cc: xdp-newbies@vger.kernel.org, Daniel Borkmann , brandon.cazander@multapplied.net, Alexei Starovoitov , Jesper Dangaard Brouer Thanks to Brandon Cazander, who wrote a very detailed bug report that even used perf probe's on xdp-newbies mailing list, we discovered that generic-XDP contains some regressions when using bpf_xdp_adjust_head(). First issue were that my selftests script, that use bpf_xdp_adjust_head(), by mistake didn't use generic-XDP any-longer. That selftest should have caught the real regression introduced in commit 458bf2f224f0 ("net: core: support XDP generic on stacked devices."). To verify this patchset fix the regressions, you can invoked manually via: cd tools/testing/selftests/bpf/ sudo ./test_xdp_vlan_mode_generic.sh sudo ./test_xdp_vlan_mode_native.sh Link: https://www.spinics.net/lists/xdp-newbies/msg01231.html Fixes: 458bf2f224f0 ("net: core: support XDP generic on stacked devices.") Reported by: Brandon Cazander Signed-off-by: Jesper Dangaard Brouer --- Jesper Dangaard Brouer (4): bpf: fix XDP vlan selftests test_xdp_vlan.sh selftests/bpf: add wrapper scripts for test_xdp_vlan.sh selftests/bpf: reduce time to execute test_xdp_vlan.sh net: fix bpf_xdp_adjust_head regression for generic-XDP net/core/dev.c | 15 ++++- tools/testing/selftests/bpf/Makefile | 3 + tools/testing/selftests/bpf/test_xdp_vlan.sh | 57 ++++++++++++++++---- .../selftests/bpf/test_xdp_vlan_mode_generic.sh | 9 +++ .../selftests/bpf/test_xdp_vlan_mode_native.sh | 9 +++ 5 files changed, 75 insertions(+), 18 deletions(-) create mode 100755 tools/testing/selftests/bpf/test_xdp_vlan_mode_generic.sh create mode 100755 tools/testing/selftests/bpf/test_xdp_vlan_mode_native.sh --