From: Oliver Neukum <oneukum@suse.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
dtor@chromium.org, andreyknvl@google.com,
syzkaller-bugs@googlegroups.com, robh@kernel.org,
srinivas.kandagatla@linaro.org, gregkh@linuxfoundation.org,
mans@mansr.com, mathias.payer@nebelwelt.net,
stern@rowland.harvard.edu,
syzbot+d1fedb1c1fdb07fca507@syzkaller.appspotmail.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: KASAN: use-after-free Read in usb_free_coherent
Date: Mon, 05 Aug 2019 11:44:47 +0200 [thread overview]
Message-ID: <1564998287.4248.5.camel@suse.com> (raw)
In-Reply-To: <8d2b9cb5-d32c-e24c-c973-a3a11a436dc6@arm.com>
Am Donnerstag, den 01.08.2019, 11:52 +0100 schrieb Suzuki K Poulose:
>
> Looks like the yurex_delete() drops the ref count on the dev->udev
> way early in the function and then later tries to see if there
> are any other buffers associated with it worth releasing. So,
> I am guessing moving the usb_put_dev(), after we have finished
> all that might solve the issue ?
Hi,
the fix looks good to me.
Regards
Oliver
prev parent reply other threads:[~2019-08-05 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 10:38 KASAN: use-after-free Read in usb_free_coherent syzbot
2019-08-01 10:52 ` Suzuki K Poulose
2019-08-05 9:44 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564998287.4248.5.camel@suse.com \
--to=oneukum@suse.com \
--cc=andreyknvl@google.com \
--cc=dtor@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
--cc=mathias.payer@nebelwelt.net \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=suzuki.poulose@arm.com \
--cc=syzbot+d1fedb1c1fdb07fca507@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.