Re: [PATCH 06/11] drm/i915: Add function to set subslices

["Summers, Stuart" <stuart.summers@intel.com>]

On Wed, 2019-08-21 at 23:32 +0100, Chris Wilson wrote:
> Quoting Stuart Summers (2019-08-21 00:05:39)
> > Add a new function to set a set of subslices for a given
> > slice.
> > 
> > Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> > ---
> >  drivers/gpu/drm/i915/gt/intel_sseu.c     |  6 ++++++
> >  drivers/gpu/drm/i915/gt/intel_sseu.h     |  3 +++
> >  drivers/gpu/drm/i915/intel_device_info.c | 18 +++++++++++-------
> >  3 files changed, 20 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c
> > b/drivers/gpu/drm/i915/gt/intel_sseu.c
> > index 3a5c0f7b5a08..79a9b5f186f9 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_sseu.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_sseu.c
> > @@ -30,6 +30,12 @@ intel_sseu_subslice_total(const struct
> > sseu_dev_info *sseu)
> >         return total;
> >  }
> >  
> > +void intel_sseu_set_subslices(struct sseu_dev_info *sseu, int
> > slice,
> > +                             u8 ss_mask)
> > +{
> > +       sseu->subslice_mask[i] = ss_mask & 0xff;
> 
> What's i?

Should be slice, not i :( not sure why the build wasn't catching this.

I'll fix in the next revision, thanks for the catch!

- Stuart

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx